Skip to contentSkip to conversation

drm/i915: Turn on PIN_GLOBAL in i915_gem_object_ggtt_pin

PATCH Applied Tvrtko Ursulin 3 participants 3 messages Mar 17, 2015 – Mar 18, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: Turn on PIN_GLOBAL in i915_gem_object_ggtt_pin

From: Tvrtko Ursulin <[email protected]>

This makes the interface consistent to old i915_gem_obj_ggtt_pin.

---
 drivers/gpu/drm/i915/i915_gem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_gem.c +1 -1
index e150038..533ef37 100644
@@ -4292,7 +4292,7 @@ i915_gem_object_ggtt_pin(struct drm_i915_gem_object *obj,
 		return -EINVAL;
 
 	return i915_gem_object_do_pin(obj, i915_obj_to_ggtt(obj), view,
-				      alignment, flags);
+				      alignment, flags | PIN_GLOBAL);
 }
 
 void
Signature · 6 lines
2.3.2

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw
Quoted 6 lines · Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

This makes the interface consistent to old i915_gem_obj_ggtt_pin.

Ok our naming of gem/vma pin/unpin/bind/unbind functions seems to be a rather impressive mess now. We have lots of special-cases with devilishly close names and distinct behaviour. This needs to be cleaned up once rotated and partial views have landed.

Queued for -next meanwhile, thanks for the patch.
-Daniel

Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Tested-by on v1 1/1
#2 lore raw
In reply to Tvrtko Ursulin

Task id: 5986 -------------------------------------Summary-------------------------------------
Platform Delta drm-intel-nightly Series Applied

PNV                 -2              268/268              266/268
ILK                 -1              303/303              302/303
SNB                                  283/283              283/283
IVB                                  343/343              343/343
BYT                                  287/287              287/287
HSW                                  363/363              363/363
BDW                                  308/308              308/308
-------------------------------------Detailed-------------------------------------
Platform  Test                                drm-intel-nightly          Series Applied
 PNV  igt_gem_userptr_blits_coherency-sync      CRASH(1)PASS(3)      CRASH(1)PASS(1)
 PNV  igt_gem_tiled_pread_pwrite      FAIL(1)PASS(3)      FAIL(1)PASS(1)
*ILK  igt_gem_seqno_wrap      PASS(2)      DMESG_WARN(1)PASS(1)

Note: You need to pay more attention to line start with '*'
_______________________________________________
Intel-gfx mailing list [email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx