Skip to contentSkip to conversation

package/perf: fix build failures with high 'make -j' values

PATCH Superseded Steven Noonan 2 participants 2 messages Mar 18, 2015 – Mar 19, 2015

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/perf: fix build failures with high 'make -j' values

The 'perf' Makefile is flaky on some kernel versions. It will still parallelize the build even with 'make -j1' because it explicitly invokes a sub-make with the correct flags. But the top-level make is not smart enough to handle large '-j' values.

---
 package/perf/perf.mk | 2 ++
 1 file changed, 2 insertions(+)
package/perf/perf.mk +2 -0
index 1fcc258..f6591a6 100644
@@ -22,6 +22,8 @@ PERF_MAKE_FLAGS = \
 	WERROR=0 \
 	ASCIIDOC=
 
+PERF_MAKE_FLAGS += -j1
+
 # The call to backtrace() function fails for ARC, because for some
 # reason the unwinder from libgcc returns early. Thus the usage of
 # backtrace() should be disabled in perf explicitly: at build time
Signature · 1 line
2.3.3
#1 lore raw

PATCH 1/1 package/perf: fix build failures with high 'make -j' values

Hi Steven,

Quoted 15 lines · Steven Noonan

The 'perf' Makefile is flaky on some kernel versions. It will still parallelize the build even with 'make -j1' because it explicitly invokes a sub-make with the correct flags. But the top-level make is not smart enough to handle large '-j' values.

---
 package/perf/perf.mk | 2 ++
 1 file changed, 2 insertions(+)
package/perf/perf.mk +0 -0
index 1fcc258..f6591a6 100644

package/perf/perf.mk PERF_MAKE_FLAGS = \ · line 25

Quoted 4 lines
package/perf/perf.mk +1 -0
@@ -22,6 +22,8 @@ PERF_MAKE_FLAGS = \
 	WERROR=0 \
 	ASCIIDOC=
 
+PERF_MAKE_FLAGS += -j1

Please use $(MAKE1).

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -