Skip to contentSkip to conversation

package/perf: fix build failures with high 'make -j' values

PATCH New Steven Noonan 2 participants 2 messages Mar 19, 2015

lore
Share & tools
lore

Steven Noonan

author
#0 lore raw

PATCH v2 1/1 package/perf: fix build failures with high 'make -j' values

The 'perf' Makefile is flaky on some kernel versions. It will still parallelize the build even with 'make -j1' because it explicitly invokes a sub-make with the correct flags. But the top-level make is not smart enough to handle large '-j' values.

Signed-off-by Steven Noonan <[email protected]>

---

v2:
- Use $(MAKE1) instead of appending '-j1' to PERF_MAKE_FLAGS.

 package/perf/perf.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/perf/perf.mk +2 -2
index 1fcc258..bbdcc5a 100644
@@ -53,14 +53,14 @@ define PERF_BUILD_CMDS
 			fi \
 		fi \
 	fi
-	$(TARGET_MAKE_ENV) $(MAKE) -C $(LINUX_DIR)/tools/perf \
+	$(TARGET_MAKE_ENV) $(MAKE1) -C $(LINUX_DIR)/tools/perf \
 		$(PERF_MAKE_FLAGS) O=$(@D)
 endef
 
 # After installation, we remove the Perl and Python scripts from the
 # target.
 define PERF_INSTALL_TARGET_CMDS
-	$(TARGET_MAKE_ENV) $(MAKE) -C $(LINUX_DIR)/tools/perf \
+	$(TARGET_MAKE_ENV) $(MAKE1) -C $(LINUX_DIR)/tools/perf \
 		$(PERF_MAKE_FLAGS) O=$(@D) install
 	$(RM) -rf $(TARGET_DIR)/usr/libexec/perf-core/scripts/
 endef
Signature · 1 line
2.3.3
Applied
#1 lore raw

PATCH v2 1/1 package/perf: fix build failures with high 'make -j' values

Dear Steven Noonan,

Quoted 6 lines · Steven Noonan

The 'perf' Makefile is flaky on some kernel versions. It will still parallelize the build even with 'make -j1' because it explicitly invokes a sub-make with the correct flags. But the top-level make is not smart enough to handle large '-j' values.

Signed-off-by Steven Noonan <[email protected]>

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com