Skip to contentSkip to conversation

openocd: openjtag needs libusb-compat

PATCH New Baruch Siach 3 participants 3 messages Mar 24, 2015

lore
Share & tools
lore

Baruch Siach

author
#0 lore raw

PATCH 1/1 openocd: openjtag needs libusb-compat

Since commit 9bdf5926 (package/openocd: depends on libftdi1 instead of libftdi) the OpenJTAG Programmer can be built without libusb-compat, that is a dependency of libftdi (but not libftdi1). This breaks the build, because openjtag.c uses libusb-compat headers. Select BR2_PACKAGE_LIBUSB_COMPAT to fix this.

Fixes:
http://autobuild.buildroot.net/results/d19/d1969e6df56835568fb908b7f252aec0915d9fa4/
http://autobuild.buildroot.net/results/f06/f06ed6df6138ab399036c397c3f72d33d64fe0a3/
http://autobuild.buildroot.net/results/bd7/bd7f90f3cc1d2b395f9849eb0630c2602a075bf5/
...

Cc Samuel Martin <[email protected]>
Signed-off-by Baruch Siach <[email protected]>
---
 package/openocd/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/openocd/Config.in +1 -0
index 2db17fa76a1a..d84aac18f08e 100644
@@ -186,6 +186,7 @@ config BR2_PACKAGE_OPENOCD_PRESTO
 config BR2_PACKAGE_OPENOCD_OPENJTAG
 	bool "OpenJTAG Programmer"
 	select BR2_PACKAGE_LIBFTDI1
+	select BR2_PACKAGE_LIBUSB_COMPAT # needs usb.h
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libftdi -> libusb
 	depends on BR2_ARCH_HAS_ATOMICS
 	help
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 openocd: openjtag needs libusb-compat

Hi Baruch, all,

Quoted 6 lines · Baruch Siach

Since commit 9bdf5926 (package/openocd: depends on libftdi1 instead of libftdi) the OpenJTAG Programmer can be built without libusb-compat, that is a dependency of libftdi (but not libftdi1). This breaks the build, because openjtag.c uses libusb-compat headers. Select BR2_PACKAGE_LIBUSB_COMPAT to fix this.

Quoted 8 lines

Fixes:
http://autobuild.buildroot.net/results/d19/d1969e6df56835568fb908b7f252aec0915d9fa4/
http://autobuild.buildroot.net/results/f06/f06ed6df6138ab399036c397c3f72d33d64fe0a3/
http://autobuild.buildroot.net/results/bd7/bd7f90f3cc1d2b395f9849eb0630c2602a075bf5/
...

Cc Samuel Martin <[email protected]>
Signed-off-by Baruch Siach <[email protected]>
Reviewed-by Samuel Martin <[email protected]>

Regards,

Signature · 1 line
Samuel
Applied
#2 lore raw

PATCH 1/1 openocd: openjtag needs libusb-compat

In reply to Baruch Siach

Dear Baruch Siach,

Quoted 6 lines · Baruch Siach

Since commit 9bdf5926 (package/openocd: depends on libftdi1 instead of libftdi) the OpenJTAG Programmer can be built without libusb-compat, that is a dependency of libftdi (but not libftdi1). This breaks the build, because openjtag.c uses libusb-compat headers. Select BR2_PACKAGE_LIBUSB_COMPAT to fix this.

Quoted 8 lines

Fixes:
http://autobuild.buildroot.net/results/d19/d1969e6df56835568fb908b7f252aec0915d9fa4/
http://autobuild.buildroot.net/results/f06/f06ed6df6138ab399036c397c3f72d33d64fe0a3/
http://autobuild.buildroot.net/results/bd7/bd7f90f3cc1d2b395f9849eb0630c2602a075bf5/
...

Cc Samuel Martin <[email protected]>
Signed-off-by Baruch Siach <[email protected]>

Applied, thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com