x86/wmi: delete unused wmi_data_lock mutex causing gcc warning
PATCH 1/1 x86/wmi: delete unused wmi_data_lock mutex causing gcc warning
In commit bff431e49ff531a343fbb2b4426e313000844f32 ("ACPI: WMI: Add ACPI-WMI mapping driver") this mutex was added, but the rest of the final commit never actually made use of it, resulting in:
In file included from include/linux/mutex.h:29:0,
from include/linux/kernfs.h:13,
from include/linux/sysfs.h:15,
from include/linux/kobject.h:21,
from include/linux/device.h:17,
from drivers/platform/x86/wmi.c:35:
drivers/platform/x86/wmi.c:48:21: warning: ‘wmi_data_lock’ defined but not used [-Wunused-variable]
static DEFINE_MUTEX(wmi_data_lock);
^A git grep shows no other instances/references to the wmi_data_lock. Delete it, assuming that the mutex addition was just a leftover from an earlier work in progress version of the change, since the original dates from 2008.
--- drivers/platform/x86/wmi.c | 1 - 1 file changed, 1 deletion(-)
drivers/platform/x86/wmi.c +0 -1
@@ -45,7 +45,6 @@ MODULE_LICENSE("GPL");#define ACPI_WMI_CLASS "wmi" -static DEFINE_MUTEX (wmi_data_lock);static LIST_HEAD (wmi_block_list);struct guid_block {
Signature · 1 line
2.2.1
Darren Hart
AppliedQuoted 14 lines · Paul Gortmaker
In commit
bff431e49ff531a343fbb2b4426e313000844f32("ACPI: WMI: Add ACPI-WMI mapping driver") this mutex was added, but the rest of the final commit never actually made use of it, resulting in:In file included from
include/linux/mutex.h:29:0,from include/linux/kernfs.h:13, from include/linux/sysfs.h:15, from include/linux/kobject.h:21, from include/linux/device.h:17, from drivers/platform/x86/wmi.c:35: drivers/platform/x86/wmi.c:48:21: warning: ‘wmi_data_lock’ defined but not used [-Wunused-variable] static DEFINE_MUTEX(wmi_data_lock); ^
Quoted 6 lines
A git grep shows no other instances/references to the
wmi_data_lock. Delete it, assuming that the mutex addition was just a leftover from an earlier work in progress version of the change, since the original dates from 2008.Signed-off-by Paul Gortmaker <[email protected]>
Queued, thank you Paul.
Signature · 2 lines
Darren Hart Intel Open Source Technology Center