Staging: dgnc: Reduce line size to increase readability
PATCH 1/1 Staging: dgnc: Reduce line size to increase readability
Reduce line size to increase code readability.
Signed-off-by Vatika Harlalka <[email protected]>
--- drivers/staging/dgnc/dgnc_neo.c | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-)
drivers/staging/dgnc/dgnc_neo.c +14 -7
@@ -333,7 +333,8 @@ static inline void neo_set_new_start_stop_chars(struct channel_t *ch) {/* if hardware flow control is set, then skip this whole thing */ -if (ch->ch_digi.digi_flags & (CTSPACE |RTSPACE ) || ch->ch_c_cflag &CRTSCTS ) +if (ch->ch_digi.digi_flags & (CTSPACE |RTSPACE ) || + ch->ch_c_cflag &CRTSCTS )return ;/* Tell UART what start/stop chars it should be looking for */
@@ -684,7 +685,8 @@ static void neo_param(struct tty_struct *tty) };/* Only use the TXPrint baud rate if the terminal unit is NOT open */ -if (!(ch->ch_tun.un_flags &UN_ISOPEN ) && (un->un_type ==DGNC_PRINT )) +if (!(ch->ch_tun.un_flags &UN_ISOPEN ) && + (un->un_type ==DGNC_PRINT )) baud =C_BAUD (ch->ch_pun.un_tty) &0xff ;else baud =C_BAUD (ch->ch_tun.un_tty) &0xff ;
@@ -697,7 +699,8 @@ static void neo_param(struct tty_struct *tty) jindex = baud; -if ((iindex >=0 ) && (iindex <4 ) && (jindex >=0 ) && (jindex <16 )) +if ((iindex >=0 ) && (iindex <4 ) && + (jindex >=0 ) && (jindex <16 )) baud = bauds[iindex][jindex];else baud =0 ;
@@ -801,11 +804,13 @@ static void neo_param(struct tty_struct *tty)/* Set new start/stop chars */ neo_set_new_start_stop_chars (ch); -if (ch->ch_digi.digi_flags &CTSPACE || ch->ch_c_cflag &CRTSCTS ) { +if (ch->ch_digi.digi_flags &CTSPACE || + ch->ch_c_cflag &CRTSCTS ) {neo_set_cts_flow_control (ch); }else if (ch->ch_c_iflag &IXON ) {/* If start/stop is set to disable, then we should disable flow control */ -if ((ch->ch_startc == _POSIX_VDISABLE) || (ch->ch_stopc == _POSIX_VDISABLE)) +if ((ch->ch_startc == _POSIX_VDISABLE) || + (ch->ch_stopc == _POSIX_VDISABLE))neo_set_no_output_flow_control (ch);else neo_set_ixon_flow_control (ch);
@@ -817,7 +822,8 @@ static void neo_param(struct tty_struct *tty)neo_set_rts_flow_control (ch); }else if (ch->ch_c_iflag &IXOFF ) {/* If start/stop is set to disable, then we should disable flow control */ -if ((ch->ch_startc == _POSIX_VDISABLE) || (ch->ch_stopc == _POSIX_VDISABLE)) +if ((ch->ch_startc == _POSIX_VDISABLE) || + (ch->ch_stopc == _POSIX_VDISABLE))neo_set_no_input_flow_control (ch);else neo_set_ixoff_flow_control (ch);
@@ -1200,7 +1206,8 @@ static void neo_copy_data_from_uart_to_queue(struct channel_t *ch) linestatus =0 ;/* Copy data from uart to the queue */ -memcpy_fromio (ch->ch_rqueue + head, &ch->ch_neo_uart->txrxburst, n); +memcpy_fromio (ch->ch_rqueue + head, + &ch->ch_neo_uart->txrxburst, n);/* * Since RX_FIFO_DATA_ERROR was 0, we are guarenteed
Signature · 1 line
1.9.1
Greg KH
maintainerQuoted 12 lines · Vatika Harlalka
Reduce line size to increase code readability.
Signed-off-by Vatika Harlalka <[email protected]>--- drivers/staging/dgnc/dgnc_neo.c | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-)drivers/staging/dgnc/dgnc_neo.c +0
-0
drivers/staging/dgnc/dgnc_neo.c static inline void neo_set_new_start_stop_chars(struct channel_t *ch) · line 337
Quoted 6 lines
drivers/staging/dgnc/dgnc_neo.c +2
-1@@ -333,7 +333,8 @@ static inline void neo_set_new_start_stop_chars(struct channel_t *ch) {/* if hardware flow control is set, then skip this whole thing */ -if (ch->ch_digi.digi_flags & (CTSPACE |RTSPACE ) || ch->ch_c_cflag &CRTSCTS ) +if (ch->ch_digi.digi_flags & (CTSPACE |RTSPACE ) || + ch->ch_c_cflag &CRTSCTS )
Indentation should be lined up with the ( on the line above, not the full indent, otherwise it runs into the lines below when trying to read the code.
thanks,
greg k-h