Skip to contentSkip to conversation

mjpg-streamer: Fix build with ccache enabled.

PATCH New Nicolas Cavallari 2 participants 2 messages Mar 27, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mjpg-streamer: Fix build with ccache enabled.

Quote the TARGET_CC variable, otherwise, if ccache is enabled:

[...] make CC=$TARGET_CC [...]
is expanded to e.g.
[...] make CC=ccache gcc [...]

The build succeeds with "make[2]: Nothing to be done for '[...]gcc'". and the program is compiled at "make install" time, with the default host compiler, resulting in a binary that does not run on the target.

---
 package/mjpg-streamer/mjpg-streamer.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/mjpg-streamer/mjpg-streamer.mk +1 -1
index 2385429..e10e9a8 100644
@@ -15,7 +15,7 @@ MJPG_STREAMER_LICENSE_FILES = LICENSE
 MJPG_STREAMER_DEPENDENCIES = jpeg
 
 define MJPG_STREAMER_BUILD_CMDS
-	$(TARGET_MAKE_ENV) $(MAKE) CC=$(TARGET_CC) -C $(@D)
+	$(TARGET_MAKE_ENV) $(MAKE) CC="$(TARGET_CC)" -C $(@D)
 endef
 
 define MJPG_STREAMER_INSTALL_TARGET_CMDS
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 mjpg-streamer: Fix build with ccache enabled.

Dear Nicolas Cavallari,

Quoted 6 lines · Nicolas Cavallari

Quote the TARGET_CC variable, otherwise, if ccache is enabled:

[...] make CC=$TARGET_CC [...]
is expanded to e.g.
[...] make CC=ccache gcc [...]

Quoted 8 lines

The build succeeds with "make[2]: Nothing to be done for '[...]gcc'". and the program is compiled at "make install" time, with the default host compiler, resulting in a binary that does not run on the target.

---
 package/mjpg-streamer/mjpg-streamer.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com