Skip to contentSkip to conversation

config: Define BOOTP client architecture and VCI for ARMv8

PATCH In review Thierry Reding 3 participants 6 messages Mar 20, 2015 – Mar 28, 2015

lore
Share & tools
lore

Thierry Reding

author
#0 lore raw

PATCH 1/1 config: Define BOOTP client architecture and VCI for ARMv8

From: Thierry Reding <[email protected]>

Reuse the 32-bit ARM client architecture and identify ARMv8 specifically by setting the BOOTP VCI string.

Cc Dennis Gilmore <[email protected]>
Cc Tom Rini <[email protected]>
Signed-off-by Thierry Reding <[email protected]>
---
 include/config_distro_defaults.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
include/config_distro_defaults.h +3 -1
index f4a01ba80642..8237239c0021 100644
@@ -20,10 +20,12 @@
 #define CONFIG_BOOTP_PXE
 #define CONFIG_BOOTP_SUBNETMASK
 
-#if defined(__arm__)
+#if defined(__arm__) || defined(__aarch64__)
 #define CONFIG_BOOTP_PXE_CLIENTARCH     0x100
 #if defined(__ARM_ARCH_7__) || defined(__ARM_ARCH_7A__)
 #define CONFIG_BOOTP_VCI_STRING         "U-boot.armv7"
+#elif defined(__aarch64__)
+#define CONFIG_BOOTP_VCI_STRING         "U-boot.armv8"
 #else
 #define CONFIG_BOOTP_VCI_STRING         "U-boot.arm"
 #endif
Signature · 1 line
2.3.2
#1 lore raw

PATCH 1/1 config: Define BOOTP client architecture and VCI for ARMv8

Quoted 4 lines · Thierry Reding

From: Thierry Reding <[email protected]>

Reuse the 32-bit ARM client architecture and identify ARMv8 specifically by setting the BOOTP VCI string.

Is there a newer version of https://www.rfc-editor.org/rfc/rfc4578.txt
that says what this value should be? Even 32-bit ARM isn't in that document, so I'm not sure where 0x100 came from.

http://www.iana.org/assignments/bootp-dhcp-parameters/bootp-dhcp-parameters.txt
lists RFC4578 as the document that defines these options, so I guess values have never been allocated for ARM?

#2 lore raw

PATCH 1/1 config: Define BOOTP client architecture and VCI for ARMv8

Quoted 10 lines · Stephen Warren
Quoted 4 lines · Thierry Reding

From: Thierry Reding <[email protected]>

Reuse the 32-bit ARM client architecture and identify ARMv8 specifically by setting the BOOTP VCI string.

Is there a newer version of
https://www.rfc-editor.org/rfc/rfc4578.txt that says what this value should be? Even 32-bit ARM isn't in that document, so I'm not sure where 0x100 came from.

I wonder if 0x100 is treated by the PXE implementations as "set but invalid, don't use". Digging into some PXE servers would shed some light here.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150320/69d5ea8c/attachment.sig>
#3 lore raw

PATCH 1/1 config: Define BOOTP client architecture and VCI for ARMv8

Quoted 7 lines · Tom Rini
Quoted 6 lines · Stephen Warren
Quoted 4 lines · Thierry Reding

From: Thierry Reding <[email protected]>

Reuse the 32-bit ARM client architecture and identify ARMv8 specifically by setting the BOOTP VCI string.

Quoted 8 lines
Quoted 4 lines

Is there a newer version of
https://www.rfc-editor.org/rfc/rfc4578.txt that says what this value should be? Even 32-bit ARM isn't in that document, so I'm not sure where 0x100 came from.

I wonder if 0x100 is treated by the PXE implementations as "set but invalid, don't use". Digging into some PXE servers would shed some light here.

I can't actually find any use of this in ISC DHCPd. At most, it might be a value that user config files can match against if they want. I guess it's not worth worrying about?

#4 lore raw

PATCH 1/1 config: Define BOOTP client architecture and VCI for ARMv8

Quoted 13 lines · Stephen Warren
Quoted 12 lines · Tom Rini
Quoted 10 lines · Stephen Warren
Quoted 4 lines · Thierry Reding

From: Thierry Reding <[email protected]>

Reuse the 32-bit ARM client architecture and identify ARMv8 specifically by setting the BOOTP VCI string.

Is there a newer version of
https://www.rfc-editor.org/rfc/rfc4578.txt that says what this value should be? Even 32-bit ARM isn't in that document, so I'm not sure where 0x100 came from.

Quoted 7 lines
Quoted 3 lines

I wonder if 0x100 is treated by the PXE implementations as "set but invalid, don't use". Digging into some PXE servers would shed some light here.

I can't actually find any use of this in ISC DHCPd. At most, it might be a value that user config files can match against if they want. I guess it's not worth worrying about?

Yeah, sounds like it to me.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150325/6c16ef72/attachment.sig>
#5 lore raw
In reply to Thierry Reding
Quoted 8 lines · Thierry Reding

From: Thierry Reding <[email protected]>

Reuse the 32-bit ARM client architecture and identify ARMv8 specifically by setting the BOOTP VCI string.

Cc Dennis Gilmore <[email protected]>
Cc Tom Rini <[email protected]>
Signed-off-by Thierry Reding <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150328/fb92dc81/attachment.sig>