Add DT support for netxbig LEDs

PATCH New Simon Guinot 4 participants 13 messages Feb 23, 2015 – Mar 30, 2015

Subsystems (6)

Device tree bindings Arm (32-bit) Arm sub-architectures GPIO +2 more subsystems

lore

Share & tools

lore

Simon Guinot

author

2015-02-23 15:04 UTC #0 lore raw

cover Add DT support for netxbig LEDs

Hello,

This patch series adds DT support for the LEDs found on the Kirkwood-based LaCie boards 2Big and 5Big Network v2.

Simon

Simon Guinot (3):
leds: netxbig: add device tree binding
ARM: Kirkwood: add LED DT entries for netxbig boards
ARM: mvebu: remove static LED setup for netxbig boards

 .../devicetree/bindings/gpio/netxbig-gpio-ext.txt  |  22 ++
 .../devicetree/bindings/leds/leds-netxbig.txt      |  90 ++++++++
 arch/arm/boot/dts/kirkwood-net5big.dts             |  60 +++++
 arch/arm/boot/dts/kirkwood-netxbig.dtsi            |  80 +++++++
 arch/arm/mach-mvebu/Kconfig                        |   7 -
 arch/arm/mach-mvebu/Makefile                       |   1 -
 arch/arm/mach-mvebu/board.h                        |  21 --
 arch/arm/mach-mvebu/kirkwood.c                     |   4 -
 arch/arm/mach-mvebu/netxbig.c                      | 191 ----------------
 drivers/leds/leds-netxbig.c                        | 244 +++++++++++++++++++--
 include/dt-bindings/leds/leds-netxbig.h            |  18 ++
 11 files changed, 493 insertions(+), 245 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/gpio/netxbig-gpio-ext.txt
 create mode 100644 Documentation/devicetree/bindings/leds/leds-netxbig.txt
 delete mode 100644 arch/arm/mach-mvebu/board.h
 delete mode 100644 arch/arm/mach-mvebu/netxbig.c
 create mode 100644 include/dt-bindings/leds/leds-netxbig.h

Signature · 1 line

2.1.1

Simon Guinot

author

2015-02-23 15:04 UTC #1 lore raw

PATCH 1/3 leds: netxbig: add device tree binding

This patch adds device tree support for the netxbig LEDs.

This also introduces a additionnal DT binding for the GPIO extension bus (netxbig-gpio-ext) used to configure the LEDs. Since this bus could also be used to control other devices, then it seems more suitable to have it in a separate DT binding.

Signed-off-by Simon Guinot <[email protected]>

---
 .../devicetree/bindings/gpio/netxbig-gpio-ext.txt  |  22 ++
 .../devicetree/bindings/leds/leds-netxbig.txt      |  90 ++++++++
 drivers/leds/leds-netxbig.c                        | 244 +++++++++++++++++++--
 include/dt-bindings/leds/leds-netxbig.h            |  18 ++
 4 files changed, 353 insertions(+), 21 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/gpio/netxbig-gpio-ext.txt
 create mode 100644 Documentation/devicetree/bindings/leds/leds-netxbig.txt
 create mode 100644 include/dt-bindings/leds/leds-netxbig.h

Documentation/devicetree/bindings/gpio/netxbig-gpio-ext.txt new file +22 -0

new file mode 100644
index 000000000000..e4fb2fe11086
@@ -0,0 +1,22 @@
+Binding for the GPIO extension bus found on some LaCie/Seagate boards
+(Example: 2Big/5Big Network v2, 2Big NAS).
+
+Required properties:
+- compatible: "lacie,netxbig-gpio-ext".
+- addr-gpios: GPIOs representing the address register.
+- data-gpios: GPIOs representing the data register.
+- enable-gpio: GPIO used to enable the new configuration (address, data).
+
+Example:
+
+netxbig_gpio_ext: netxbig-gpio-ext {
+	compatible = "lacie,netxbig-gpio-ext";
+
+	addr-gpios = <&gpio1 15 GPIO_ACTIVE_HIGH
+		      &gpio1 16 GPIO_ACTIVE_HIGH
+		      &gpio1 17 GPIO_ACTIVE_HIGH>;
+	data-gpios = <&gpio1 12 GPIO_ACTIVE_HIGH
+		      &gpio1 13 GPIO_ACTIVE_HIGH
+		      &gpio1 14 GPIO_ACTIVE_HIGH>;
+	enable-gpio = <&gpio0 29 GPIO_ACTIVE_HIGH>;
+};

Documentation/devicetree/bindings/leds/leds-netxbig.txt new file +90 -0

90 lines not on this page · raw message

drivers/leds/leds-netxbig.c +223 ~~-21~~

306 lines not on this page · raw message

include/dt-bindings/leds/leds-netxbig.h new file +18 -0

new file mode 100644
index 000000000000..92658b0310b2
@@ -0,0 +1,18 @@
+/*
+ * This header provides constants for netxbig LED bindings.
+ *
+ * This file is licensed under the terms of the GNU General Public
+ * License version 2.  This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ */
+
+#ifndef _DT_BINDINGS_LEDS_NETXBIG_H
+#define _DT_BINDINGS_LEDS_NETXBIG_H
+
+#define NETXBIG_LED_OFF		0
+#define NETXBIG_LED_ON		1
+#define NETXBIG_LED_SATA	2
+#define NETXBIG_LED_TIMER1	3
+#define NETXBIG_LED_TIMER2	4
+
+#endif /* _DT_BINDINGS_LEDS_NETXBIG_H */

Signature · 1 line

2.1.1

Simon Guinot

author

2015-02-23 15:04 UTC #2 lore raw

PATCH 2/3 ARM: Kirkwood: add LED DT entries for netxbig boards

In reply to Simon Guinot

This patch adds DT entries for the LEDs found on the Kirkwood-based LaCie boards 2Big and 5Big Network v2.

Signed-off-by Simon Guinot <[email protected]>

---
 arch/arm/boot/dts/kirkwood-net5big.dts  | 60 +++++++++++++++++++++++++
 arch/arm/boot/dts/kirkwood-netxbig.dtsi | 80 +++++++++++++++++++++++++++++++++
 2 files changed, 140 insertions(+)

arch/arm/boot/dts/kirkwood-net5big.dts +60 -0

index 36155b749d9f..3cc5e469df06 100644
@@ -86,6 +86,66 @@
 			 clock-frequency = <32768>;
 	       };
 	};
+
+	netxbig-leds {
+		blue-sata2 {
+			label = "netxbig:blue:sata2";
+			mode-addr = <5>;
+			mode-val = <NETXBIG_LED_OFF 0
+				    NETXBIG_LED_ON 7
+				    NETXBIG_LED_SATA 1
+				    NETXBIG_LED_TIMER1 3>;
+			bright-addr = <2>;
+			bright-max = <7>;
+		};
+		red-sata2 {
+			label = "netxbig:red:sata2";
+			mode-addr = <5>;
+			mode-val = <NETXBIG_LED_OFF 0
+				    NETXBIG_LED_ON 2
+				    NETXBIG_LED_TIMER1 4>;
+			bright-addr = <2>;
+			bright-max = <7>;
+		};
+		blue-sata3 {
+			label = "netxbig:blue:sata3";
+			mode-addr = <6>;
+			mode-val = <NETXBIG_LED_OFF 0
+				    NETXBIG_LED_ON 7
+				    NETXBIG_LED_SATA 1
+				    NETXBIG_LED_TIMER1 3>;
+			bright-addr = <2>;
+			bright-max = <7>;
+		};
+		red-sata3 {
+			label = "netxbig:red:sata3";
+			mode-addr = <6>;
+			mode-val = <NETXBIG_LED_OFF 0
+				    NETXBIG_LED_ON 2
+				    NETXBIG_LED_TIMER1 4>;
+			bright-addr = <2>;
+			bright-max = <7>;
+		};
+		blue-sata4 {
+			label = "netxbig:blue:sata4";
+			mode-addr = <7>;
+			mode-val = <NETXBIG_LED_OFF 0
+				    NETXBIG_LED_ON 7
+				    NETXBIG_LED_SATA 1
+				    NETXBIG_LED_TIMER1 3>;
+			bright-addr = <2>;
+			bright-max = <7>;
+		};
+		red-sata4 {
+			label = "netxbig:red:sata4";
+			mode-addr = <7>;
+			mode-val = <NETXBIG_LED_OFF 0
+				    NETXBIG_LED_ON 2
+				    NETXBIG_LED_TIMER1 4>;
+			bright-addr = <2>;
+			bright-max = <7>;
+		};
+	};
 };
 
 &mdio {

arch/arm/boot/dts/kirkwood-netxbig.dtsi +80 -0

92 lines not on this page · raw message

Signature · 1 line

2.1.1

Simon Guinot

author

2015-02-23 15:04 UTC #3 lore raw

PATCH 3/3 ARM: mvebu: remove static LED setup for netxbig boards

In reply to Simon Guinot

Since DT support is now available for the LEDs found on the LaCie netxbig boards (Kirkwood-based), then the old-fashion netxbig board setup file is no longer needed. This patch removes this file.

Signed-off-by Simon Guinot <[email protected]>

---
 arch/arm/mach-mvebu/Kconfig    |   7 --
 arch/arm/mach-mvebu/Makefile   |   1 -
 arch/arm/mach-mvebu/board.h    |  21 -----
 arch/arm/mach-mvebu/kirkwood.c |   4 -
 arch/arm/mach-mvebu/netxbig.c  | 191 -----------------------------------------
 5 files changed, 224 deletions(-)
 delete mode 100644 arch/arm/mach-mvebu/board.h
 delete mode 100644 arch/arm/mach-mvebu/netxbig.c

arch/arm/mach-mvebu/Kconfig +0 -7

index c1e4567a5ab3..e58020bc80c0 100644
@@ -102,11 +102,4 @@ config MACH_KIRKWOOD
 	  Say 'Y' here if you want your kernel to support boards based
 	  on the Marvell Kirkwood device tree.
 
-config MACH_NETXBIG
-	bool "LaCie 2Big and 5Big Network v2"
-	depends on MACH_KIRKWOOD
-	help
-	  Say 'Y' here if you want your kernel to support the
-	  LaCie 2Big and 5Big Network v2
-
 endif

arch/arm/mach-mvebu/Makefile +0 -1

index b4f01497ce0b..ecf9e0c3b107 100644
@@ -13,4 +13,3 @@ endif
 
 obj-$(CONFIG_MACH_DOVE)		 += dove.o
 obj-$(CONFIG_MACH_KIRKWOOD)	 += kirkwood.o kirkwood-pm.o
-obj-$(CONFIG_MACH_NETXBIG)	 += netxbig.o

arch/arm/mach-mvebu/board.h deleted +0 ~~-21~~

deleted file mode 100644
index 98e32cc2ef3d..000000000000
@@ -1,21 +0,0 @@
-/*
- * Board functions for Marvell System On Chip
- *
- * Copyright (C) 2014
- *
- * Andrew Lunn <[email protected]>
- *
- * This file is licensed under the terms of the GNU General Public
- * License version 2.  This program is licensed "as is" without any
- * warranty of any kind, whether express or implied.
- */
-
-#ifndef __ARCH_MVEBU_BOARD_H
-#define __ARCH_MVEBU_BOARD_H
-
-#ifdef CONFIG_MACH_NETXBIG
-void netxbig_init(void);
-#else
-static inline void netxbig_init(void) {};
-#endif
-#endif

arch/arm/mach-mvebu/kirkwood.c +0 -4

index 6b5310828eb2..e81b33dc57d8 100644
@@ -25,7 +25,6 @@
 #include "kirkwood.h"
 #include "kirkwood-pm.h"
 #include "common.h"
-#include "board.h"
 
 static struct resource kirkwood_cpufreq_resources[] = {
 	[0] = {

@@ -180,9 +179,6 @@ static void __init kirkwood_dt_init(void)
 	kirkwood_pm_init();
 	kirkwood_dt_eth_fixup();
 
-	if (of_machine_is_compatible("lacie,netxbig"))
-		netxbig_init();
-
 	of_platform_populate(NULL, of_default_bus_match_table, auxdata, NULL);
 }

arch/arm/mach-mvebu/netxbig.c deleted +0 ~~-191~~

191 lines not on this page · raw message

Signature · 1 line

2.1.1

Simon Guinot

author

2015-03-09 09:41 UTC #4 lore raw

cover Add DT support for netxbig LEDs

In reply to Simon Guinot

Quoted 11 lines · Simon Guinot

Hello,
This patch series adds DT support for the LEDs found on the Kirkwood-based LaCie boards 2Big and 5Big Network v2.
Simon
Simon Guinot (3):
leds: netxbig: add device tree binding
ARM: Kirkwood: add LED DT entries for netxbig boards
ARM: mvebu: remove static LED setup for netxbig boards

Hi Brian,

Please, consider merging the first patch of this serie.

Thanks in advance.

Simon

Quoted 10 lines

 .../devicetree/bindings/gpio/netxbig-gpio-ext.txt  |  22 ++
 .../devicetree/bindings/leds/leds-netxbig.txt      |  90 ++++++++
 arch/arm/boot/dts/kirkwood-net5big.dts             |  60 +++++
 arch/arm/boot/dts/kirkwood-netxbig.dtsi            |  80 +++++++
 arch/arm/mach-mvebu/Kconfig                        |   7 -
 arch/arm/mach-mvebu/Makefile                       |   1 -
 arch/arm/mach-mvebu/board.h                        |  21 --
 arch/arm/mach-mvebu/kirkwood.c                     |   4 -
 arch/arm/mach-mvebu/netxbig.c                      | 191 ----------------

Quoted 17 lines

 drivers/leds/leds-netxbig.c                        | 244 +++++++++++++++++++--
 include/dt-bindings/leds/leds-netxbig.h            |  18 ++
 11 files changed, 493 insertions(+), 245 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/gpio/netxbig-gpio-ext.txt
 create mode 100644 Documentation/devicetree/bindings/leds/leds-netxbig.txt
 delete mode 100644 arch/arm/mach-mvebu/board.h
 delete mode 100644 arch/arm/mach-mvebu/netxbig.c
 create mode 100644 include/dt-bindings/leds/leds-netxbig.h

Signature · 7 lines

2.1.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150309/49836f37/attachment.sig>

Gregory CLEMENT

2015-03-16 16:01 UTC #5 lore raw

cover Add DT support for netxbig LEDs

Hi all,

Quoted 8 lines · Simon Guinot

Quoted 7 lines · Simon Guinot
Hello,
This patch series adds DT support for the LEDs found on the Kirkwood-based LaCie boards 2Big and 5Big Network v2.
Simon

Quoted 8 lines

Quoted 4 lines
Simon Guinot (3):
leds: netxbig: add device tree binding
ARM: Kirkwood: add LED DT entries for netxbig boards
ARM: mvebu: remove static LED setup for netxbig boards
Hi Brian,
Please, consider merging the first patch of this serie.

Brian,

here again let me know when this patch will be merged, and I will also need a stable tag as patch 2 depends on this one.

Andrew, Jason,

patch 2 and 3 looks OK for me. What is your opinion about it?

Thanks,

Gregory

Quoted 38 lines

Thanks in advance.

Simon

Quoted 33 lines

 .../devicetree/bindings/gpio/netxbig-gpio-ext.txt  |  22 ++
 .../devicetree/bindings/leds/leds-netxbig.txt      |  90 ++++++++
 arch/arm/boot/dts/kirkwood-net5big.dts             |  60 +++++
 arch/arm/boot/dts/kirkwood-netxbig.dtsi            |  80 +++++++
 arch/arm/mach-mvebu/Kconfig                        |   7 -
 arch/arm/mach-mvebu/Makefile                       |   1 -
 arch/arm/mach-mvebu/board.h                        |  21 --
 arch/arm/mach-mvebu/kirkwood.c                     |   4 -
 arch/arm/mach-mvebu/netxbig.c                      | 191 ----------------
 drivers/leds/leds-netxbig.c                        | 244 +++++++++++++++++++--
 include/dt-bindings/leds/leds-netxbig.h            |  18 ++
 11 files changed, 493 insertions(+), 245 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/gpio/netxbig-gpio-ext.txt
 create mode 100644 Documentation/devicetree/bindings/leds/leds-netxbig.txt
 delete mode 100644 arch/arm/mach-mvebu/board.h
 delete mode 100644 arch/arm/mach-mvebu/netxbig.c
 create mode 100644 include/dt-bindings/leds/leds-netxbig.h

Signature · 13 lines

2.1.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Signature · 4 lines

Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

Simon Guinot

author

2015-03-30 08:30 UTC #6 lore raw

cover Add DT support for netxbig LEDs

Quoted 20 lines · Gregory CLEMENT

Hi all,
Quoted 8 lines · Simon Guinot
Quoted 7 lines · Simon Guinot
Hello,
This patch series adds DT support for the LEDs found on the Kirkwood-based LaCie boards 2Big and 5Big Network v2.
Simon
Quoted 8 lines
Quoted 4 lines
Simon Guinot (3):
leds: netxbig: add device tree binding
ARM: Kirkwood: add LED DT entries for netxbig boards
ARM: mvebu: remove static LED setup for netxbig boards
Hi Brian,
Please, consider merging the first patch of this serie.

Quoted 8 lines

Brian,
here again let me know when this patch will be merged, and I will also need a stable tag as patch 2 depends on this one.
Andrew, Jason,
patch 2 and 3 looks OK for me. What is your opinion about it?

Hi Gregory, Andrew and Jason,

This patch set seems stuck. I believe that Bryan is probably too busy to handle it...

Is that possible to merge it via the mvebu tree ? Since only some LaCie boards are impacted, I think it could make sense.

Thanks,

Simon

Quoted 29 lines

 .../devicetree/bindings/gpio/netxbig-gpio-ext.txt  |  22 ++
 .../devicetree/bindings/leds/leds-netxbig.txt      |  90 ++++++++
 arch/arm/boot/dts/kirkwood-net5big.dts             |  60 +++++
 arch/arm/boot/dts/kirkwood-netxbig.dtsi            |  80 +++++++
 arch/arm/mach-mvebu/Kconfig                        |   7 -
 arch/arm/mach-mvebu/Makefile                       |   1 -
 arch/arm/mach-mvebu/board.h                        |  21 --
 arch/arm/mach-mvebu/kirkwood.c                     |   4 -
 arch/arm/mach-mvebu/netxbig.c                      | 191 ----------------
 drivers/leds/leds-netxbig.c                        | 244 +++++++++++++++++++--
 include/dt-bindings/leds/leds-netxbig.h            |  18 ++
 11 files changed, 493 insertions(+), 245 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/gpio/netxbig-gpio-ext.txt
 create mode 100644 Documentation/devicetree/bindings/leds/leds-netxbig.txt
 delete mode 100644 arch/arm/mach-mvebu/board.h
 delete mode 100644 arch/arm/mach-mvebu/netxbig.c
 create mode 100644 include/dt-bindings/leds/leds-netxbig.h

Signature · 7 lines

2.1.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Quoted 16 lines

Quoted 4 lines
Quoted 4 lines
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Signature · 9 lines
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Andrew Lunn

maintainer

2015-03-30 12:30 UTC #7 lore raw

cover Add DT support for netxbig LEDs

Quoted 30 lines · Simon Guinot

Quoted 20 lines · Gregory CLEMENT
Hi all,
Quoted 8 lines · Simon Guinot
Quoted 7 lines · Simon Guinot
Hello,
This patch series adds DT support for the LEDs found on the Kirkwood-based LaCie boards 2Big and 5Big Network v2.
Simon
Quoted 8 lines
Quoted 4 lines
Simon Guinot (3):
leds: netxbig: add device tree binding
ARM: Kirkwood: add LED DT entries for netxbig boards
ARM: mvebu: remove static LED setup for netxbig boards
Hi Brian,
Please, consider merging the first patch of this serie.
Quoted 8 lines
Brian,
here again let me know when this patch will be merged, and I will also need a stable tag as patch 2 depends on this one.
Andrew, Jason,
patch 2 and 3 looks OK for me. What is your opinion about it?

Quoted 7 lines

Hi Gregory, Andrew and Jason,
This patch set seems stuck. I believe that Bryan is probably too busy to handle it...
Is that possible to merge it via the mvebu tree ? Since only some LaCie boards are impacted, I think it could make sense.

Hi Simon

Hard one. I also have a driver stuck in led limbo.

Last time we took a fix via mvebu, it all went messy at the last minute. We made it very clear to Bryon we planned to take a patch via mvebu, we had queued it via mvebu, we had sent a pull request to arm-soc, all with no reply from Bryon. Only at the last minute did he jump in, pull it himself and send it to Linus. That caused Olof all sorts of problems with his tree.

To stop that happening again, i think we need an Acked-by from Bryan.

Andrew

Jason Cooper

2015-03-30 13:22 UTC #8 lore raw

cover Add DT support for netxbig LEDs

Quoted 41 lines · Andrew Lunn

Quoted 30 lines · Simon Guinot
Quoted 20 lines · Gregory CLEMENT
Hi all,
Quoted 8 lines · Simon Guinot
Quoted 7 lines · Simon Guinot
Hello,
This patch series adds DT support for the LEDs found on the Kirkwood-based LaCie boards 2Big and 5Big Network v2.
Simon
Quoted 8 lines
Quoted 4 lines
Simon Guinot (3):
leds: netxbig: add device tree binding
ARM: Kirkwood: add LED DT entries for netxbig boards
ARM: mvebu: remove static LED setup for netxbig boards
Hi Brian,
Please, consider merging the first patch of this serie.
Quoted 8 lines
Brian,
here again let me know when this patch will be merged, and I will also need a stable tag as patch 2 depends on this one.
Andrew, Jason,
patch 2 and 3 looks OK for me. What is your opinion about it?
Quoted 7 lines
Hi Gregory, Andrew and Jason,
This patch set seems stuck. I believe that Bryan is probably too busy to handle it...
Is that possible to merge it via the mvebu tree ? Since only some LaCie boards are impacted, I think it could make sense.
Hi Simon

Quoted 8 lines

Hard one. I also have a driver stuck in led limbo.
Last time we took a fix via mvebu, it all went messy at the last minute. We made it very clear to Bryon we planned to take a patch via mvebu, we had queued it via mvebu, we had sent a pull request to arm-soc, all with no reply from Bryon. Only at the last minute did he jump in, pull it himself and send it to Linus. That caused Olof all sorts of problems with his tree.

It's also good to keep in mind the workflow of driver maintainers who push directly to Linus. They send PRs during the merge window, and don't necessarily spend too much time in -next. Which means, if they have good filters running on lkml, they just sit down a week or so before the merge window and apply everything they have pending.

For those of us who are feeding arm-soc, and are accustomed to getting things in early, this can be nerve-wracking.

Brian has demonstrated that he does pick things up and get them merged. We just need to make sure that what he picks up is well tested and reviewed when he gets to it. Since there won't be time for another revision before the merge window. But hey, that's what -rc's are for. :-P

Quoted 1 line

To stop that happening again, i think we need an Acked-by from Bryan.

I agree.

thx,

Jason.

Gregory CLEMENT

2015-03-30 13:29 UTC #9 lore raw

cover Add DT support for netxbig LEDs

Hi Simon,
[...]

Quoted 25 lines

Quoted 10 lines
Quoted 7 lines
Hi Gregory, Andrew and Jason,
This patch set seems stuck. I believe that Bryan is probably too busy to handle it...
Is that possible to merge it via the mvebu tree ? Since only some LaCie boards are impacted, I think it could make sense.
Hi Simon
Quoted 8 lines
Hard one. I also have a driver stuck in led limbo.
Last time we took a fix via mvebu, it all went messy at the last minute. We made it very clear to Bryon we planned to take a patch via mvebu, we had queued it via mvebu, we had sent a pull request to arm-soc, all with no reply from Bryon. Only at the last minute did he jump in, pull it himself and send it to Linus. That caused Olof all sorts of problems with his tree.
It's also good to keep in mind the workflow of driver maintainers who push directly to Linus. They send PRs during the merge window, and don't necessarily spend too much time in -next. Which means, if they have good filters running on lkml, they just sit down a week or so before the merge window and apply everything they have pending.

Quoted 8 lines

For those of us who are feeding arm-soc, and are accustomed to getting things in early, this can be nerve-wracking.
Brian has demonstrated that he does pick things up and get them merged. We just need to make sure that what he picks up is well tested and reviewed when he gets to it. Since there won't be time for another revision before the merge window. But hey, that's what -rc's are for. :-P

At least what I can do is creating a led branch and merged it in the mvebu/for-next branch. It will allow us to be more confident for the merge window.

Thanks,

Gregory

Quoted 13 lines

Quoted 1 line
To stop that happening again, i think we need an Acked-by from Bryan.
I agree.
thx,
Jason.

Signature · 4 lines

Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

Jason Cooper

2015-03-30 13:46 UTC #10 lore raw

cover Add DT support for netxbig LEDs

Quoted 31 lines · Gregory CLEMENT

Hi Simon,
[...]
Quoted 28 lines
Quoted 10 lines
Quoted 7 lines
Hi Gregory, Andrew and Jason,
This patch set seems stuck. I believe that Bryan is probably too busy to handle it...
Is that possible to merge it via the mvebu tree ? Since only some LaCie boards are impacted, I think it could make sense.
Hi Simon
Quoted 8 lines
Hard one. I also have a driver stuck in led limbo.
Last time we took a fix via mvebu, it all went messy at the last minute. We made it very clear to Bryon we planned to take a patch via mvebu, we had queued it via mvebu, we had sent a pull request to arm-soc, all with no reply from Bryon. Only at the last minute did he jump in, pull it himself and send it to Linus. That caused Olof all sorts of problems with his tree.
It's also good to keep in mind the workflow of driver maintainers who push directly to Linus. They send PRs during the merge window, and don't necessarily spend too much time in -next. Which means, if they have good filters running on lkml, they just sit down a week or so before the merge window and apply everything they have pending.
For those of us who are feeding arm-soc, and are accustomed to getting things in early, this can be nerve-wracking.

Quoted 8 lines

Quoted 5 lines
Brian has demonstrated that he does pick things up and get them merged. We just need to make sure that what he picks up is well tested and reviewed when he gets to it. Since there won't be time for another revision before the merge window. But hey, that's what -rc's are for. :-P
At least what I can do is creating a led branch and merged it in the mvebu/for-next branch. It will allow us to be more confident for the merge window.

How would we know when to remove it? We have no reliable communication with Brian.

thx,

Jason.

Gregory CLEMENT

2015-03-30 14:20 UTC #11 lore raw

cover Add DT support for netxbig LEDs

Quoted 38 lines · Jason Cooper

Quoted 37 lines · Gregory CLEMENT
Hi Simon,
[...]
Quoted 33 lines
Quoted 10 lines
Quoted 7 lines
Hi Gregory, Andrew and Jason,
This patch set seems stuck. I believe that Bryan is probably too busy to handle it...
Is that possible to merge it via the mvebu tree ? Since only some LaCie boards are impacted, I think it could make sense.
Hi Simon
Quoted 8 lines
Hard one. I also have a driver stuck in led limbo.
Last time we took a fix via mvebu, it all went messy at the last minute. We made it very clear to Bryon we planned to take a patch via mvebu, we had queued it via mvebu, we had sent a pull request to arm-soc, all with no reply from Bryon. Only at the last minute did he jump in, pull it himself and send it to Linus. That caused Olof all sorts of problems with his tree.
It's also good to keep in mind the workflow of driver maintainers who push directly to Linus. They send PRs during the merge window, and don't necessarily spend too much time in -next. Which means, if they have good filters running on lkml, they just sit down a week or so before the merge window and apply everything they have pending.
For those of us who are feeding arm-soc, and are accustomed to getting things in early, this can be nerve-wracking.
Brian has demonstrated that he does pick things up and get them merged. We just need to make sure that what he picks up is well tested and reviewed when he gets to it. Since there won't be time for another revision before the merge window. But hey, that's what -rc's are for. :-P

Quoted 4 lines

Quoted 2 lines
At least what I can do is creating a led branch and merged it in the mvebu/for-next branch. It will allow us to be more confident for the merge window.
How would we know when to remove it? We have no reliable communication with Brian.

We will remove it when we will received an acked-by from him.

The purpose of it was to be able to do a pull request as soon as we know that either Bryan will take it or let us take the full series.

In the mean time if Bryan also applied the patch in is leds/for-next branch it should not be a problem as the patch will be the same.

Thanks,

Gregory

Quoted 5 lines

thx,
Jason.

Signature · 4 lines

Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

Simon Guinot

author

2015-03-23 10:31 UTC #12 lore raw

cover Add DT support for netxbig LEDs

In reply to Simon Guinot

Quoted 8 lines · Simon Guinot

Quoted 7 lines · Simon Guinot
Hello,
This patch series adds DT support for the LEDs found on the Kirkwood-based LaCie boards 2Big and 5Big Network v2.
Simon

Quoted 8 lines

Quoted 4 lines
Simon Guinot (3):
leds: netxbig: add device tree binding
ARM: Kirkwood: add LED DT entries for netxbig boards
ARM: mvebu: remove static LED setup for netxbig boards
Hi Brian,
Please, consider merging the first patch of this serie.

Hi Brian,

It would be nice to have this patches for the incoming release. Please, consider picking them.

Thanks,

Simon

Quoted 30 lines

Quoted 10 lines

 .../devicetree/bindings/gpio/netxbig-gpio-ext.txt  |  22 ++
 .../devicetree/bindings/leds/leds-netxbig.txt      |  90 ++++++++
 arch/arm/boot/dts/kirkwood-net5big.dts             |  60 +++++
 arch/arm/boot/dts/kirkwood-netxbig.dtsi            |  80 +++++++
 arch/arm/mach-mvebu/Kconfig                        |   7 -
 arch/arm/mach-mvebu/Makefile                       |   1 -
 arch/arm/mach-mvebu/board.h                        |  21 --
 arch/arm/mach-mvebu/kirkwood.c                     |   4 -
 arch/arm/mach-mvebu/netxbig.c                      | 191 ----------------

Quoted 17 lines

 drivers/leds/leds-netxbig.c                        | 244 +++++++++++++++++++--
 include/dt-bindings/leds/leds-netxbig.h            |  18 ++
 11 files changed, 493 insertions(+), 245 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/gpio/netxbig-gpio-ext.txt
 create mode 100644 Documentation/devicetree/bindings/leds/leds-netxbig.txt
 delete mode 100644 arch/arm/mach-mvebu/board.h
 delete mode 100644 arch/arm/mach-mvebu/netxbig.c
 create mode 100644 include/dt-bindings/leds/leds-netxbig.h

Signature · 7 lines

2.1.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Quoted 4 lines

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel