input: tsc2007: Convert msecs to jiffies only once
Subsystems (2)
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/2 input: tsc2007: Convert msecs to jiffies only once
Eliminate redundant calculations by performing millisecond to jiffy calculations once during driver initialization.
Signed-off-by Aaron Sierra <[email protected]>
--- drivers/input/touchscreen/tsc2007.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
drivers/input/touchscreen/tsc2007.c +6 -5
@@ -214,8 +214,7 @@ static irqreturn_t tsc2007_soft_irq(int irq, void *handle)dev_dbg (&ts->client->dev,"ignored pressure %d\n" , rt); } -wait_event_timeout (ts->wait, ts->stopped, -msecs_to_jiffies (ts->poll_period)); +wait_event_timeout (ts->wait, ts->stopped, ts->poll_period); }dev_dbg (&ts->client->dev,"UP\n" );
@@ -314,9 +313,9 @@ static int tsc2007_probe_dt(struct i2c_client *client, struct tsc2007 *ts) ts->fuzzz = val32;if (!of_property_read_u64 (np,"ti,poll-period" , &val64)) - ts->poll_period = val64; + ts->poll_period =msecs_to_jiffies (val64);else - ts->poll_period =1 ; + ts->poll_period =msecs_to_jiffies (1 );if (!of_property_read_u32 (np,"ti,x-plate-ohms" , &val32)) { ts->x_plate_ohms = val32;
@@ -350,7 +349,9 @@ static int tsc2007_probe_pdev(struct i2c_client *client, struct tsc2007 *ts, ts->model = pdata->model; ts->x_plate_ohms = pdata->x_plate_ohms; ts->max_rt = pdata->max_rt ? :MAX_12BIT ; - ts->poll_period = pdata->poll_period ? :1 ; + ts->poll_period = pdata->poll_period ? +msecs_to_jiffies (pdata->poll_period) : +msecs_to_jiffies (1 ); ts->get_pendown_state = pdata->get_pendown_state; ts->clear_penirq = pdata->clear_penirq; ts->fuzzx = pdata->fuzzx;
Signature · 1 line
1.9.1
Quoted 4 lines · Aaron Sierra
Eliminate redundant calculations by performing millisecond to jiffy calculations once during driver initialization.
Signed-off-by Aaron Sierra <[email protected]>
Applied, thank you.
Quoted 43 lines
--- drivers/input/touchscreen/tsc2007.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)drivers/input/touchscreen/tsc2007.c +6
-5@@ -214,8 +214,7 @@ static irqreturn_t tsc2007_soft_irq(int irq, void *handle)dev_dbg (&ts->client->dev,"ignored pressure %d\n" , rt); } -wait_event_timeout (ts->wait, ts->stopped, -msecs_to_jiffies (ts->poll_period)); +wait_event_timeout (ts->wait, ts->stopped, ts->poll_period); }dev_dbg (&ts->client->dev,"UP\n" );@@ -314,9 +313,9 @@ static int tsc2007_probe_dt(struct i2c_client *client, struct tsc2007 *ts) ts->fuzzz = val32;if (!of_property_read_u64 (np,"ti,poll-period" , &val64)) - ts->poll_period = val64; + ts->poll_period =msecs_to_jiffies (val64);else - ts->poll_period =1 ; + ts->poll_period =msecs_to_jiffies (1 );if (!of_property_read_u32 (np,"ti,x-plate-ohms" , &val32)) { ts->x_plate_ohms = val32;@@ -350,7 +349,9 @@ static int tsc2007_probe_pdev(struct i2c_client *client, struct tsc2007 *ts, ts->model = pdata->model; ts->x_plate_ohms = pdata->x_plate_ohms; ts->max_rt = pdata->max_rt ? :MAX_12BIT ; - ts->poll_period = pdata->poll_period ? :1 ; + ts->poll_period = pdata->poll_period ? +msecs_to_jiffies (pdata->poll_period) : +msecs_to_jiffies (1 ); ts->get_pendown_state = pdata->get_pendown_state; ts->clear_penirq = pdata->clear_penirq; ts->fuzzx = pdata->fuzzx;Signature · 1 line
1.9.1
Signature · 1 line
Dmitry