Skip to contentSkip to conversation

Staging: rtl8192u Make function static

PATCH In review Eddie Kovsky 2 participants 3 messages Mar 31, 2015 – Apr 1, 2015 Staging

lore
Share & tools
lore

Eddie Kovsky

author
#0 lore raw

PATCH 1/1 Staging: rtl8192u Make function static

Changing function definition to static fixes the
following warning generated by sparse:

drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:1924:6: warning: symbol 'ieee80211_check_auth_response' was not declared. Should it be static?

Signed-off-by Eddie Kovsky <[email protected]>
---
 drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c +1 -1
index 66b158714822..072d8204b01c 100644
@@ -1921,7 +1921,7 @@ static void ieee80211_process_action(struct ieee80211_device *ieee,
 
 }
 
-void ieee80211_check_auth_response(struct ieee80211_device *ieee,
+static void ieee80211_check_auth_response(struct ieee80211_device *ieee,
 				   struct sk_buff *skb)
 {
 	/* default support N mode, disable halfNmode */
Signature · 1 line
2.3.4
#1 lore raw
Quoted 4 lines · Eddie Kovsky

Changing function definition to static fixes the
following warning generated by sparse:

drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:1924:6: warning: symbol 'ieee80211_check_auth_response' was not declared. Should it be static?

some one has already done this and it has been already applied to staging-testing.

regards
sudip

Quoted 1 line
author
#2 lore raw
Quoted 4 lines · Sudip Mukherjee
Quoted 3 lines · Eddie Kovsky

Changing function definition to static fixes the
following warning generated by sparse:

Quoted 8 lines
Quoted 1 line

drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:1924:6: warning: symbol 'ieee80211_check_auth_response' was not declared. Should it be static?

some one has already done this and it has been already applied to staging-testing.

regards
sudip

Yes, I see that now. I thought I was already tracking that branch.

I'm sorry for the noise.

Eddie