Skip to contentSkip to conversation

drm/i915: Allow legacy interface for legacy Y tiled display

PATCH In review Tvrtko Ursulin 5 participants 5 messages Apr 1, 2015 – Apr 2, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: Allow legacy interface for legacy Y tiled display

From: Tvrtko Ursulin <[email protected]>

Makes it easier for userspace to start supporting Y tiled display, for at least the legacy format.

Cc Chris Wilson <[email protected]>
Cc Daniel Vetter <[email protected]>
---
 drivers/gpu/drm/i915/intel_display.c | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/intel_display.c +12 -3
index 1813190..de50631 100644
@@ -13347,10 +13347,19 @@ static int intel_framebuffer_init(struct drm_device *dev,
 			return -EINVAL;
 		}
 	} else {
-		if (obj->tiling_mode == I915_TILING_X)
+		switch (obj->tiling_mode) {
+		case I915_TILING_NONE:
+			mode_cmd->modifier[0] = DRM_FORMAT_MOD_NONE;
+			break;
+		case I915_TILING_X:
 			mode_cmd->modifier[0] = I915_FORMAT_MOD_X_TILED;
-		else if (obj->tiling_mode == I915_TILING_Y) {
-			DRM_DEBUG("No Y tiling for legacy addfb\n");
+			break;
+		case I915_TILING_Y:
+			mode_cmd->modifier[0] = I915_FORMAT_MOD_Y_TILED;
+			break;
+		default:
+			DRM_DEBUG("Unsupported fb obj tiling %u!\n",
+				  obj->tiling_mode);
 			return -EINVAL;
 		}
 	}
Signature · 6 lines
2.3.2

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw
Quoted 8 lines · Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

Makes it easier for userspace to start supporting Y tiled display, for at least the legacy format.

Cc Chris Wilson <[email protected]>
Cc Daniel Vetter <[email protected]>

For the record: The point here is that we'll get a user for fb modifiers by enabling Y tiling, not enabling Y tiling itself ... On that goal this patch falls short, so nacked.
-Daniel

Quoted 34 lines
---
 drivers/gpu/drm/i915/intel_display.c | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/intel_display.c +12 -3
index 1813190..de50631 100644
@@ -13347,10 +13347,19 @@ static int intel_framebuffer_init(struct drm_device *dev,
 			return -EINVAL;
 		}
 	} else {
-		if (obj->tiling_mode == I915_TILING_X)
+		switch (obj->tiling_mode) {
+		case I915_TILING_NONE:
+			mode_cmd->modifier[0] = DRM_FORMAT_MOD_NONE;
+			break;
+		case I915_TILING_X:
 			mode_cmd->modifier[0] = I915_FORMAT_MOD_X_TILED;
-		else if (obj->tiling_mode == I915_TILING_Y) {
-			DRM_DEBUG("No Y tiling for legacy addfb\n");
+			break;
+		case I915_TILING_Y:
+			mode_cmd->modifier[0] = I915_FORMAT_MOD_Y_TILED;
+			break;
+		default:
+			DRM_DEBUG("Unsupported fb obj tiling %u!\n",
+				  obj->tiling_mode);
 			return -EINVAL;
 		}
 	}
Signature · 1 line
2.3.2
Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw
Quoted 6 lines · Daniel Vetter
Quoted 5 lines · Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

Makes it easier for userspace to start supporting Y tiled display, for at least the legacy format.

Quoted 7 lines
Quoted 3 lines
Cc Chris Wilson <[email protected]>
Cc Daniel Vetter <[email protected]>

For the record: The point here is that we'll get a user for fb modifiers by enabling Y tiling, not enabling Y tiling itself ... On that goal this patch falls short, so nacked.

Seriously? There is an existing client ready to use Y tiling framebuffers. There are none prepared to use the new api. Wishing will not change the inertia inherent in userspace.
-Chris

Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#3 lore raw
Quoted 11 lines · Chris Wilson
Quoted 10 lines · Daniel Vetter
Quoted 8 lines · Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

Makes it easier for userspace to start supporting Y tiled display, for at least the legacy format.

Cc Chris Wilson <[email protected]>
Cc Daniel Vetter <[email protected]>
Quoted 7 lines
Quoted 3 lines

For the record: The point here is that we'll get a user for fb modifiers by enabling Y tiling, not enabling Y tiling itself ... On that goal this patch falls short, so nacked.

Seriously? There is an existing client ready to use Y tiling framebuffers. There are none prepared to use the new api. Wishing will not change the inertia inherent in userspace.

Yeah I'm not sure I understand the objection either... we want to use the new interface exclusively so this patch is nacked?

Jesse

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Tested-by on v1 1/1
#4 lore raw
In reply to Tvrtko Ursulin

Task id: 6113 -------------------------------------Summary-------------------------------------
Platform Delta drm-intel-nightly Series Applied

PNV                 -2              272/272              270/272
ILK                 -1              302/302              301/302
SNB                                  303/303              303/303
IVB                                  338/338              338/338
BYT                 -1              287/287              286/287
HSW                                  361/361              361/361
BDW                                  308/308              308/308
-------------------------------------Detailed-------------------------------------
Platform  Test                                drm-intel-nightly          Series Applied
 PNV  igt@gem_tiled_pread_pwrite      FAIL(3)PASS(7)      FAIL(1)PASS(1)
 PNV  igt@gem_userptr_blits@coherency-sync      CRASH(5)PASS(5)      CRASH(2)
*ILK  igt@gem_fenced_exec_thrash@no-spare-fences-busy-interruptible      PASS(2)      DMESG_WARN(1)PASS(1)

(dmesg patch applied)drm:i915_hangcheck_elapsed[i915]]*ERROR*Hangcheck_timer_elapsed...bsd_ring_idle@Hangcheck timer elapsed... bsd ring idle
*BYT igt@gem_exec_bad_domains@conflicting-write-domain PASS(8) FAIL(1)PASS(1)
Note: You need to pay more attention to line start with '*'
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx