Skip to contentSkip to conversation

bmon: fix license information

PATCH New Yegor Yefremov 2 participants 5 messages Apr 1, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 bmon: fix license information

bmon is licensed under two licenses BSD-2c and MIT.

---
 package/bmon/bmon.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/bmon/bmon.mk +2 -2
index 9a4312f..b1dc399 100644
@@ -7,8 +7,8 @@
 BMON_VERSION = 3.6
 BMON_SITE = https://github.com/tgraf/bmon/releases/download/v$(BMON_VERSION)
 BMON_DEPENDENCIES = host-pkgconf libconfuse libnl ncurses
-BMON_LICENSE = BSD-2c
-BMON_LICENSE_FILES = LICENSE
+BMON_LICENSE = BSD-2c, MIT
+BMON_LICENSE_FILES = LICENSE.BSD LICENSE.MIT
 # For 0001-build-uclinux-is-also-linux.patch
 BMON_AUTORECONF = YES
 
Signature · 1 line
2.1.0
#1 lore raw

PATCH 2/2 bmon: remove hash file for GitHub helper package

---
 package/bmon/bmon.hash | 2 --
 1 file changed, 2 deletions(-)
 delete mode 100644 package/bmon/bmon.hash
package/bmon/bmon.hash deleted +0 -2
deleted file mode 100644
index 65747b4..0000000
@@ -1,2 +0,0 @@
-# Locally calculated
-sha256  62c8c20d00572a7670891d4c112924786cb69ec4ca92d5052951566f000d1514  bmon-3.6.tar.gz
Signature · 1 line
2.1.0
#2 lore raw

PATCH 2/2 bmon: remove hash file for GitHub helper package

Dear Yegor Yefremov,

Quoted 5 lines · Yegor Yefremov
---
 package/bmon/bmon.hash | 2 --
 1 file changed, 2 deletions(-)
 delete mode 100644 package/bmon/bmon.hash

This patch is not correct. There is a subtle thing about github downloads. Quoting the Buildroot manual:

"""
If the package you wish to add does have a release section on GitHub, the maintainer may have uploaded a release tarball, or the release may just point to the automatically generated tarball from the git tag. If there is a release tarball uploaded by the maintainer, we prefer to use that since it may be slightly different (e.g. it contains a configure script so we don?t need to do AUTORECONF).

You can see on the release page if it?s an uploaded tarball or a git tag:

* If there is a green download button, like mongrel2, then it was uploaded by the maintainer and you should use the link of that button to specify FOO_SITE, and not use the github helper.

* If there is grey download button, like xbmc, then it?s an automatically generated tarball and you should use the github helper function.
"""

So if we're with a "green" button case, it is perfectly fine to have a tarball hash, because the taball is not automatically generated. And this is the case we're in for bmon:
https://github.com/tgraf/bmon/releases. There is a green button. And the BMON_SITE variable does not use the github helper.

So I marked this patch as rejected.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#3 lore raw

PATCH 2/2 bmon: remove hash file for GitHub helper package

Quoted 32 lines · Thomas Petazzoni

Dear Yegor Yefremov,

Quoted 5 lines · Yegor Yefremov
---
 package/bmon/bmon.hash | 2 --
 1 file changed, 2 deletions(-)
 delete mode 100644 package/bmon/bmon.hash

This patch is not correct. There is a subtle thing about github downloads. Quoting the Buildroot manual:

"""
If the package you wish to add does have a release section on GitHub, the maintainer may have uploaded a release tarball, or the release may just point to the automatically generated tarball from the git tag. If there is a release tarball uploaded by the maintainer, we prefer to use that since it may be slightly different (e.g. it contains a configure script so we don?t need to do AUTORECONF).

You can see on the release page if it?s an uploaded tarball or a git tag:

* If there is a green download button, like mongrel2, then it was uploaded by the maintainer and you should use the link of that button to specify FOO_SITE, and not use the github helper.

* If there is grey download button, like xbmc, then it?s an automatically generated tarball and you should use the github helper function.
"""

Quoted 7 lines

So if we're with a "green" button case, it is perfectly fine to have a tarball hash, because the taball is not automatically generated. And this is the case we're in for bmon:
https://github.com/tgraf/bmon/releases. There is a green button. And the BMON_SITE variable does not use the github helper.

So I marked this patch as rejected.

OK. I see.

Yegor

#4 lore raw

PATCH 1/2 bmon: fix license information

In reply to Yegor Yefremov

Dear Yegor Yefremov,

Quoted 6 lines · Yegor Yefremov

bmon is licensed under two licenses BSD-2c and MIT.

---
 package/bmon/bmon.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com