Skip to contentSkip to conversation

usb: gadget: f_fs: O_NONBLOCK waits MAX_SCHEDULE_TIMEOUT

DISCUSSION Baxter, Jim 4 participants 9 messages Mar 31, 2015 – Jun 2, 2015

lore
Share & tools
lore
#0 lore raw

Hi,

I have been looking at an issue where a phone that is the Function FS host sometimes locks up and causes the function:
static ssize_t ffs_epfile_io(struct file *file, struct ffs_io_data *io_data) in drivers/usb/gadget/function/f_fs.c to timeout after MAX_SCHEDULE_TIMEOUT jiffies.

We are opening the ffs connection with the O_NONBLOCK option and this timeout seems to be far too long.

The code causing the wait is here (line 834):

if (unlikely(ret < 0)) {
    /* nop */
} else if (unlikely(
        wait_for_completion_interruptible(&done))) {
    ret = -EINTR;
    usb_ep_dequeue(ep->ep, req);
} else {

The function call wait_for_completion_interruptible(&done) equates to:
wait_for_completion_interruptible_timeout(&done, MAX_SCHEDULE_TIMEOUT);

I was wondering what to change to fix this, is it reasonable to use a very small timeout if it is O_NONBLOCK or is any blocking not allowed?

I would appreciate any thoughts on how this should work?

Thank you,
Jim

#1 lore raw

Hi,

(it helps if you Cc the maintainer too :-)

Quoted 2 lines · Jim

I have been looking at an issue where a phone that is the Function FS host sometimes locks up and causes the function:

which USB controller ? which kernel ? which platform ?

Quoted 3 lines

static ssize_t ffs_epfile_io(struct file *file, struct ffs_io_data *io_data) in drivers/usb/gadget/function/f_fs.c to timeout after MAX_SCHEDULE_TIMEOUT jiffies.

yeah, that's pretty much "never timeout" :-)

Quoted 2 lines

We are opening the ffs connection with the O_NONBLOCK option and this timeout seems to be far too long.

is this your own application ? How can I make sure it's correct ?

Quoted 6 lines

The code causing the wait is here (line 834):

if (unlikely(ret < 0)) {
    /* nop */
} else if (unlikely(
        wait_for_completion_interruptible(&done))) {

right, this is waiting for the previous usb_ep_queue() to complete. Why hasn't it completed yet ? Do you have a USB sniffer to check if data has passed over the wire ? Did the host shifted any token in the wire trying to move data around ?

Quoted 4 lines
    ret = -EINTR;
    usb_ep_dequeue(ep->ep, req);
} else {
Quoted 8 lines

The function call wait_for_completion_interruptible(&done) equates to:
wait_for_completion_interruptible_timeout(&done, MAX_SCHEDULE_TIMEOUT);

I was wondering what to change to fix this, is it reasonable to use a very small timeout if it is O_NONBLOCK or is any blocking not allowed?

I would appreciate any thoughts on how this should work?

sounds like a bug on your USB peripheral controller driver. Which one is that ? Again, which kernel ? Where are the logs ?

regards

Signature · 1 line
balbi
#2 lore raw
In reply to Baxter, Jim

Hi,

Quoted 21 lines · Jim

Hi,

I have been looking at an issue where a phone that is the Function FS host sometimes locks up and causes the function:
static ssize_t ffs_epfile_io(struct file *file, struct ffs_io_data *io_data) in drivers/usb/gadget/function/f_fs.c to timeout after MAX_SCHEDULE_TIMEOUT jiffies.

We are opening the ffs connection with the O_NONBLOCK option and this timeout seems to be far too long.

The code causing the wait is here (line 834):

if (unlikely(ret < 0)) {
    /* nop */
} else if (unlikely(
        wait_for_completion_interruptible(&done))) {
    ret = -EINTR;
    usb_ep_dequeue(ep->ep, req);
} else {
Quoted 8 lines

The function call wait_for_completion_interruptible(&done) equates to:
wait_for_completion_interruptible_timeout(&done, MAX_SCHEDULE_TIMEOUT);

I was wondering what to change to fix this, is it reasonable to use a very small timeout if it is O_NONBLOCK or is any blocking not allowed?

I would appreciate any thoughts on how this should work?

FunctionFS is very specific, because read/write operations are directly translated into USB requests, which are asynchronous, so you cannot use O_NONBLOCK.

If you need non-blocking API you can use Asynchronous I/O (AIO). You can find some examples in kernel sources (tools/usb/ffs-aio-example/).

Br,
Robert Baldyga

#3 lore raw
Quoted 11 lines

FunctionFS is very specific, because read/write operations are directly translated into USB requests, which are asynchronous, so you cannot use O_NONBLOCK.

If you need non-blocking API you can use Asynchronous I/O (AIO). You can find some examples in kernel sources (tools/usb/ffs-aio-example/).

Br,
Robert Baldyga

Thank you, that sounds like the best approach.
In this case I think perhaps the long wait without any data is an problem with the imx6 Chipidea USB controller.

I guess it should suspend and drop the connections if there is no traffic for more than 10ms?

Thanks.
Jim Baxter

#4 lore raw
Quoted 8 lines · Jim
Quoted 8 lines

FunctionFS is very specific, because read/write operations are directly translated into USB requests, which are asynchronous, so you cannot use O_NONBLOCK.

If you need non-blocking API you can use Asynchronous I/O (AIO). You can find some examples in kernel sources (tools/usb/ffs-aio-example/).

Quoted 7 lines
Quoted 3 lines

Br,
Robert Baldyga

Thank you, that sounds like the best approach.
In this case I think perhaps the long wait without any data is an problem with the imx6 Chipidea USB controller.

What's the possible problem?

Quoted 4 lines

I guess it should suspend and drop the connections if there is no traffic for more than 10ms?

If the Device side NAK host's IN/OUT token continually, the pipe will not be stopped, the host will send token continually until the application cancel this request.

Signature · 2 lines
Best Regards,
Peter Chen
#5 lore raw
Quoted 14 lines · Jim
Quoted 12 lines
Quoted 11 lines

FunctionFS is very specific, because read/write operations are directly translated into USB requests, which are asynchronous, so you cannot use O_NONBLOCK.

If you need non-blocking API you can use Asynchronous I/O (AIO). You can find some examples in kernel sources (tools/usb/ffs-aio-example/).

Br,
Robert Baldyga

Quoted 5 lines
Quoted 3 lines

Thank you, that sounds like the best approach.
In this case I think perhaps the long wait without any data is an problem with the imx6 Chipidea USB controller.

What's the possible problem?

Sorry for the delay in replying, I have been getting some more details with a USB Analyser.

The scenario is that the NCM device is enumerating so we see the messages to:

SetAddress (1)
GetDescriptor (Device)
GetDescriptor (StringN)
GetDescriptor (Configuration)
SetConfiguration (1)
GetDescriptor (String iInterface)
GetDescriptor (String iInterface)

At this point the NCM host sends Writes to the F_FS EP0 but for some reason the host device does not respond and only issues SOF packets for hours. This happens occasionally and is fixed by turning the device off and on again.

Unless I am mistaken from a NCM gadget point of view the attached device is working correctly and there is no way to know it has failed, is that correct?

Quoted 10 lines
Quoted 5 lines

I guess it should suspend and drop the connections if there is no traffic for more than 10ms?

If the Device side NAK host's IN/OUT token continually, the pipe will not be stopped, the host will send token continually until the application cancel this request.

#6 lore raw
Quoted 32 lines
Quoted 13 lines
Quoted 13 lines
Quoted 12 lines

FunctionFS is very specific, because read/write operations are directly translated into USB requests, which are asynchronous, so you cannot use O_NONBLOCK.

If you need non-blocking API you can use Asynchronous I/O (AIO). You can find some examples in kernel sources (tools/usb/ffs-aio-example/).

Br,
Robert Baldyga

Quoted 5 lines
Quoted 3 lines

Thank you, that sounds like the best approach.
In this case I think perhaps the long wait without any data is an problem with the imx6 Chipidea USB controller.

What's the possible problem?

Sorry for the delay in replying, I have been getting some more details with a USB Analyser.

The scenario is that the NCM device is enumerating so we see the messages to:

SetAddress (1)
GetDescriptor (Device)
GetDescriptor (StringN)
GetDescriptor (Configuration)
SetConfiguration (1)
GetDescriptor (String iInterface)
GetDescriptor (String iInterface)

Quoted 5 lines

At this point the NCM host sends Writes to the F_FS EP0 but for some reason the host device does not respond and only issues SOF packets for hours. This happens occasionally and is fixed by turning the device off and on again.

We may find this 'some reason', is it device error or host error?

Do you have below patch in your code:

commit 953c66469735aed8d2ada639a72b150f01dae605

Author: Abbas Raza <[email protected]>
Date:   Thu Jul 17 19:34:31 2014 +0800

usb: chipidea: udc: Disable auto ZLP generation on ep0

There are 2 methods for ZLP (zero-length packet) generation:
1) In software
2) Automatic generation by device controller

1) is implemented in UDC driver and it attaches ZLP to IN packet if descriptor->size < wLength
2) can be enabled/disabled by setting ZLT bit in the QH

Peter

Quoted 13 lines

Unless I am mistaken from a NCM gadget point of view the attached device is working correctly and there is no way to know it has failed, is that correct?

Quoted 10 lines
Quoted 5 lines

I guess it should suspend and drop the connections if there is no traffic for more than 10ms?

If the Device side NAK host's IN/OUT token continually, the pipe will not be stopped, the host will send token continually until the application cancel this request.

#7 lore raw
Quoted 51 lines
Quoted 31 lines
Quoted 12 lines
Quoted 12 lines
Quoted 11 lines

FunctionFS is very specific, because read/write operations are directly translated into USB requests, which are asynchronous, so you cannot use O_NONBLOCK.

If you need non-blocking API you can use Asynchronous I/O (AIO). You can find some examples in kernel sources (tools/usb/ffs-aio-example/).

Br,
Robert Baldyga

Quoted 5 lines
Quoted 3 lines

Thank you, that sounds like the best approach.
In this case I think perhaps the long wait without any data is an problem with the imx6 Chipidea USB controller.

What's the possible problem?

Sorry for the delay in replying, I have been getting some more details with a USB Analyser.

The scenario is that the NCM device is enumerating so we see the messages to:

SetAddress (1)
GetDescriptor (Device)
GetDescriptor (StringN)
GetDescriptor (Configuration)
SetConfiguration (1)
GetDescriptor (String iInterface)
GetDescriptor (String iInterface)

Quoted 5 lines

At this point the NCM host sends Writes to the F_FS EP0 but for some reason the host device does not respond and only issues SOF packets for hours. This happens occasionally and is fixed by turning the device off and on again.

We may find this 'some reason', is it device error or host error?

Do you have below patch in your code:

commit 953c66469735aed8d2ada639a72b150f01dae605

Author: Abbas Raza <[email protected]>
Date:   Thu Jul 17 19:34:31 2014 +0800

usb: chipidea: udc: Disable auto ZLP generation on ep0

There are 2 methods for ZLP (zero-length packet) generation:
1) In software
2) Automatic generation by device controller

Quoted 5 lines

1) is implemented in UDC driver and it attaches ZLP to IN packet if descriptor->size < wLength
2) can be enabled/disabled by setting ZLT bit in the QH

Peter

Yes I have that patch, could that be a problem?

Jim

Quoted 14 lines
Quoted 14 lines

Unless I am mistaken from a NCM gadget point of view the attached device is working correctly and there is no way to know it has failed, is that correct?

Quoted 10 lines
Quoted 5 lines

I guess it should suspend and drop the connections if there is no traffic for more than 10ms?

If the Device side NAK host's IN/OUT token continually, the pipe will not be stopped, the host will send token continually until the application cancel this request.

#8 lore raw
Quoted 43 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines

Thank you, that sounds like the best approach.
In this case I think perhaps the long wait without any data is an problem with the imx6 Chipidea USB controller.

Quoted 6 lines
Quoted 6 lines
Quoted 1 line

What's the possible problem?

Sorry for the delay in replying, I have been getting some more details with a USB Analyser.

The scenario is that the NCM device is enumerating so we see the

messages to:

Quoted 9 lines
Quoted 9 lines

SetAddress (1)
GetDescriptor (Device)
GetDescriptor (StringN)
GetDescriptor (Configuration)
SetConfiguration (1)
GetDescriptor (String iInterface)
GetDescriptor (String iInterface)

Quoted 3 lines
Quoted 3 lines

At this point the NCM host sends Writes to the F_FS EP0 but for some reason the host device does not respond and only issues SOF packets for hours. This happens occasionally and is fixed by turning the device off

and on again.

Quoted 17 lines
Quoted 2 lines

We may find this 'some reason', is it device error or host error?

Do you have below patch in your code:

commit 953c66469735aed8d2ada639a72b150f01dae605

Author: Abbas Raza <[email protected]>
Date:   Thu Jul 17 19:34:31 2014 +0800

usb: chipidea: udc: Disable auto ZLP generation on ep0

There are 2 methods for ZLP (zero-length packet) generation:
1) In software
2) Automatic generation by device controller

Quoted 8 lines
Quoted 5 lines

1) is implemented in UDC driver and it attaches ZLP to IN packet if descriptor->size < wLength
2) can be enabled/disabled by setting ZLT bit in the QH

Peter

Yes I have that patch, could that be a problem?

No, you need that patch.
Get to know which side has problem first.

Peter

Quoted 17 lines

Jim

Quoted 3 lines
Quoted 3 lines

Unless I am mistaken from a NCM gadget point of view the attached device is working correctly and there is no way to know it has failed, is that

correct?

Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 6 lines

I guess it should suspend and drop the connections if there is no traffic for more than 10ms?

If the Device side NAK host's IN/OUT token continually, the pipe will not be stopped, the host will send token continually until the application cancel this request.