Skip to contentSkip to conversation

kernel/timer: avoid spurious ksoftirqd wakeups

DISCUSSION Hillf Danton 2 participants 2 messages Apr 2, 2015 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

kernel/time/tick-sched.c static ktime_t tick_nohz_stop_sched_tick(struct tick_sched *ts, · line 572

Quoted 8 lines
kernel/time/tick-sched.c +1 -0
@@ -568,6 +568,7 @@ static ktime_t tick_nohz_stop_sched_tick(struct tick_sched *ts,
 	unsigned long rcu_delta_jiffies;
 	struct clock_event_device *dev = __this_cpu_read(tick_cpu_device.evtdev);
 	u64 time_delta;
+	bool raise_softirq;
 

s/raise_softirq/raise_softirq = false/ ?

Quoted 2 lines
kernel/time/tick-sched.c +0 -0
 	time_delta = timekeeping_max_deferment();
 
#2 lore raw
Quoted 9 lines · Hillf Danton

kernel/time/tick-sched.c static ktime_t tick_nohz_stop_sched_tick(struct tick_sched *ts, · line 572

Quoted 8 lines
kernel/time/tick-sched.c +1 -0
@@ -568,6 +568,7 @@ static ktime_t tick_nohz_stop_sched_tick(struct tick_sched *ts,
 	unsigned long rcu_delta_jiffies;
 	struct clock_event_device *dev = __this_cpu_read(tick_cpu_device.evtdev);
 	u64 time_delta;
+	bool raise_softirq;
 

s/raise_softirq/raise_softirq = false/ ?

Not necessary, variable is initialized before being used.

Quoted 2 lines
Quoted 2 lines
kernel/time/tick-sched.c +0 -0
 	time_delta = timekeeping_max_deferment();