elfutils: Add a --{enable, disable}-backends option
PATCH v2 1/1 elfutils: Add a --{enable, disable}-backends option
Add a --{enable,disable}-backends configuration option to elfutils. This allows to selectively disable the compilation of the libebl backends shared libraries. This is usefull when some application require linking against the elfutils libelf, but don't require the backends to be available on target.
Signed-off-by Jan Heylen <[email protected]>
---
Changes v1 -> v2:
- properly signed-off marking and description in patch file
- fixed typo in patch file
--- package/elfutils/0007-backends-configurable.patch | 56 +++++++++++++++++++++++ package/elfutils/Config.in | 13 ++++++ package/elfutils/elfutils.mk | 6 +++ 3 files changed, 75 insertions(+) create mode 100644 package/elfutils/0007-backends-configurable.patch
package/elfutils/0007-backends-configurable.patch new file +56 -0
@@ -0,0 +1,56 @@ +Add a --{enable,disable}-backends option + +Add a --{enable,disable}-backends configuration option to elfutils. This +allows to selectively disable the compilation of the libebl backends +shared libraries. This is usefull when some application require linking +against the elfutils libelf, but don't require the backends to be available +at runtime on target. + +Based on the disable-progs patch by Thomas Petazzoni/Vicente Olivert Riera. + +Signed-off-by: Jan Heylen <[email protected]> + +Index: elfutils-0.161/Makefile.am +=================================================================== +--- elfutils-0.161.orig/Makefile.am 2015-04-01 19:56:35.090112704 +0200 ++++ elfutils-0.161/Makefile.am 2015-04-01 19:59:19.688605184 +0200 +@@ -22,13 +22,18 @@ + + pkginclude_HEADERS = version.h + ++# Add doc back when we have some real content. ++SUBDIRS = config m4 lib libelf libebl libdwelf libdwfl libdw libcpu libasm ++ ++if ENABLE_BACKENDS ++ SUBDIRS += backends ++endif ++ + if ENABLE_PROGS +-PROGS_SUBDIR = src ++ SUBDIRS += src + endif + +-# Add doc back when we have some real content. +-SUBDIRS = config m4 lib libelf libebl libdwelf libdwfl libdw libcpu libasm \ +- backends $(PROGS_SUBDIR) tests ++SUBDIRS += tests + + EXTRA_DIST = elfutils.spec GPG-KEY NOTES CONTRIBUTING \ + COPYING COPYING-GPLV2 COPYING-LGPLV3 +Index: elfutils-0.161/configure.ac +=================================================================== +--- elfutils-0.161.orig/configure.ac 2015-04-01 19:56:35.090112704 +0200 ++++ elfutils-0.161/configure.ac 2015-04-01 19:56:35.086112308 +0200 +@@ -253,6 +253,12 @@ + AC_DEFINE_UNQUOTED(LIBEBL_SUBDIR, "$LIBEBL_SUBDIR") + AH_TEMPLATE([LIBEBL_SUBDIR], [$libdir subdirectory containing libebl modules.]) + ++AC_ARG_ENABLE([backends], ++ AS_HELP_STRING([--enable-backends], [enable backends]), ++ enable_backends=$enableval, ++ enable_backends=yes) ++AM_CONDITIONAL(ENABLE_BACKENDS, test "$enable_backends" = yes) ++ + AC_CHECK_FUNC([argp_parse]) + if test "$ac_cv_func_argp_parse" != yes; then + AC_CHECK_LIB([argp],[argp_parse],ARGP_LIBS=-largp,
package/elfutils/Config.in +13 -0
@@ -30,4 +30,17 @@ config BR2_PACKAGE_ELFUTILS_PROGS This option tells elfutils to not only install the libelf libraries, but also the elfutils programs. +config BR2_PACKAGE_ELFUTILS_BACKENDS + bool "Build and install backend shared libraries" + default y + help + This option tells elfutils to not only install the libelf + libraries, but also the libebl backend shared libraries + with architecture specific code to read elf files. If you + intend to use libelf/libebl at-runtime, say 'y' here. + If you only need to link against libelf at-compile-time, + but not really using it, you can leave the architecture + specific backends uninstalled. Loading of the backend library + by libebl will fail in that case. + endif
package/elfutils/elfutils.mk +6 -0
@@ -65,4 +65,10 @@ else ELFUTILS_CONF_OPTS += --disable-progs endif +ifeq ($(BR2_PACKAGE_ELFUTILS_BACKENDS),y) + ELFUTILS_CONF_OPTS += --enable-backends +else + ELFUTILS_CONF_OPTS += --disable-backends +endif + $(eval $(autotools-package))
Signature · 1 line
1.9.1
PATCH v2 1/1 elfutils: Add a --{enable, disable}-backends option
Jan, All,
On 2015-04-02 09:23 +0200, Jan Heylen spake thusly:
Quoted 5 lines
Add a --{enable,disable}-backends configuration option to elfutils. This allows to selectively disable the compilation of the libebl backends shared libraries. This is usefull when some application require linking against the elfutils libelf, but don't require the backends to be available on target.
Thanks for your patch! :-)
However, this is a feature patch, and we try not to have such feature patch in Buildroot (unless they've been accepted by upstream first, in which case we can back-port them).
I see you based your patch on 0002-disable-progs.patch, which one could see as being a feature patch. But it is really needed to avoid build failures when on uClibc, so the case is a bit different for 0002.
Can you please try to push your change upstream first?
In the meantime I'm setting thius patch as "postponed" in patchwork (thus actually hidding it for now), When the patch has been accepted upstream, just resend it.
See however some comment below...
Quoted 34 lines
Signed-off-by Jan Heylen <[email protected]>---
Changes v1 -> v2:
- properly signed-off marking and description in patch file
- fixed typo in patch file--- package/elfutils/0007-backends-configurable.patch | 56 +++++++++++++++++++++++ package/elfutils/Config.in | 13 ++++++ package/elfutils/elfutils.mk | 6 +++ 3 files changed, 75 insertions(+) create mode 100644 package/elfutils/0007-backends-configurable.patchpackage/elfutils/0007-backends-configurable.patch new file +15
-0@@ -0,0 +1,56 @@ +Add a --{enable,disable}-backends option + +Add a --{enable,disable}-backends configuration option to elfutils. This +allows to selectively disable the compilation of the libebl backends +shared libraries. This is usefull when some application require linking +against the elfutils libelf, but don't require the backends to be available +at runtime on target. + +Based on the disable-progs patch by Thomas Petazzoni/Vicente Olivert Riera. + +Signed-off-by: Jan Heylen <[email protected]> + +Index: elfutils-0.161/Makefile.am +=================================================================== +--- elfutils-0.161.orig/Makefile.am 2015-04-01 19:56:35.090112704 +0200
package/elfutils/0007-backends-configurable.patch line 25
Quoted 10 lines
package/elfutils/0007-backends-configurable.patch new file +10
-0++++ elfutils-0.161/Makefile.am 2015-04-01 19:59:19.688605184 +0200 +@@ -22,13 +22,18 @@ + + pkginclude_HEADERS = version.h + ++# Add doc back when we have some real content. ++SUBDIRS = config m4 lib libelf libebl libdwelf libdwfl libdw libcpu libasm ++ ++if ENABLE_BACKENDS ++ SUBDIRS += backends
Don't indent.
package/elfutils/0007-backends-configurable.patch line 30
Quoted 5 lines
package/elfutils/0007-backends-configurable.patch new file +5
-0++endif ++ + if ENABLE_PROGS +-PROGS_SUBDIR = src ++ SUBDIRS += src
Ditto, don't indent. Beside, this is only a 'formatting' change, and should not be present in that patch.
Otherwise, it looks pretty sane.
Regards,
Yann E. MORIN.
Quoted 70 lines
package/elfutils/0007-backends-configurable.patch new file +26
-0+ endif + +-# Add doc back when we have some real content. +-SUBDIRS = config m4 lib libelf libebl libdwelf libdwfl libdw libcpu libasm \ +- backends $(PROGS_SUBDIR) tests ++SUBDIRS += tests + + EXTRA_DIST = elfutils.spec GPG-KEY NOTES CONTRIBUTING \ + COPYING COPYING-GPLV2 COPYING-LGPLV3 +Index: elfutils-0.161/configure.ac +=================================================================== +--- elfutils-0.161.orig/configure.ac 2015-04-01 19:56:35.090112704 +0200 ++++ elfutils-0.161/configure.ac 2015-04-01 19:56:35.086112308 +0200 +@@ -253,6 +253,12 @@ + AC_DEFINE_UNQUOTED(LIBEBL_SUBDIR, "$LIBEBL_SUBDIR") + AH_TEMPLATE([LIBEBL_SUBDIR], [$libdir subdirectory containing libebl modules.]) + ++AC_ARG_ENABLE([backends], ++ AS_HELP_STRING([--enable-backends], [enable backends]), ++ enable_backends=$enableval, ++ enable_backends=yes) ++AM_CONDITIONAL(ENABLE_BACKENDS, test "$enable_backends" = yes) ++ + AC_CHECK_FUNC([argp_parse]) + if test "$ac_cv_func_argp_parse" != yes; then + AC_CHECK_LIB([argp],[argp_parse],ARGP_LIBS=-largp,package/elfutils/Config.in +13
-0@@ -30,4 +30,17 @@ config BR2_PACKAGE_ELFUTILS_PROGS This option tells elfutils to not only install the libelf libraries, but also the elfutils programs. +config BR2_PACKAGE_ELFUTILS_BACKENDS + bool "Build and install backend shared libraries" + default y + help + This option tells elfutils to not only install the libelf + libraries, but also the libebl backend shared libraries + with architecture specific code to read elf files. If you + intend to use libelf/libebl at-runtime, say 'y' here. + If you only need to link against libelf at-compile-time, + but not really using it, you can leave the architecture + specific backends uninstalled. Loading of the backend library + by libebl will fail in that case. + endifpackage/elfutils/elfutils.mk +6
-0@@ -65,4 +65,10 @@ else ELFUTILS_CONF_OPTS += --disable-progs endif +ifeq ($(BR2_PACKAGE_ELFUTILS_BACKENDS),y) + ELFUTILS_CONF_OPTS += --enable-backends +else + ELFUTILS_CONF_OPTS += --disable-backends +endif + $(eval $(autotools-package))Signature · 6 lines
1.9.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'