fastboot: Proper download gadget unregister and clear when cable is missing

PATCH RESEND Superseded Paul Kocialkowski 3 participants 7 messages Mar 28, 2015 – Apr 8, 2015

lore

Share & tools

lore

Paul Kocialkowski

author

2015-03-28 17:22 UTC #0 lore raw

PATCH RESEND 1/1 fastboot: Proper download gadget unregister and clear when cable is missing

Signed-off-by Paul Kocialkowski <[email protected]>

---
 common/cmd_fastboot.c | 2 ++
 1 file changed, 2 insertions(+)

common/cmd_fastboot.c +2 -0

index 346ab80..7956a5b 100644
@@ -23,6 +23,8 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[])
 	if (!g_dnl_board_usb_cable_connected()) {
 		puts("\rUSB cable not detected.\n" \
 		     "Command exit.\n");
+		g_dnl_unregister();
+		g_dnl_clear_detach();
 		return CMD_RET_FAILURE;
 	}

Signature · 1 line

1.9.1

Lukasz Majewski

2015-03-30 08:06 UTC #1 lore raw

PATCH RESEND 1/1 fastboot: Proper download gadget unregister and clear when cable is missing

Hi Paul,

Quoted 10 lines

Signed-off-by Paul Kocialkowski <[email protected]>
---
 common/cmd_fastboot.c | 2 ++
 1 file changed, 2 insertions(+)
common/cmd_fastboot.c +0 -0
index 346ab80..7956a5b 100644

common/cmd_fastboot.c static int do_fastboot(cmd_tbl_t *cmdtp, int flag, · line 30

Quoted 8 lines

common/cmd_fastboot.c +2 -0

@@ -23,6 +23,8 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag,
 int argc, char *const argv[]) if (!g_dnl_board_usb_cable_connected())
 { puts("\rUSB cable not detected.\n" \
 		     "Command exit.\n");
+		g_dnl_unregister();
+		g_dnl_clear_detach();
 		return CMD_RET_FAILURE;
 	}

This is just a minor comment - in your future patches please add some commit message even for this very short patch.

Despite that,

Acked-by Lukasz Majewski <[email protected]>

If other (Marek, Tom) don't mind I will take this through -dfu tree.

Signature · 5 lines

Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

Paul Kocialkowski

author

2015-03-30 13:28 UTC #2 lore raw

PATCH RESEND 1/1 fastboot: Proper download gadget unregister and clear when cable is missing

Le lundi 30 mars 2015 ? 10:06 +0200, Lukasz Majewski a ?crit :

Quoted 7 lines

Hi Paul,
Quoted 5 lines
Signed-off-by Paul Kocialkowski <[email protected]>
---
 common/cmd_fastboot.c | 2 ++
 1 file changed, 2 insertions(+)

Quoted 16 lines

common/cmd_fastboot.c static int do_fastboot(cmd_tbl_t *cmdtp, int flag, · line 30
Quoted 13 lines
common/cmd_fastboot.c +2 -0
index 346ab80..7956a5b 100644
@@ -23,6 +23,8 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag,
 int argc, char *const argv[]) if (!g_dnl_board_usb_cable_connected())
 { puts("\rUSB cable not detected.\n" \
 		     "Command exit.\n");
+		g_dnl_unregister();
+		g_dnl_clear_detach();
 		return CMD_RET_FAILURE;
 	}
 
This is just a minor comment - in your future patches please add some commit message even for this very short patch.

Understood.

Quoted 5 lines

Despite that,
Acked-by Lukasz Majewski <[email protected]>
If other (Marek, Tom) don't mind I will take this through -dfu tree.

Thanks!

Signature · 17 lines

Paul Kocialkowski, Replicant developer

Replicant is a fully free Android distribution running on several
devices, a free software mobile operating system putting the emphasis on
freedom and privacy/security.

Website: http://www.replicant.us/
Blog: http://blog.replicant.us/
Wiki/tracker/forums: http://redmine.replicant.us/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150330/ca574223/attachment.sig>

Marek Vasut

2015-04-02 17:11 UTC #3 lore raw

PATCH RESEND 1/1 fastboot: Proper download gadget unregister and clear when cable is missing

In reply to Lukasz Majewski

Quoted 28 lines · Lukasz Majewski

Hi Paul,
Quoted 19 lines
Signed-off-by Paul Kocialkowski <[email protected]>
---
 common/cmd_fastboot.c | 2 ++
 1 file changed, 2 insertions(+)
common/cmd_fastboot.c +2 -0
index 346ab80..7956a5b 100644
@@ -23,6 +23,8 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag,
 int argc, char *const argv[]) if (!g_dnl_board_usb_cable_connected())
 { puts("\rUSB cable not detected.\n" \
 
 		     "Command exit.\n");
 
+		g_dnl_unregister();
+		g_dnl_clear_detach();
 
common/cmd_fastboot.c static int do_fastboot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[])
Quoted 3 lines
common/cmd_fastboot.c +0 -0
 		return CMD_RET_FAILURE;
 
 	}
This is just a minor comment - in your future patches please add some commit message even for this very short patch.

Quoted 5 lines

Despite that,
Acked-by Lukasz Majewski <[email protected]>
If other (Marek, Tom) don't mind I will take this through -dfu tree.

Please do, thanks!

btw. is this for current or next release ?

Best regards,
Marek Vasut

Lukasz Majewski

2015-04-03 07:35 UTC #4 lore raw

PATCH RESEND 1/1 fastboot: Proper download gadget unregister and clear when cable is missing

Hi Marek,

Quoted 34 lines · Lukasz Majewski

Quoted 33 lines
Hi Paul,
Quoted 15 lines
Signed-off-by Paul Kocialkowski <[email protected]>
---
 common/cmd_fastboot.c | 2 ++
 1 file changed, 2 insertions(+)
common/cmd_fastboot.c +0 -0
index 346ab80..7956a5b 100644
@@ -23,6 +23,8 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int
flag, int argc, char *const argv[]) if (!g_dnl_board_usb_cable_connected()) { puts("\rUSB cable not detected.\n" \
common/cmd_fastboot.c static int do_fastboot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[])
Quoted 8 lines
common/cmd_fastboot.c +2 -0
 		     "Command exit.\n");
 
+		g_dnl_unregister();
+		g_dnl_clear_detach();
 
 		return CMD_RET_FAILURE;
 
 	}
This is just a minor comment - in your future patches please add some commit message even for this very short patch.
Despite that,
Acked-by Lukasz Majewski <[email protected]>

Quoted 8 lines

Quoted 1 line
If other (Marek, Tom) don't mind I will take this through -dfu tree.
Please do, thanks!
btw. is this for current or next release ?
Best regards,
Marek Vasut

I thought to add this code in the next merge window, since now we have -rc5.

The v2015.04 is scheduled for 13.04.

Signature · 5 lines

Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

Marek Vasut

2015-04-03 08:09 UTC #5 lore raw

PATCH RESEND 1/1 fastboot: Proper download gadget unregister and clear when cable is missing

Quoted 42 lines · Lukasz Majewski

Hi Marek,
Quoted 40 lines · Lukasz Majewski
Quoted 29 lines
Hi Paul,
Quoted 15 lines
Signed-off-by Paul Kocialkowski <[email protected]>
---
 common/cmd_fastboot.c | 2 ++
 1 file changed, 2 insertions(+)
common/cmd_fastboot.c +0 -0
index 346ab80..7956a5b 100644
@@ -23,6 +23,8 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int
flag, int argc, char *const argv[]) if (!g_dnl_board_usb_cable_connected()) { puts("\rUSB cable not detected.\n" \
common/cmd_fastboot.c static int do_fastboot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[])
Quoted 8 lines
common/cmd_fastboot.c +2 -0
 		     "Command exit.\n");
 
+		g_dnl_unregister();
+		g_dnl_clear_detach();
 
 		return CMD_RET_FAILURE;
 
 	}
This is just a minor comment - in your future patches please add some commit message even for this very short patch.
Quoted 5 lines
Despite that,
Acked-by Lukasz Majewski <[email protected]>
If other (Marek, Tom) don't mind I will take this through -dfu tree.
Please do, thanks!
btw. is this for current or next release ?

Quoted 7 lines

Quoted 2 lines
Best regards,
Marek Vasut
I thought to add this code in the next merge window, since now we have -rc5.
The v2015.04 is scheduled for 13.04.

Roger that, thanks!

Best regards,
Marek Vasut

Lukasz Majewski

2015-04-08 09:01 UTC #6 lore raw

PATCH RESEND 1/1 fastboot: Proper download gadget unregister and clear when cable is missing

In reply to Paul Kocialkowski

Hi Paul,

Quoted 10 lines

Signed-off-by Paul Kocialkowski <[email protected]>
---
 common/cmd_fastboot.c | 2 ++
 1 file changed, 2 insertions(+)
common/cmd_fastboot.c +0 -0
index 346ab80..7956a5b 100644

common/cmd_fastboot.c static int do_fastboot(cmd_tbl_t *cmdtp, int flag, · line 30

Quoted 8 lines

common/cmd_fastboot.c +2 -0

@@ -23,6 +23,8 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag,
 int argc, char *const argv[]) if (!g_dnl_board_usb_cable_connected())
 { puts("\rUSB cable not detected.\n" \
 		     "Command exit.\n");
+		g_dnl_unregister();
+		g_dnl_clear_detach();
 		return CMD_RET_FAILURE;
 	}

Applied to u-boot-dfu branch.

Thanks!

Signature · 5 lines

Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group