Skip to contentSkip to conversation

toolchains: remove non-LFS toolchain

PATCH New Yann E. MORIN 3 participants 5 messages Apr 3, 2015

lore
Share & tools
lore

Yann E. MORIN

author
#0 lore raw

PATCH 1/1 toolchains: remove non-LFS toolchain

Buildroot now requires toolchains to have LFS; it's no longer optional.

Signed-off-by "Yann E. MORIN" <[email protected]>
Cc Thomas Petazzoni <[email protected]>
---
 web/toolchains/configs/br-powerpc-603e-basic-cpp.config | 9 ---------
 1 file changed, 9 deletions(-)
 delete mode 100644 web/toolchains/configs/br-powerpc-603e-basic-cpp.config
web/toolchains/configs/br-powerpc-603e-basic-cpp.config deleted +0 -9
deleted file mode 100644
index 9f1eb82..0000000
@@ -1,9 +0,0 @@
-BR2_powerpc=y
-BR2_powerpc_603e=y
-BR2_TOOLCHAIN_EXTERNAL=y
-BR2_TOOLCHAIN_EXTERNAL_CUSTOM=y
-BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD=y
-BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/tarballs/br-powerpc-603e-basic-cpp-2015.02.tar.bz2"
-BR2_TOOLCHAIN_EXTERNAL_HEADERS_3_18=y
-# BR2_TOOLCHAIN_EXTERNAL_HAS_THREADS_DEBUG is not set
-BR2_TOOLCHAIN_EXTERNAL_CXX=y
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 toolchains: remove non-LFS toolchain

Hi Yann,

Quoted 1 line · Yann E. MORIN

Buildroot now requires toolchains to have LFS; it's no longer optional.

Why not just rebuild this toolchain using current master with LFS?

baruch

Quoted 22 lines
Signed-off-by "Yann E. MORIN" <[email protected]>
Cc Thomas Petazzoni <[email protected]>
---
 web/toolchains/configs/br-powerpc-603e-basic-cpp.config | 9 ---------
 1 file changed, 9 deletions(-)
 delete mode 100644 web/toolchains/configs/br-powerpc-603e-basic-cpp.config
web/toolchains/configs/br-powerpc-603e-basic-cpp.config deleted +0 -9
deleted file mode 100644
index 9f1eb82..0000000
@@ -1,9 +0,0 @@
-BR2_powerpc=y
-BR2_powerpc_603e=y
-BR2_TOOLCHAIN_EXTERNAL=y
-BR2_TOOLCHAIN_EXTERNAL_CUSTOM=y
-BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD=y
-BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/tarballs/br-powerpc-603e-basic-cpp-2015.02.tar.bz2"
-BR2_TOOLCHAIN_EXTERNAL_HEADERS_3_18=y
-# BR2_TOOLCHAIN_EXTERNAL_HAS_THREADS_DEBUG is not set
-BR2_TOOLCHAIN_EXTERNAL_CXX=y
Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#2 lore raw

PATCH 1/1 toolchains: remove non-LFS toolchain

Dear Baruch Siach,

Quoted 6 lines · Baruch Siach

Hi Yann,

Quoted 1 line · Yann E. MORIN

Buildroot now requires toolchains to have LFS; it's no longer optional.

Why not just rebuild this toolchain using current master with LFS?

That's the plan, but until this is done, to fix autobuilder issues, let's disable this toolchain.

I will rebuild the ARM and PowerPC basic toolchains, and also the SH4 toolchain after applying Waldemar's fix, and then update the autobuilder configuration accordingly.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#3 lore raw

PATCH 1/1 toolchains: remove non-LFS toolchain

In reply to Yann E. MORIN

Dear Yann E. MORIN,

Quoted 8 lines · Yann E. MORIN

Buildroot now requires toolchains to have LFS; it's no longer optional.

Signed-off-by "Yann E. MORIN" <[email protected]>
Cc Thomas Petazzoni <[email protected]>
---
 web/toolchains/configs/br-powerpc-603e-basic-cpp.config | 9 ---------
 1 file changed, 9 deletions(-)
 delete mode 100644 web/toolchains/configs/br-powerpc-603e-basic-cpp.config

Thanks, applied. However, you forgot to also update the CSV file that lists all toolchain (so I did that). And next time if you could --subject-prefix="buildroot-test" or something like that, it would be great, as it allows to more clearly distinguish such patches from real Buildroot patches.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#4 lore raw

PATCH 1/1 toolchains: remove non-LFS toolchain

Thomas, All,

On 2015-04-03 14:26 +0200, Thomas Petazzoni spake thusly:

Quoted 10 lines · Yann E. MORIN
Quoted 8 lines

Buildroot now requires toolchains to have LFS; it's no longer optional.

Signed-off-by "Yann E. MORIN" <[email protected]>
Cc Thomas Petazzoni <[email protected]>
---
 web/toolchains/configs/br-powerpc-603e-basic-cpp.config | 9 ---------
 1 file changed, 9 deletions(-)
 delete mode 100644 web/toolchains/configs/br-powerpc-603e-basic-cpp.config
Quoted 2 lines

Thanks, applied. However, you forgot to also update the CSV file that lists all toolchain (so I did that).

Damn, thanks.

Quoted 4 lines

And next time if you could --subject-prefix="buildroot-test" or something like that, it would be great, as it allows to more clearly distinguish such patches from real Buildroot patches.

Well, here's what I did:

    git send-email HEAD^ --to buildroot --suffix='autobuild'

hoping to get something like [PATCH 1/1 autobuild] blabla

But looking at the docs, it's not a send-email option, it's a format-patch option. Still it did auto-compete it. Damn... Sorry.

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'