Skip to contentSkip to conversation

OMAP-GPMC driver updates for v4.1

GIT PULL Applied Roger Quadros 2 participants 4 messages Mar 23, 2015 – Apr 9, 2015

lore
Share & tools
lore
#0 lore raw

Hi Arnd, Hi Olof,

Based on Tony's request I will be sending you pull requests for OMAP-GPMC driver hence forth. I've sent this earlier on the 9th of March but had missed to copy Olof.

Please pull in these OMAP-GPMC driver fixes for v4.1. Patches have been tested for GPMC-NAND on dra7-evm and omap3-beagle.

Thanks.

The following changes since commit c517d838eb7d07bbe9507871fab3931deccff539:

Linux 4.0-rc1 (2015-02-22 18:21:14 -0800)

are available in the git repository at:

git at github.com:rogerq/linux.git tags/gpmc-omap-for-v4.1

for you to fetch changes up to 4b613e9b4bbe94545a588a100e09006d827a7ebe:

ARM OMAP2+ GPMC: fix programming/showing reserved timing parameters (2015-03-06 12:55:32 +0200)

----------------------------------------------------------------
OMAP-GPMC driver fixes for v4.1

* Fixed WAITMONITORINGTIME programming to be based on GPMC_CLK instead of GPMC_FCLK. The GPMC clock divider programming is fixed for both synchronous and asynchronous modes.
* Allow GPMC's children of default bus type to be populated in the device tree.
* Improved DEBUG output data and format.
* Prevent writing 1 into reserved bits of GPMC_CONFIG7.

----------------------------------------------------------------
Robert ABEL (8):
ARM OMAP2+ GPMC: don't undef DEBUG
ARM OMAP2+ GPMC: add bus children
ARM OMAP2+ GPMC: fix debug output alignment
ARM OMAP2+ GPMC: change get_gpmc_timing_reg output for DTS ARM OMAP2+ GPMC: always program GPMCFCLKDIVIDER
ARM OMAP2+ GPMC: calculate GPMCFCLKDIVIDER based on WAITMONITORINGTIME ARM OMAP2+ GPMC: fix WAITMONITORINGTIME divider bug
ARM OMAP2+ GPMC: fix programming/showing reserved timing parameters

Semen Protsenko (2):
ARM: OMAP2+: gpmc: Fix writing in gpmc_cs_set_memconf
ARM: OMAP2+: gpmc: make gpmc_cs_get_name() static

 arch/arm/mach-omap2/gpmc-nand.c    |  18 +++++----
 arch/arm/mach-omap2/gpmc-onenand.c |   4 +-
 arch/arm/mach-omap2/usb-tusb6010.c |   4 +-
 drivers/memory/omap-gpmc.c         | 358 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------
 include/linux/omap-gpmc.h          |   3 +-
 5 files changed, 305 insertions(+), 82 deletions(-)
#1 lore raw

Arnd, Olof,

Quoted 7 lines · Roger Quadros

Hi Arnd, Hi Olof,

Based on Tony's request I will be sending you pull requests for OMAP-GPMC driver hence forth. I've sent this earlier on the 9th of March but had missed to copy Olof.

Please pull in these OMAP-GPMC driver fixes for v4.1. Patches have been tested for GPMC-NAND on dra7-evm and omap3-beagle.

Gentle reminder. Thanks.

cheers,
-roger

Quoted 51 lines

The following changes since commit c517d838eb7d07bbe9507871fab3931deccff539:

Linux 4.0-rc1 (2015-02-22 18:21:14 -0800)

are available in the git repository at:

git at github.com:rogerq/linux.git tags/gpmc-omap-for-v4.1

for you to fetch changes up to 4b613e9b4bbe94545a588a100e09006d827a7ebe:

ARM OMAP2+ GPMC: fix programming/showing reserved timing parameters (2015-03-06 12:55:32 +0200)

----------------------------------------------------------------
OMAP-GPMC driver fixes for v4.1

* Fixed WAITMONITORINGTIME programming to be based on GPMC_CLK instead of GPMC_FCLK. The GPMC clock divider programming is fixed for both synchronous and asynchronous modes.
* Allow GPMC's children of default bus type to be populated in the device tree.
* Improved DEBUG output data and format.
* Prevent writing 1 into reserved bits of GPMC_CONFIG7.

----------------------------------------------------------------
Robert ABEL (8):
ARM OMAP2+ GPMC: don't undef DEBUG
ARM OMAP2+ GPMC: add bus children
ARM OMAP2+ GPMC: fix debug output alignment
ARM OMAP2+ GPMC: change get_gpmc_timing_reg output for DTS ARM OMAP2+ GPMC: always program GPMCFCLKDIVIDER
ARM OMAP2+ GPMC: calculate GPMCFCLKDIVIDER based on WAITMONITORINGTIME ARM OMAP2+ GPMC: fix WAITMONITORINGTIME divider bug
ARM OMAP2+ GPMC: fix programming/showing reserved timing parameters

Semen Protsenko (2):
ARM: OMAP2+: gpmc: Fix writing in gpmc_cs_set_memconf
ARM: OMAP2+: gpmc: make gpmc_cs_get_name() static

 arch/arm/mach-omap2/gpmc-nand.c    |  18 +++++----
 arch/arm/mach-omap2/gpmc-onenand.c |   4 +-
 arch/arm/mach-omap2/usb-tusb6010.c |   4 +-
 drivers/memory/omap-gpmc.c         | 358 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------
 include/linux/omap-gpmc.h          |   3 +-
 5 files changed, 305 insertions(+), 82 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

#2 lore raw
In reply to Roger Quadros
Quoted 4 lines · Roger Quadros

Hi Arnd, Hi Olof,

Based on Tony's request I will be sending you pull requests for OMAP-GPMC driver hence forth. I've sent this earlier on the 9th of March but had missed to copy Olof.

It was actually in my queue but I hadn't gotten to it yet. A few comments below.

Quoted 9 lines

Please pull in these OMAP-GPMC driver fixes for v4.1. Patches have been tested for GPMC-NAND on dra7-evm and omap3-beagle.

Thanks.

The following changes since commit c517d838eb7d07bbe9507871fab3931deccff539:

Linux 4.0-rc1 (2015-02-22 18:21:14 -0800)

Quoted 7 lines

are available in the git repository at:

git at github.com:rogerq/linux.git tags/gpmc-omap-for-v4.1

for you to fetch changes up to 4b613e9b4bbe94545a588a100e09006d827a7ebe:

ARM OMAP2+ GPMC: fix programming/showing reserved timing parameters (2015-03-06 12:55:32 +0200)

Merged into next/drivers

Quoted 12 lines

----------------------------------------------------------------
OMAP-GPMC driver fixes for v4.1

* Fixed WAITMONITORINGTIME programming to be based on GPMC_CLK instead of GPMC_FCLK. The GPMC clock divider programming is fixed for both synchronous and asynchronous modes.
* Allow GPMC's children of default bus type to be populated in the device tree.
* Improved DEBUG output data and format.
* Prevent writing 1 into reserved bits of GPMC_CONFIG7.

Quoted 10 lines

----------------------------------------------------------------
Robert ABEL (8):
ARM OMAP2+ GPMC: don't undef DEBUG
ARM OMAP2+ GPMC: add bus children
ARM OMAP2+ GPMC: fix debug output alignment
ARM OMAP2+ GPMC: change get_gpmc_timing_reg output for DTS ARM OMAP2+ GPMC: always program GPMCFCLKDIVIDER
ARM OMAP2+ GPMC: calculate GPMCFCLKDIVIDER based on WAITMONITORINGTIME ARM OMAP2+ GPMC: fix WAITMONITORINGTIME divider bug
ARM OMAP2+ GPMC: fix programming/showing reserved timing parameters

We prefix patches to arch/arm/* with ARM: <platform>:. For these, memory: gpmc:
seems to be a better prefix going forward.

Quoted 9 lines

Semen Protsenko (2):
ARM: OMAP2+: gpmc: Fix writing in gpmc_cs_set_memconf
ARM: OMAP2+: gpmc: make gpmc_cs_get_name() static

 arch/arm/mach-omap2/gpmc-nand.c    |  18 +++++----
 arch/arm/mach-omap2/gpmc-onenand.c |   4 +-
 arch/arm/mach-omap2/usb-tusb6010.c |   4 +-
 drivers/memory/omap-gpmc.c         | 358 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------
 include/linux/omap-gpmc.h          |   3 +-

Tip: If you have a 80-column terminal, or redirect the request-pull to a file, you dont' get these super long diffstat lines. :)

-Olof

#3 lore raw
Quoted 20 lines · Olof Johansson
Quoted 4 lines · Roger Quadros

Hi Arnd, Hi Olof,

Based on Tony's request I will be sending you pull requests for OMAP-GPMC driver hence forth. I've sent this earlier on the 9th of March but had missed to copy Olof.

It was actually in my queue but I hadn't gotten to it yet. A few comments below.

Quoted 11 lines

Please pull in these OMAP-GPMC driver fixes for v4.1. Patches have been tested for GPMC-NAND on dra7-evm and omap3-beagle.

Thanks.

The following changes since commit c517d838eb7d07bbe9507871fab3931deccff539:

Linux 4.0-rc1 (2015-02-22 18:21:14 -0800)

are available in the git repository at:

Quoted 7 lines
Quoted 5 lines

git at github.com:rogerq/linux.git tags/gpmc-omap-for-v4.1

for you to fetch changes up to 4b613e9b4bbe94545a588a100e09006d827a7ebe:

ARM OMAP2+ GPMC: fix programming/showing reserved timing parameters (2015-03-06 12:55:32 +0200)

Merged into next/drivers

Thanks Olof.

Quoted 24 lines
Quoted 13 lines

----------------------------------------------------------------
OMAP-GPMC driver fixes for v4.1

* Fixed WAITMONITORINGTIME programming to be based on GPMC_CLK instead of GPMC_FCLK. The GPMC clock divider programming is fixed for both synchronous and asynchronous modes.
* Allow GPMC's children of default bus type to be populated in the device tree.
* Improved DEBUG output data and format.
* Prevent writing 1 into reserved bits of GPMC_CONFIG7.

Quoted 10 lines

----------------------------------------------------------------
Robert ABEL (8):
ARM OMAP2+ GPMC: don't undef DEBUG
ARM OMAP2+ GPMC: add bus children
ARM OMAP2+ GPMC: fix debug output alignment
ARM OMAP2+ GPMC: change get_gpmc_timing_reg output for DTS ARM OMAP2+ GPMC: always program GPMCFCLKDIVIDER
ARM OMAP2+ GPMC: calculate GPMCFCLKDIVIDER based on WAITMONITORINGTIME ARM OMAP2+ GPMC: fix WAITMONITORINGTIME divider bug
ARM OMAP2+ GPMC: fix programming/showing reserved timing parameters

Quoted 2 lines

We prefix patches to arch/arm/* with ARM: <platform>:. For these, memory: gpmc:
seems to be a better prefix going forward.

Noted.

Quoted 5 lines
Quoted 5 lines

Semen Protsenko (2):
ARM: OMAP2+: gpmc: Fix writing in gpmc_cs_set_memconf
ARM: OMAP2+: gpmc: make gpmc_cs_get_name() static

Quoted 8 lines
Quoted 5 lines
 arch/arm/mach-omap2/gpmc-nand.c    |  18 +++++----
 arch/arm/mach-omap2/gpmc-onenand.c |   4 +-
 arch/arm/mach-omap2/usb-tusb6010.c |   4 +-
 drivers/memory/omap-gpmc.c         | 358 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------
 include/linux/omap-gpmc.h          |   3 +-

Tip: If you have a 80-column terminal, or redirect the request-pull to a file, you dont' get these super long diffstat lines. :)

Got it. Thanks :).

cheers,
-roger