ARM: dts: sun5i: Enable touchscreen on Utoo P66

PATCH Superseded Hans de Goede 2 participants 5 messages Apr 1, 2015 – Apr 9, 2015

Subsystems (2)

Device tree bindings Arm/Allwinner sunXi SoC support

lore

Share & tools

lore

Hans de Goede

author

2015-04-01 15:29 UTC #0 lore raw

PATCH v2 1/1 ARM: dts: sun5i: Enable touchscreen on Utoo P66

Add a node for the chipone-icn8318 touchscreen found on the Utoo P66 tablet.

Signed-off-by Hans de Goede <[email protected]>

---
Changes in v2:
-Fix touchscreen node name

---
 arch/arm/boot/dts/sun5i-a13-utoo-p66.dts | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

arch/arm/boot/dts/sun5i-a13-utoo-p66.dts +22 -0

index 9108ecd..00bdf28 100644
@@ -50,6 +50,7 @@
 #include "sunxi-common-regulators.dtsi"
 #include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/input/input.h>
+#include <dt-bindings/interrupt-controller/irq.h>
 #include <dt-bindings/pinctrl/sun4i-a10.h>
 
 / {

@@ -93,6 +94,20 @@
 	pinctrl-0 = <&i2c1_pins_a>;
 	status = "okay";
 
+	icn8318: touchscreen at 40 {
+		compatible = "chipone,icn8318";
+		reg = <0x40>;
+		interrupt-parent = <&pio>;
+		interrupts = <9 IRQ_TYPE_EDGE_FALLING>; /* EINT9 (PG9) */
+		pinctrl-names = "default";
+		pinctrl-0 = <&ts_wake_pin_p66>;
+		wake-gpios = <&pio 1 3 GPIO_ACTIVE_HIGH>; /* PB3 */
+		touchscreen-size-x = <800>;
+		touchscreen-size-y = <480>;
+		touchscreen-inverted-x;
+		touchscreen-swapped-x-y;
+	};
+
 	pcf8563: rtc at 51 {
 		compatible = "nxp,pcf8563";
 		reg = <0x51>;

@@ -172,6 +187,13 @@
 		allwinner,pull = <SUN4I_PINCTRL_PULL_UP>;
 	};
 
+	ts_wake_pin_p66: ts_wake_pin at 0 {
+		allwinner,pins = "PB3";
+		allwinner,function = "gpio_out";
+		allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+		allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+	};
+
 	usb0_vbus_pin_a: usb0_vbus_pin at 0 {
 		allwinner,pins = "PB4";
 		allwinner,function = "gpio_out";

Signature · 1 line

2.3.4

Maxime Ripard

2015-04-04 12:44 UTC #1 lore raw

PATCH v2 1/1 ARM: dts: sun5i: Enable touchscreen on Utoo P66

Hi Hans,

Quoted 23 lines · Hans de Goede

Add a node for the chipone-icn8318 touchscreen found on the Utoo P66 tablet.
Signed-off-by Hans de Goede <[email protected]>
---
Changes in v2:
(quoted diff) +0 -2
-Fix touchscreen node name
---
 arch/arm/boot/dts/sun5i-a13-utoo-p66.dts | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
arch/arm/boot/dts/sun5i-a13-utoo-p66.dts +1 -0
index 9108ecd..00bdf28 100644
@@ -50,6 +50,7 @@
 #include "sunxi-common-regulators.dtsi"
 #include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/input/input.h>
+#include <dt-bindings/interrupt-controller/irq.h>
 #include <dt-bindings/pinctrl/sun4i-a10.h>
 
 / {

arch/arm/boot/dts/sun5i-a13-utoo-p66.dts line 101

Quoted 8 lines

arch/arm/boot/dts/sun5i-a13-utoo-p66.dts +5 -0

@@ -93,6 +94,20 @@
 	pinctrl-0 = <&i2c1_pins_a>;
 	status = "okay";
 
+	icn8318: touchscreen at 40 {
+		compatible = "chipone,icn8318";
+		reg = <0x40>;
+		interrupt-parent = <&pio>;
+		interrupts = <9 IRQ_TYPE_EDGE_FALLING>; /* EINT9 (PG9) */

I don't think you sent a reply to this comment, but this should really be in a pinctrl node so that no one else can request the pin and change its muxing and it shows up in debugfs.

Maxime

Signature · 10 lines

Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150404/9ef6c2c4/attachment.sig>

Hans de Goede

author

2015-04-04 13:21 UTC #2 lore raw

PATCH v2 1/1 ARM: dts: sun5i: Enable touchscreen on Utoo P66

Hi,

Quoted 29 lines · Maxime Ripard

Hi Hans,

Quoted 26 lines · Hans de Goede

Add a node for the chipone-icn8318 touchscreen found on the Utoo P66 tablet.

Signed-off-by Hans de Goede <[email protected]>

---
Changes in v2:

(quoted diff) +0 -2

-Fix touchscreen node name
---
  arch/arm/boot/dts/sun5i-a13-utoo-p66.dts | 22 ++++++++++++++++++++++
  1 file changed, 22 insertions(+)

arch/arm/boot/dts/sun5i-a13-utoo-p66.dts +1 -0

index 9108ecd..00bdf28 100644
@@ -50,6 +50,7 @@
  #include "sunxi-common-regulators.dtsi"
  #include <dt-bindings/gpio/gpio.h>
  #include <dt-bindings/input/input.h>
+#include <dt-bindings/interrupt-controller/irq.h>
  #include <dt-bindings/pinctrl/sun4i-a10.h>
 
  / {

@@ -93,6 +94,20 @@
  	pinctrl-0 = <&i2c1_pins_a>;
  	status = "okay";

Quoted 9 lines

arch/arm/boot/dts/sun5i-a13-utoo-p66.dts line 101
Quoted 5 lines
arch/arm/boot/dts/sun5i-a13-utoo-p66.dts +5 -0
+	icn8318: touchscreen at 40 {
+		compatible = "chipone,icn8318";
+		reg = <0x40>;
+		interrupt-parent = <&pio>;
+		interrupts = <9 IRQ_TYPE_EDGE_FALLING>; /* EINT9 (PG9) */
I don't think you sent a reply to this comment, but this should really be in a pinctrl node so that no one else can request the pin and change its muxing and it shows up in debugfs.

I did reply to that comment on v1 of this patch:

"""
That is not necessary when specifying a gpio interrupt through the irq chip (rather then through a gpios property), the mux is automatically set to irq by the kernel when requesting the irq.

Also note that we must use the interrupts notation here as this is specified by the i2c client bindings. None of the other boards using i2c + oob irq pins specifies a pinmux for the irq pin either.
"""

I've just double checked and I cannot (quickly) find any existing devicetree files using interrupts = <foo> combined with pinctrl for i2c clients.

If you look in e.g. arch/arm/boot/dts/exynos4210-trats.dts and arch/arm/boot/dts/exynos4412-trats2.dts you will see the same pattern of using interrupts = <foo> pointing to a gpio without using pinctrl

And we already to the same for sdio oob interrupts in sun7i-a20-cubietruck.dts and arch/arm/boot/dts/sun7i-a20-i12-tvbox.dts, so I vote for being consistent here and not using pinctrl for the irq pin here either.

Regards,

Hans

Maxime Ripard

2015-04-08 07:12 UTC #3 lore raw

PATCH v2 1/1 ARM: dts: sun5i: Enable touchscreen on Utoo P66

Quoted 49 lines · Hans de Goede

Hi,
Quoted 29 lines · Maxime Ripard
Hi Hans,
Quoted 26 lines · Hans de Goede
Add a node for the chipone-icn8318 touchscreen found on the Utoo P66 tablet.
Signed-off-by Hans de Goede <[email protected]>
---
Changes in v2:
(quoted diff) +0 -2
-Fix touchscreen node name
---
 arch/arm/boot/dts/sun5i-a13-utoo-p66.dts | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
arch/arm/boot/dts/sun5i-a13-utoo-p66.dts +1 -0
index 9108ecd..00bdf28 100644
@@ -50,6 +50,7 @@
 #include "sunxi-common-regulators.dtsi"
 #include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/input/input.h>
+#include <dt-bindings/interrupt-controller/irq.h>
 #include <dt-bindings/pinctrl/sun4i-a10.h>
 
 / {
@@ -93,6 +94,20 @@
 	pinctrl-0 = <&i2c1_pins_a>;
 	status = "okay";
 
Quoted 9 lines
arch/arm/boot/dts/sun5i-a13-utoo-p66.dts line 101
Quoted 5 lines
arch/arm/boot/dts/sun5i-a13-utoo-p66.dts +5 -0
+	icn8318: touchscreen at 40 {
+		compatible = "chipone,icn8318";
+		reg = <0x40>;
+		interrupt-parent = <&pio>;
+		interrupts = <9 IRQ_TYPE_EDGE_FALLING>; /* EINT9 (PG9) */
I don't think you sent a reply to this comment, but this should really be in a pinctrl node so that no one else can request the pin and change its muxing and it shows up in debugfs.
I did reply to that comment on v1 of this patch:
"""
That is not necessary when specifying a gpio interrupt through the irq chip (rather then through a gpios property), the mux is automatically set to irq by the kernel when requesting the irq.

Quoted 4 lines

Also note that we must use the interrupts notation here as this is specified by the i2c client bindings. None of the other boards using i2c + oob irq pins specifies a pinmux for the irq pin either.
"""

I never received that mail, I guess we can blame Google Groups for that.

Quoted 9 lines

I've just double checked and I cannot (quickly) find any existing devicetree files using interrupts = <foo> combined with pinctrl for i2c clients.
If you look in e.g. arch/arm/boot/dts/exynos4210-trats.dts and arch/arm/boot/dts/exynos4412-trats2.dts you will see the same pattern of using interrupts = <foo> pointing to a gpio without using pinctrl

Quoted 4 lines

And we already to the same for sdio oob interrupts in sun7i-a20-cubietruck.dts and arch/arm/boot/dts/sun7i-a20-i12-tvbox.dts, so I vote for being consistent here and not using pinctrl for the irq pin here either.

That might turn out to be an issue, but ok.

Maxime

Signature · 10 lines

Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150408/8c9300be/attachment.sig>

Maxime Ripard

Applied

2015-04-09 07:39 UTC #4 lore raw

PATCH v2 1/1 ARM: dts: sun5i: Enable touchscreen on Utoo P66

In reply to Hans de Goede

Quoted 3 lines · Hans de Goede

Add a node for the chipone-icn8318 touchscreen found on the Utoo P66 tablet.
Signed-off-by Hans de Goede <[email protected]>

Merged, thanks!

Maxime

Signature · 10 lines

Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150409/da6eb863/attachment.sig>