Skip to contentSkip to conversation

i2c-tools: add hash file

PATCH New Ryan Barnett 4 participants 8 messages Apr 5, 2015 – Apr 9, 2015

lore
Share & tools
lore

Ryan Barnett

author
#0 lore raw

PATCH v5 1/2 i2c-tools: add hash file

Signed-off-by Ryan Barnett <[email protected]>
Acked-by "Yann E. MORIN" <[email protected]>

---
Changes v2->v3:
- None

---
 package/i2c-tools/i2c-tools.hash | 2 ++
 1 file changed, 2 insertions(+)
 create mode 100644 package/i2c-tools/i2c-tools.hash
package/i2c-tools/i2c-tools.hash new file +2 -0
new file mode 100644
index 0000000..a6c376f
@@ -0,0 +1,2 @@
+# locally computed hash
+sha256	14d4d7d60d1c12e43f2befe239c682a5c44c27682f153d4b58c1e392d2db1700  i2c-tools-3.1.1.tar.bz2
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH v5 2/2 i2c-tools: add support to build python extension

Add a config option to build the python bindings for i2c-tools - py-smbus. The steps for building the python bindings is the same as the distutil steps that are a part of the python infrastructure.

Signed-off-by Ryan Barnett <[email protected]>
CC Thomas Petazzoni <[email protected]>
CC Baruch Siach <[email protected]>
CC Yann E. MORIN <[email protected]>

---
Changes v4 -> v5:
- Actually send v4 change :)

Changes v3 -> v4:
- Move define of BASE_ENV under BR2_PACKAGE_PYTHON (Yann)

Changes v2 -> v3:
- Removed Config.in entry (suggested by Baruch)
- Moved install and build defines with the CMD block (suggested by Yann)

Changes v1 -> v2:
- Fixed spelling in config entry
- Utilize the python infrastructure variables for environment and build/install opts (suggested by Thomas P)
- Only support python2.7 since this is not compatabile with python3 (suggested by Baruch)

---
 package/i2c-tools/i2c-tools.mk | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)
package/i2c-tools/i2c-tools.mk +27 -0
index 0115e22..6c156ca 100644
@@ -10,8 +10,34 @@ I2C_TOOLS_SITE = http://dl.lm-sensors.org/i2c-tools/releases
 I2C_TOOLS_LICENSE = GPLv2+, GPLv2 (py-smbus)
 I2C_TOOLS_LICENSE_FILES = COPYING
 
+# Build/install steps mirror the distutil python package type in the python package
+# infrastructure
+ifeq ($(BR2_PACKAGE_PYTHON),y)
+I2C_TOOLS_DEPENDENCIES += python
+# BASE_ENV taken from PKG_PYTHON_DISTUTILS_ENV in package/pkg-python.mk
+I2C_TOOLS_PYTHON_BASE_ENV = \
+	$(PKG_PYTHON_DISTUTILS_ENV) \
+	CFLAGS="$(TARGET_CFLAGS) -I../include"
+
+define I2C_TOOLS_BUILD_PYSMBUS
+	(cd $(@D)/py-smbus;  \
+	$(I2C_TOOLS_PYTHON_BASE_ENV) \
+		$(HOST_DIR)/usr/bin/python setup.py build \
+		$(PKG_PYTHON_DISTUTILS_BUILD_OPTS))
+endef
+
+define I2C_TOOLS_INSTALL_PYSMBUS
+	(cd $(@D)/py-smbus; \
+	$(I2C_TOOLS_PYTHON_BASE_ENV) \
+		$(HOST_DIR)/usr/bin/python setup.py install \
+		$(PKG_PYTHON_DISTUTILS_INSTALL_TARGET_OPTS))
+endef
+
+endif # BR2_PACKAGE_PYTHON
+
 define I2C_TOOLS_BUILD_CMDS
 	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D)
+	$(I2C_TOOLS_BUILD_PYSMBUS)
 endef
 
 define I2C_TOOLS_INSTALL_TARGET_CMDS

@@ -19,6 +45,7 @@ define I2C_TOOLS_INSTALL_TARGET_CMDS
 	do \
 		$(INSTALL) -m 755 -D $(@D)/tools/$$i $(TARGET_DIR)/usr/bin/$$i; \
 	done
+	$(I2C_TOOLS_INSTALL_PYSMBUS)
 endef
 
 $(eval $(generic-package))
Signature · 1 line
1.9.1
#2 lore raw

PATCH v5 2/2 i2c-tools: add support to build python extension

Dear Ryan Barnett,

Quoted 8 lines · Ryan Barnett

Add a config option to build the python bindings for i2c-tools - py-smbus. The steps for building the python bindings is the same as the distutil steps that are a part of the python infrastructure.

Signed-off-by Ryan Barnett <[email protected]>
CC Thomas Petazzoni <[email protected]>
CC Baruch Siach <[email protected]>
CC Yann E. MORIN <[email protected]>

Applied. Did you check that i2c-tools python support was Python 2 only? Or does it also support Python 3 ?

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#3 lore raw

PATCH v5 2/2 i2c-tools: add support to build python extension

Thomas, All,

On 2015-04-06 11:03 +0200, Thomas Petazzoni spake thusly:

Quoted 5 lines · Ryan Barnett
Quoted 4 lines

Add a config option to build the python bindings for i2c-tools - py-smbus. The steps for building the python bindings is the same as the distutil steps that are a part of the python infrastructure.

Quoted 7 lines
Quoted 4 lines
Signed-off-by Ryan Barnett <[email protected]>
CC Thomas Petazzoni <[email protected]>
CC Baruch Siach <[email protected]>
CC Yann E. MORIN <[email protected]>

Applied. Did you check that i2c-tools python support was Python 2 only? Or does it also support Python 3 ?

Yes, it is Python-2 only (see the v1->v2 changelog in the commit notes).

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#4 lore raw

PATCH v5 2/2 i2c-tools: add support to build python extension

Dear Ryan Barnett, Yann E. MORIN, Thomas Petazzoni,

2015-04-06 11:07 GMT+02:00 Yann E. MORIN <[email protected]>:

Quoted 13 lines

Thomas, All,

On 2015-04-06 11:03 +0200, Thomas Petazzoni spake thusly:

Quoted 10 lines · Ryan Barnett
Quoted 8 lines

Add a config option to build the python bindings for i2c-tools - py-smbus. The steps for building the python bindings is the same as the distutil steps that are a part of the python infrastructure.

Signed-off-by Ryan Barnett <[email protected]>
CC Thomas Petazzoni <[email protected]>
CC Baruch Siach <[email protected]>
CC Yann E. MORIN <[email protected]>
Quoted 4 lines
Quoted 2 lines

Applied. Did you check that i2c-tools python support was Python 2 only? Or does it also support Python 3 ?

Yes, it is Python-2 only (see the v1->v2 changelog in the commit notes).

This is not true! Py-smbus supports python 3, se the commit here for further reference:

http://www.lm-sensors.org/changeset/6267

Sincerely, Angelo

Quoted 14 lines

Regards,
Yann E. MORIN.

--
.-----------------.--------------------.------------------.--------------------.

|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |

'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 1 line
Profile: http://it.linkedin.com/in/compagnucciangelo
author
#5 lore raw

PATCH v5 2/2 i2c-tools: add support to build python extension

Angelo,

Quoted 11 lines · Angelo Compagnucci

Dear Ryan Barnett, Yann E. MORIN, Thomas Petazzoni,

Quoted 4 lines
Quoted 2 lines

Applied. Did you check that i2c-tools python support was Python 2 only? Or does it also support Python 3 ?

Yes, it is Python-2 only (see the v1->v2 changelog in the commit notes).

This is not true! Py-smbus supports python 3, se the commit here for further reference:

http://www.lm-sensors.org/changeset/6267

When I tried to compile for Python 3 - I had many errors about not finding Python3 functions. I would image that was probably due to the fact that the include paths weren't correct. However, at that time I had lost interest.

Please feel free to add support for Python 3 for py-smbus (i2c-tools). Will be sure to review and test it.

Thanks,
-Ryan

#6 lore raw

PATCH v5 2/2 i2c-tools: add support to build python extension

Dear Ryan Barnett,

2015-04-09 15:11 GMT+02:00 Ryan Barnett <[email protected]>:

Quoted 16 lines

Angelo,

Quoted 11 lines · Angelo Compagnucci

Dear Ryan Barnett, Yann E. MORIN, Thomas Petazzoni,

Quoted 4 lines
Quoted 2 lines

Applied. Did you check that i2c-tools python support was Python 2 only? Or does it also support Python 3 ?

Yes, it is Python-2 only (see the v1->v2 changelog in the commit notes).

This is not true! Py-smbus supports python 3, se the commit here for further reference:

http://www.lm-sensors.org/changeset/6267

Quoted 7 lines

When I tried to compile for Python 3 - I had many errors about not finding Python3 functions. I would image that was probably due to the fact that the include paths weren't correct. However, at that time I had lost interest.

Please feel free to add support for Python 3 for py-smbus (i2c-tools). Will be sure to review and test it.

Mea culpa! The version with python3 support is not released, the support is only in trunk!

Sincerely, Angelo.

Quoted 3 lines

Thanks,
-Ryan

Signature · 1 line
Profile: http://it.linkedin.com/in/compagnucciangelo
Applied
#7 lore raw

PATCH v5 1/2 i2c-tools: add hash file

In reply to Ryan Barnett

Dear Ryan Barnett,

Quoted 9 lines · Ryan Barnett
Signed-off-by Ryan Barnett <[email protected]>
Acked-by "Yann E. MORIN" <[email protected]>

---
Changes v2->v3:
- None

---
 package/i2c-tools/i2c-tools.hash | 2 ++
 1 file changed, 2 insertions(+)
 create mode 100644 package/i2c-tools/i2c-tools.hash

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com