Remove --{enable, disable}-debug configure flags.
PATCH v2 1/3 Remove --{enable, disable}-debug configure flags.
Adding this flag when BR2_ENABLE_DEBUG is activated make several packages to produce binaries that do not work as expected (e.g., dhcp, lame, nano). Moreover, the help message of BR2_ENABLE_DEBUG does not say it is adding this flag. It is supposed to build packages with debugging symbols enabled. So, let it do that only.
* package/Makefile.in: Do not add --{enable,disable}-debug flags.
* package/pkg-autotools.mk: Remove ENABLE_DEBUG as it is not set anymore.
---
Changes v1 -> v2:
- Do not pass --disable-debug neither.
--- package/Makefile.in | 6 ------ package/pkg-autotools.mk | 1 - 2 files changed, 7 deletions(-)
package/Makefile.in +0 -6
@@ -387,12 +387,6 @@ ifneq ($(BR2_INSTALL_LIBSTDCPP),y) TARGET_CONFIGURE_OPTS += CXX=false endif -ifeq ($(BR2_ENABLE_DEBUG),y) -ENABLE_DEBUG := --enable-debug -else -ENABLE_DEBUG := --disable-debug -endif - ifeq ($(BR2_STATIC_LIBS),y) SHARED_STATIC_LIBS_OPTS = --enable-static --disable-shared TARGET_CFLAGS += -static
package/pkg-autotools.mk +0 -1
@@ -203,7 +203,6 @@ define $(2)_CONFIGURE_CMDS $$(DISABLE_NLS) \ $$(DISABLE_LARGEFILE) \ $$(DISABLE_IPV6) \ - $$(ENABLE_DEBUG) \ $$(SHARED_STATIC_LIBS_OPTS) \ $$(QUIET) $$($$(PKG)_CONF_OPTS) \ )
Signature · 1 line
2.1.0
PATCH v2 2/3 lame: Remove --enable-debug workaround.
This is not needed since BR2_ENABLE_DEBUG does not set this flag anymore.
--- package/lame/lame.mk | 7 ------- 1 file changed, 7 deletions(-)
package/lame/lame.mk +0 -7
@@ -14,13 +14,6 @@ LAME_CONF_OPTS = --enable-dynamic-frontends LAME_LICENSE = LGPLv2+ LAME_LICENSE_FILES = COPYING -# Building lame with debug symbols needs the following macros to be -# defined: _FPU_MASK_IM, _FPU_MASK_ZM, _FPU_MASK_OM. -# So, if BR2_ENABLE_DEBUG is selected, then we have force lame to be -# built without debug symbols because a number of architectures don't -# have those macros defined. -LAME_CONF_OPTS += --disable-debug - ifeq ($(BR2_PACKAGE_LIBSNDFILE),y) LAME_DEPENDENCIES += libsndfile LAME_CONF_OPTS += --with-fileio=sndfile
Signature · 1 line
2.1.0
PATCH v2 2/3 lame: Remove --enable-debug workaround.
Johan, All,
On 2015-03-12 16:12 +0100, Johan Oudinet spake thusly:
Quoted 4 lines
This is not needed since
BR2_ENABLE_DEBUGdoes not set this flag anymore.Signed-off-by Johan Oudinet <[email protected]>
Regards,
Yann E. MORIN.
Quoted 29 lines
--- package/lame/lame.mk | 7 ------- 1 file changed, 7 deletions(-)package/lame/lame.mk +0
-7@@ -14,13 +14,6 @@ LAME_CONF_OPTS = --enable-dynamic-frontends LAME_LICENSE = LGPLv2+ LAME_LICENSE_FILES = COPYING -# Building lame with debug symbols needs the following macros to be -# defined: _FPU_MASK_IM, _FPU_MASK_ZM, _FPU_MASK_OM. -# So, if BR2_ENABLE_DEBUG is selected, then we have force lame to be -# built without debug symbols because a number of architectures don't -# have those macros defined. -LAME_CONF_OPTS += --disable-debug - ifeq ($(BR2_PACKAGE_LIBSNDFILE),y) LAME_DEPENDENCIES += libsndfile LAME_CONF_OPTS += --with-fileio=sndfileSignature · 6 lines
2.1.0 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH v2 3/3 mp4v2: Remove --disable-debug workaround.
In reply to Johan OudinetThis is not needed since BR2_ENABLE_DEBUG does not set this flag anymore.
--- package/mp4v2/mp4v2.mk | 6 ------ 1 file changed, 6 deletions(-)
package/mp4v2/mp4v2.mk +0 -6
@@ -16,12 +16,6 @@ MP4V2_LICENSE_FILES = COPYING # disable it MP4V2_CONF_ENV = ac_cv_prog_FOUND_HELP2MAN=no -# infrastructure passes --disable-debug if !BR2_ENABLE_DEBUG. With -# mpv42 the only thing this option does is that it tries to strip any -# -g* options from CFLAGS/CXXFLAGS. The logic to do so is -# unfortunately buggy, so just pass --enable-debug to disable this -MP4V2_CONF_OPTS = --enable-debug - ifeq ($(BR2_LARGEFILE),y) MP4V2_CONF_OPTS += --enable-largefile else
Signature · 1 line
2.1.0
PATCH v2 3/3 mp4v2: Remove --disable-debug workaround.
Johan, All,
On 2015-03-12 16:12 +0100, Johan Oudinet spake thusly:
Quoted 4 lines
This is not needed since
BR2_ENABLE_DEBUGdoes not set this flag anymore.Signed-off-by Johan Oudinet <[email protected]>
Regards,
Yann E. MORIN.
Quoted 28 lines
--- package/mp4v2/mp4v2.mk | 6 ------ 1 file changed, 6 deletions(-)package/mp4v2/mp4v2.mk +0
-6@@ -16,12 +16,6 @@ MP4V2_LICENSE_FILES = COPYING # disable it MP4V2_CONF_ENV = ac_cv_prog_FOUND_HELP2MAN=no -# infrastructure passes --disable-debug if !BR2_ENABLE_DEBUG. With -# mpv42 the only thing this option does is that it tries to strip any -# -g* options from CFLAGS/CXXFLAGS. The logic to do so is -# unfortunately buggy, so just pass --enable-debug to disable this -MP4V2_CONF_OPTS = --enable-debug - ifeq ($(BR2_LARGEFILE),y) MP4V2_CONF_OPTS += --enable-largefile elseSignature · 6 lines
2.1.0 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH v2 1/3 Remove --{enable, disable}-debug configure flags.
In reply to Johan OudinetHello all,
Quoted 11 lines · Johan Oudinet
Adding this flag when
BR2_ENABLE_DEBUGis activated make several packages to produce binaries that do not work as expected (e.g., dhcp, lame, nano). Moreover, the help message ofBR2_ENABLE_DEBUGdoes not say it is adding this flag. It is supposed to build packages with debugging symbols enabled. So, let it do that only.* package/Makefile.in: Do not add --{enable,disable}-debug flags.
*package/pkg-autotools.mk: RemoveENABLE_DEBUGas it is not set anymore.Signed-off-by Johan Oudinet <[email protected]>
Unless someone opposes to this change, I will apply it soon. So if you don't agree, speak up. If you agree, give your Acked-by/Reviewed-by.
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH v2 1/3 Remove --{enable, disable}-debug configure flags.
In reply to Johan OudinetJohan, All,
On 2015-03-12 16:12 +0100, Johan Oudinet spake thusly:
Quoted 11 lines
Adding this flag when
BR2_ENABLE_DEBUGis activated make several packages to produce binaries that do not work as expected (e.g., dhcp, lame, nano). Moreover, the help message ofBR2_ENABLE_DEBUGdoes not say it is adding this flag. It is supposed to build packages with debugging symbols enabled. So, let it do that only.* package/Makefile.in: Do not add --{enable,disable}-debug flags.
*package/pkg-autotools.mk: RemoveENABLE_DEBUGas it is not set anymore.Signed-off-by Johan Oudinet <[email protected]>
Regards,
Yann E. MORIN.
Quoted 44 lines
---
Changes v1 -> v2:
- Do not pass --disable-debug neither.--- package/Makefile.in | 6 ------ package/pkg-autotools.mk | 1 - 2 files changed, 7 deletions(-)package/Makefile.in +0
-6@@ -387,12 +387,6 @@ ifneq ($(BR2_INSTALL_LIBSTDCPP),y) TARGET_CONFIGURE_OPTS += CXX=false endif -ifeq ($(BR2_ENABLE_DEBUG),y) -ENABLE_DEBUG := --enable-debug -else -ENABLE_DEBUG := --disable-debug -endif - ifeq ($(BR2_STATIC_LIBS),y) SHARED_STATIC_LIBS_OPTS = --enable-static --disable-shared TARGET_CFLAGS += -staticpackage/pkg-autotools.mk +0
-1@@ -203,7 +203,6 @@ define $(2)_CONFIGURE_CMDS $$(DISABLE_NLS) \ $$(DISABLE_LARGEFILE) \ $$(DISABLE_IPV6) \ - $$(ENABLE_DEBUG) \ $$(SHARED_STATIC_LIBS_OPTS) \ $$(QUIET) $$($$(PKG)_CONF_OPTS) \ )Signature · 6 lines
2.1.0 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH v2 1/3 Remove --{enable, disable}-debug configure flags.
In reply to Johan OudinetDear Johan Oudinet,
Quoted 10 lines · Johan Oudinet
Adding this flag when
BR2_ENABLE_DEBUGis activated make several packages to produce binaries that do not work as expected (e.g., dhcp, lame, nano). Moreover, the help message ofBR2_ENABLE_DEBUGdoes not say it is adding this flag. It is supposed to build packages with debugging symbols enabled. So, let it do that only.* package/Makefile.in: Do not add --{enable,disable}-debug flags.
*package/pkg-autotools.mk: RemoveENABLE_DEBUGas it is not set anymore.
Quoted 8 lines
Signed-off-by Johan Oudinet <[email protected]>---
Changes v1 -> v2:
- Do not pass --disable-debug neither.--- package/Makefile.in | 6 ------ package/pkg-autotools.mk | 1 - 2 files changed, 7 deletions(-)
Applied the three patches of this series, thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com