Skip to contentSkip to conversation

Makefile: add help for linux-update-defconfig target

PATCH New Yegor Yefremov 3 participants 5 messages Apr 2, 2015 – Apr 6, 2015 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Makefile: add help for linux-update-defconfig target

---
 Makefile | 2 ++
 1 file changed, 2 insertions(+)
Makefile +2 -0
index edb122b..08b5c1e 100644
@@ -878,6 +878,8 @@ endif
 ifeq ($(BR2_LINUX_KERNEL),y)
 	@echo '  linux-menuconfig       - Run Linux kernel menuconfig'
 	@echo '  linux-savedefconfig    - Run Linux kernel savedefconfig'
+	@echo '  linux-update-defconfig - Save the Linux configuration to the path specified'
+	@echo '                             by BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE'
 endif
 ifeq ($(BR2_TOOLCHAIN_BUILDROOT),y)
 	@echo '  uclibc-menuconfig      - Run uClibc menuconfig'
Signature · 1 line
2.1.0
#1 lore raw

PATCH 1/1 Makefile: add help for linux-update-defconfig target

Quoted 1 line · Yegor Yefremov

Regards,
Arnout

Quoted 18 lines
---
 Makefile | 2 ++
 1 file changed, 2 insertions(+)
Makefile +2 -0
index edb122b..08b5c1e 100644
@@ -878,6 +878,8 @@ endif
 ifeq ($(BR2_LINUX_KERNEL),y)
 	@echo '  linux-menuconfig       - Run Linux kernel menuconfig'
 	@echo '  linux-savedefconfig    - Run Linux kernel savedefconfig'
+	@echo '  linux-update-defconfig - Save the Linux configuration to the path specified'
+	@echo '                             by BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE'
 endif
 ifeq ($(BR2_TOOLCHAIN_BUILDROOT),y)
 	@echo '  uclibc-menuconfig      - Run uClibc menuconfig'
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#2 lore raw

PATCH 1/1 Makefile: add help for linux-update-defconfig target

Arnout, Yegor,

Quoted 9 lines · Arnout Vandecappelle
Quoted 1 line
Quoted 4 lines
---
 Makefile | 2 ++
 1 file changed, 2 insertions(+)
Quoted 10 lines

Makefile endif · line 882

Quoted 10 lines
Makefile +2 -0
index edb122b..08b5c1e 100644
@@ -878,6 +878,8 @@ endif
 ifeq ($(BR2_LINUX_KERNEL),y)
 	@echo '  linux-menuconfig       - Run Linux kernel menuconfig'
 	@echo '  linux-savedefconfig    - Run Linux kernel savedefconfig'
+	@echo '  linux-update-defconfig - Save the Linux configuration to the path specified'
+	@echo '                             by BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE'

Why just for linux and not for all kconfig based packages ? Why <foo>-update-defconfig and not <foo>-update-config ?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#3 lore raw

PATCH 1/1 Makefile: add help for linux-update-defconfig target

Quoted 13 lines · Thomas Petazzoni

Arnout, Yegor,

Quoted 9 lines · Arnout Vandecappelle
Quoted 1 line
Quoted 4 lines
---
 Makefile | 2 ++
 1 file changed, 2 insertions(+)
Quoted 13 lines
Quoted 10 lines

Makefile endif · line 882

Quoted 10 lines
Makefile +2 -0
index edb122b..08b5c1e 100644
@@ -878,6 +878,8 @@ endif
 ifeq ($(BR2_LINUX_KERNEL),y)
 	@echo '  linux-menuconfig       - Run Linux kernel menuconfig'
 	@echo '  linux-savedefconfig    - Run Linux kernel savedefconfig'
+	@echo '  linux-update-defconfig - Save the Linux configuration to the path specified'
+	@echo '                             by BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE'

Why just for linux and not for all kconfig based packages ? Why <foo>-update-defconfig and not <foo>-update-config ?

Here are the reasons:

- update-defconfig doesn't exist for all kconfig packages

- update-defconfig is preferred if it exists (for Linux I certainly see no reason to ever use update-config)

- documenting foo-update-defconfig would perhaps be better, but that's part of a bigger change that would completely remove all the specifics. When I did the 'make help' patches I started on that, but it turns out to be a bit more work so I dropped it in the end.

Regards,
Arnout

Quoted 3 lines

Thomas

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#4 lore raw

PATCH 1/1 Makefile: add help for linux-update-defconfig target

Arnout,

Quoted 11 lines · Arnout Vandecappelle

Here are the reasons:

- update-defconfig doesn't exist for all kconfig packages

- update-defconfig is preferred if it exists (for Linux I certainly see no reason to ever use update-config)

- documenting foo-update-defconfig would perhaps be better, but that's part of a bigger change that would completely remove all the specifics. When I did the 'make help' patches I started on that, but it turns out to be a bit more work so I dropped it in the end.

Hm, well, I'm still not highly convinced on how we handle this per-package target help text. But anyway, applied, as it isn't that worse than what we have today.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com