Skip to contentSkip to conversation

libvpx : add hash

PATCH New Sagaert Johan 3 participants 3 messages Apr 6, 2015

lore
Share & tools
lore

Sagaert Johan

author
#0 lore raw

PATCH 1/1 libvpx : add hash

Also added VP8/VP9 codec names to Config.in menu help.

Signed-off-by Sagaert Johan <[email protected]>
---
 package/libvpx/Config.in   | 2 ++
 package/libvpx/libvpx.hash | 3 +++
 2 files changed, 5 insertions(+)
 create mode 100644 package/libvpx/libvpx.hash
package/libvpx/Config.in +2 -0
index 0ed3e1a..67cc71a 100644
@@ -4,6 +4,8 @@ config BR2_PACKAGE_LIBVPX
 	help
 	  A high-quality, open video format that's freely available to
 	  everyone.
+	  libvpx contains the VP8/VP9 codecs used in applications like
+	  linphone.
 
 	  http://webmproject.org
package/libvpx/libvpx.hash new file +3 -0
new file mode 100644
index 0000000..36d48f8
@@ -0,0 +1,3 @@
+# Locally computed:
+sha256  b3917c9167fc4979377fddee7f4e9378c35698dad18e23a729251c77644a2048  libvpx-v1.3.0.tar.gz
+
Signature · 1 line
2.3.3
#1 lore raw

PATCH 1/1 libvpx : add hash

Dear Sagaert Johan,

Quoted 14 lines · Sagaert Johan

Also added VP8/VP9 codec names to Config.in menu help.

Signed-off-by Sagaert Johan <[email protected]>
---
 package/libvpx/Config.in   | 2 ++
 package/libvpx/libvpx.hash | 3 +++
 2 files changed, 5 insertions(+)
 create mode 100644 package/libvpx/libvpx.hash
package/libvpx/Config.in +0 -0
index 0ed3e1a..67cc71a 100644

package/libvpx/Config.in config BR2_PACKAGE_LIBVPX · line 8

Quoted 5 lines
package/libvpx/Config.in +2 -0
@@ -4,6 +4,8 @@ config BR2_PACKAGE_LIBVPX
 	help
 	  A high-quality, open video format that's freely available to
 	  everyone.
+	  libvpx contains the VP8/VP9 codecs used in applications like
+	  linphone.

I don't think the "linphone" example makes a lot of sense, as there are zillions of other applications that may use libvpx, and some of them are probably more popular than linphone. Maybe something like:

A high-quality, open video format that's freely available to everyone. Supports the VP8 and VP9 formats.

package/libvpx/libvpx.hash line 2

Quoted 8 lines
package/libvpx/libvpx.hash new file +2 -0
new file mode 100644
index 0000000..36d48f8
@@ -0,0 +1,3 @@
+# Locally computed:
+sha256  b3917c9167fc4979377fddee7f4e9378c35698dad18e23a729251c77644a2048  libvpx-v1.3.0.tar.gz

We're fetching via Git, and the tarball is generated locally on your machine. Since this process is not reproducible, we cannot guarantee that the hash will always be the same. Therefore, we do not store hash files for Git-sourced packages.

I've marked your patch as Rejected in patchwork for this reason.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 libvpx : add hash

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hi,

Quoted 9 lines

package/libvpx/libvpx.hash line 2

Quoted 2 lines
package/libvpx/libvpx.hash new file +2 -0
+# Locally computed:
+sha256  b3917c9167fc4979377fddee7f4e9378c35698dad18e23a729251c77644a2048  libvpx-v1.3.0.tar.gz

We're fetching via Git, and the tarball is generated locally on your machine. Since this process is not reproducible, we cannot guarantee that the hash will always be the same. Therefore, we do not store hash files for Git-sourced packages.

I've marked your patch as Rejected in patchwork for this reason.

Also notice that libvpx 1.4.0 was recently released (including tarball), so it probably makes sense to bump and then add the .hash:

https://groups.google.com/a/webmproject.org/forum/#!topic/codec-devel/2zYWenmdUM8

Signature · 1 line
Bye, Peter Korsgaard