Skip to contentSkip to conversation

Makefile: remove redundant ifdef V

PATCH New Masahiro Yamada 2 participants 4 messages Apr 7, 2015 Kbuild

lore
Share & tools
lore

Masahiro Yamada

author
#0 lore raw

PATCH 1/1 Makefile: remove redundant ifdef V

If "V" is not defined, "$(origin V)" returns "undefined". "ifdev V" is redundant.

Signed-off-by Masahiro Yamada <[email protected]>

---

 Makefile | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
Makefile +2 -4
index d6426b3..9db52a8 100644
@@ -184,10 +184,8 @@ endif
 
 # To put more focus on warnings, be less verbose as default
 # Use 'make V=1' to see the full commands
-ifdef V
-  ifeq ("$(origin V)", "command line")
-    KBUILD_VERBOSE = $(V)
-  endif
+ifeq ("$(origin V)", "command line")
+  KBUILD_VERBOSE = $(V)
 endif
 ifndef KBUILD_VERBOSE
   KBUILD_VERBOSE = 0
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 Makefile: remove redundant ifdef V

Hi Masahiro Yamada,

Quoted 2 lines · Masahiro Yamada

If "V" is not defined, "$(origin V)" returns "undefined". "ifdev V" is redundant.

V is not defined in code but ...

Quoted 11 lines
Signed-off-by Masahiro Yamada <[email protected]>

---

 Makefile | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
Makefile +0 -0
index d6426b3..9db52a8 100644

Makefile endif · line 186

Quoted 3 lines
Makefile +0 -0
@@ -184,10 +184,8 @@ endif
 
 # To put more focus on warnings, be less verbose as default
 # Use 'make V=1' to see the full commands

... as this comment says, you can define V manually on the make invocation command line. That is its intended use.

Makefile endif · line 191

Quoted 9 lines
Makefile +2 -4
-ifdef V
-  ifeq ("$(origin V)", "command line")
-    KBUILD_VERBOSE = $(V)
-  endif
+ifeq ("$(origin V)", "command line")
+  KBUILD_VERBOSE = $(V)
 endif
 ifndef KBUILD_VERBOSE
   KBUILD_VERBOSE = 0

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
author
#2 lore raw

PATCH 1/1 Makefile: remove redundant ifdef V

Hi.

2015-04-07 13:19 GMT+09:00 Baruch Siach <[email protected]>:

Quoted 7 lines

Hi Masahiro Yamada,

Quoted 2 lines · Masahiro Yamada

If "V" is not defined, "$(origin V)" returns "undefined". "ifdev V" is redundant.

V is not defined in code but ...

Right.

V=1 is supposed to be passed from the command line,
like Linux, U-Boot, barebox, busybox and other projects that use Kbuild.

Quoted 12 lines
Quoted 12 lines
Signed-off-by Masahiro Yamada <[email protected]>

---

 Makefile | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
Makefile +0 -0
index d6426b3..9db52a8 100644
@@ -184,10 +184,8 @@ endif
Quoted 5 lines

Makefile endif · line 186

Quoted 2 lines
Makefile +0 -0
 # To put more focus on warnings, be less verbose as default
 # Use 'make V=1' to see the full commands

... as this comment says, you can define V manually on the make invocation command line. That is its intended use.

Right. I do understand this.

I am afraid you are misunderstanding my patch.

I recommend you to read the git-log of
commit b8b0618cf6fab3bd5b1da8c72f4b29847d81ac42 of Linux Kernel.

Signature · 2 lines
Best Regards
Masahiro Yamada
#3 lore raw

PATCH 1/1 Makefile: remove redundant ifdef V

Hi Masahiro Yamada,

Quoted 30 lines · Masahiro Yamada

2015-04-07 13:19 GMT+09:00 Baruch Siach <[email protected]>:

Quoted 5 lines · Masahiro Yamada
Quoted 2 lines

If "V" is not defined, "$(origin V)" returns "undefined". "ifdev V" is redundant.

V is not defined in code but ...

Right.

V=1 is supposed to be passed from the command line,
like Linux, U-Boot, barebox, busybox and other projects that use Kbuild.

Quoted 12 lines
Quoted 12 lines
Signed-off-by Masahiro Yamada <[email protected]>

---

 Makefile | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
Makefile +0 -0
index d6426b3..9db52a8 100644
@@ -184,10 +184,8 @@ endif
Quoted 5 lines

Makefile endif · line 186

Quoted 2 lines
Makefile +0 -0
 # To put more focus on warnings, be less verbose as default
 # Use 'make V=1' to see the full commands

... as this comment says, you can define V manually on the make invocation command line. That is its intended use.

Quoted 7 lines

Right. I do understand this.

I am afraid you are misunderstanding my patch.

I recommend you to read the git-log of
commit b8b0618cf6fab3bd5b1da8c72f4b29847d81ac42 of Linux Kernel.

Thanks for the pointer. This is clearer now. Please update the commit log of your patch to include a more verbose explanation, like the kernel commit log you pointed.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -