Skip to contentSkip to conversation

commit reverted in staging/sm750fb

DISCUSSION Sudip Mukherjee 3 participants 8 messages Apr 7, 2015

lore
Share & tools
lore
#0 lore raw

Hi Greg,
I saw that you have reveretd one commit <6ad6b5ed3e2472b399b567a2f036006bf25df467>
"Staging: sm750fb: Fix C99 Comments" in staging/sm750fb.
I was trying to search for that patch, but it seems I am not able to find that in my personal mails nor in lkml. can you please let me know when it was sent..

And I must say sorry for missing a new file creation in a patch.

regards
sudip

#1 lore raw
Quoted 7 lines · Sudip Mukherjee

Hi Greg,
I saw that you have reveretd one commit <6ad6b5ed3e2472b399b567a2f036006bf25df467>
"Staging: sm750fb: Fix C99 Comments" in staging/sm750fb.
I was trying to search for that patch, but it seems I am not able to find that in my personal mails nor in lkml. can you please let me know when it was sent..

Just run 'git show 6ad6b5ed3e247' in linux-next and you can see such commit.

Regards,

Fabio Estevam

#2 lore raw
Quoted 11 lines · Fabio Estevam
Quoted 7 lines · Sudip Mukherjee

Hi Greg,
I saw that you have reveretd one commit <6ad6b5ed3e2472b399b567a2f036006bf25df467>
"Staging: sm750fb: Fix C99 Comments" in staging/sm750fb.
I was trying to search for that patch, but it seems I am not able to find that in my personal mails nor in lkml. can you please let me know when it was sent..

Just run 'git show 6ad6b5ed3e247' in linux-next and you can see such commit.

I have already seen the patch. But being the maintainer of that driver i hold myself responsible for missing a new file creation in a patch. So i was trying to search for that patch in my mails and also in lkml, but i could not find it, so thought of mailing and asking. :(

regards
sudip

Quoted 4 lines

Regards,

Fabio Estevam

#3 lore raw
Quoted 5 lines · Sudip Mukherjee
Quoted 1 line

Just run 'git show 6ad6b5ed3e247' in linux-next and you can see such commit.

I have already seen the patch. But being the maintainer of that driver i hold myself responsible for missing a new file creation in a patch. So i was trying to search for that patch in my mails and also in lkml, but i could not find it, so thought of mailing and asking. :(

The problem with commit 6ad6b5ed3e247 is this hunk:

ret.ou new file +0 -0
new file mode 100644
index 0000000..e69de29

Regards,

Fabio Estevam

#4 lore raw

ret.ou

Quoted 14 lines · Fabio Estevam
Quoted 5 lines · Sudip Mukherjee
Quoted 1 line

Just run 'git show 6ad6b5ed3e247' in linux-next and you can see such commit.

I have already seen the patch. But being the maintainer of that driver i hold myself responsible for missing a new file creation in a patch. So i was trying to search for that patch in my mails and also in lkml, but i could not find it, so thought of mailing and asking. :(

The problem with commit 6ad6b5ed3e247 is this hunk:

ret.ou new file +0 -0
new file mode 100644
index 0000000..e69de29

that also I have seen.but what I am trying to say is that I am not finding any reference of that patch in my mails or in lkml.org,

regards
sudip

Quoted 4 lines

Regards,

Fabio Estevam

#5 lore raw
In reply to Sudip Mukherjee
Quoted 7 lines · Sudip Mukherjee

Hi Greg,
I saw that you have reveretd one commit <6ad6b5ed3e2472b399b567a2f036006bf25df467>
"Staging: sm750fb: Fix C99 Comments" in staging/sm750fb.
I was trying to search for that patch, but it seems I am not able to find that in my personal mails nor in lkml. can you please let me know when it was sent..

It came in through the Outreachy mailing list, as part of the intern application process. Sorry about the extra file, I missed it, it was my fault.

thanks,

greg k-h

#6 lore raw
Quoted 9 lines · Greg KH
Quoted 7 lines · Sudip Mukherjee

Hi Greg,
I saw that you have reveretd one commit <6ad6b5ed3e2472b399b567a2f036006bf25df467>
"Staging: sm750fb: Fix C99 Comments" in staging/sm750fb.
I was trying to search for that patch, but it seems I am not able to find that in my personal mails nor in lkml. can you please let me know when it was sent..

Quoted 3 lines

It came in through the Outreachy mailing list, as part of the intern application process. Sorry about the extra file, I missed it, it was my fault.

can i, in any way, help in the Outreachy?

regards
sudip

Quoted 4 lines

thanks,

greg k-h

#7 lore raw
Quoted 10 lines · Sudip Mukherjee
Quoted 9 lines · Greg KH
Quoted 7 lines · Sudip Mukherjee

Hi Greg,
I saw that you have reveretd one commit <6ad6b5ed3e2472b399b567a2f036006bf25df467>
"Staging: sm750fb: Fix C99 Comments" in staging/sm750fb.
I was trying to search for that patch, but it seems I am not able to find that in my personal mails nor in lkml. can you please let me know when it was sent..

Quoted 4 lines
Quoted 3 lines

It came in through the Outreachy mailing list, as part of the intern application process. Sorry about the extra file, I missed it, it was my fault.

can i, in any way, help in the Outreachy?

The application process is all over now, so thanks for the offer. Next round of applications will happen in 6 months, and we can always use review help for the patches that come in. Just let me know then and I'll be glad to point you at the proper lists.

thanks,

greg k-h