Skip to contentSkip to conversation

ebtables-compat: fix misplaced function attribute on ebt_print_error()

PATCH Applied Arturo Borrero Gonzalez 2 participants 2 messages Apr 6, 2015 – Apr 8, 2015 netfilter

lore
Share & tools
lore

Arturo Borrero Gonzalez

author
#0 lore raw

PATCH 1/1 ebtables-compat: fix misplaced function attribute on ebt_print_error()

From: Arturo Borrero Gonzalez <[email protected]>

xtables-eb.c:305:1: warning: empty declaration
} __attribute__((noreturn, format(printf,2,3)));
^
xtables-eb.c:311:2: warning: initialization makes '__attribute__((noreturn))' qualified function pointer from unqualified
.exit_err = ebt_print_error,
^

Signed-off-by Arturo Borrero Gonzalez <[email protected]>
---
 iptables/xtables-eb.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
iptables/xtables-eb.c +2 -2
index ddef14a..c8b5d4f 100644
@@ -292,7 +292,7 @@ static struct option ebt_original_options[] =
 	{ 0 }
 };
 
-static void
+static void __attribute__((__noreturn__,format(printf,2,3)))
 ebt_print_error(enum xtables_exittype status, const char *format, ...)
 {
 	va_list l;

@@ -302,7 +302,7 @@ ebt_print_error(enum xtables_exittype status, const char *format, ...)
 	fprintf(stderr, ".\n");
 	va_end(l);
 	exit(-1);
-} __attribute__((noreturn, format(printf,2,3)));
+}
 
 struct xtables_globals ebtables_globals = {
 	.option_offset 		= 0,
maintainer Applied
#1 lore raw
Quoted 8 lines · Arturo Borrero Gonzalez

From: Arturo Borrero Gonzalez <[email protected]>

xtables-eb.c:305:1: warning: empty declaration
} __attribute__((noreturn, format(printf,2,3)));
^
xtables-eb.c:311:2: warning: initialization makes '__attribute__((noreturn))' qualified function pointer from unqualified
.exit_err = ebt_print_error,
^

Applied, thanks Arturo.