ARM: zynq: disable CONFIG_SYS_MALLOC_F to fix MMC boot

PATCH Superseded Masahiro Yamada 4 participants 7 messages Apr 8, 2015 – Apr 9, 2015 Arm/Zynq architecture

Share & tools

Masahiro Yamada

author

2015-04-08 05:25 UTC #0 lore raw

PATCH v2 1/1 ARM: zynq: disable CONFIG_SYS_MALLOC_F to fix MMC boot

Since commit 326a682358c1 (malloc_f: enable SYS_MALLOC_F by default if DM is on), Zynq MMC boot hangs up after printing the following:

    U-Boot SPL 2015.04-rc5-00053-gadcc570 (Apr 08 2015 - 12:59:11)
    mmc boot
    reading system.dtb

Prior to commit 326a682358c1, Zynq boards enabled CONFIG_DM, but not CONFIG_SYS_MALLOC_F. That commit forcibly turned on CONFIG_SYS_MALLOC_F. I have not figured out the root cause, but anyway it looks like CONFIG_SYS_MALLOC_F gave a bad impact on the Zynq MMC boot.

We are planning to have the v2015.04 release in a few days. I know this is a defensive fixup, but what I can do now is to add
# CONFIG_SYS_MALLOC_F is not set
to every Zynq defconfig file to get back the original behavior.

Tested on:
- Zedboard
- ZC706 board

Signed-off-by Masahiro Yamada <[email protected]>

Cc Michal Simek <[email protected]>

Cc Simon Glass <[email protected]>

---

This problem is urgent!

If we cannot find the better solution, please apply this patch by the v2015.04 release.
^^^^^^^^^^^^^^^^^^^^^^^

Changes in v2:
- Fix the commit subject. s/CONFIG_SYS_MALLOC_F_LEN/CONFIG_SYS_MALLOC_F/

 configs/zynq_microzed_defconfig    | 1 +
 configs/zynq_zc70x_defconfig       | 1 +
 configs/zynq_zc770_xm010_defconfig | 1 +
 configs/zynq_zc770_xm012_defconfig | 1 +
 configs/zynq_zc770_xm013_defconfig | 1 +
 configs/zynq_zed_defconfig         | 1 +
 configs/zynq_zybo_defconfig        | 1 +
 7 files changed, 7 insertions(+)

configs/zynq_microzed_defconfig +1 -0

index 39a7f6b..b6bca82 100644
@@ -3,6 +3,7 @@ CONFIG_ARM=y
 CONFIG_ZYNQ=y
 CONFIG_TARGET_ZYNQ_MICROZED=y
 CONFIG_OF_CONTROL=y
+# CONFIG_SYS_MALLOC_F is not set
 CONFIG_FIT=y
 CONFIG_FIT_VERBOSE=y
 CONFIG_FIT_SIGNATURE=y

configs/zynq_zc70x_defconfig +1 -0

index a8ef97f..44f3ae0 100644
@@ -4,6 +4,7 @@ CONFIG_ZYNQ=y
 CONFIG_TARGET_ZYNQ_ZC70X=y
 CONFIG_OF_CONTROL=y
 CONFIG_DEFAULT_DEVICE_TREE="zynq-zc702"
+# CONFIG_SYS_MALLOC_F is not set
 CONFIG_FIT=y
 CONFIG_FIT_VERBOSE=y
 CONFIG_FIT_SIGNATURE=y

configs/zynq_zc770_xm010_defconfig +1 -0

index ecd245a..d689857 100644
@@ -5,6 +5,7 @@ CONFIG_ZYNQ=y
 CONFIG_TARGET_ZYNQ_ZC770=y
 CONFIG_OF_CONTROL=y
 CONFIG_DEFAULT_DEVICE_TREE="zynq-zc770-xm010"
+# CONFIG_SYS_MALLOC_F is not set
 CONFIG_FIT=y
 CONFIG_FIT_VERBOSE=y
 CONFIG_FIT_SIGNATURE=y

configs/zynq_zc770_xm012_defconfig +1 -0

index 341a4d8..9745d21 100644
@@ -5,6 +5,7 @@ CONFIG_ZYNQ=y
 CONFIG_TARGET_ZYNQ_ZC770=y
 CONFIG_OF_CONTROL=y
 CONFIG_DEFAULT_DEVICE_TREE="zynq-zc770-xm012"
+# CONFIG_SYS_MALLOC_F is not set
 CONFIG_FIT=y
 CONFIG_FIT_VERBOSE=y
 CONFIG_FIT_SIGNATURE=y

configs/zynq_zc770_xm013_defconfig +1 -0

index ee08a9f..924efb4 100644
@@ -5,6 +5,7 @@ CONFIG_ZYNQ=y
 CONFIG_TARGET_ZYNQ_ZC770=y
 CONFIG_OF_CONTROL=y
 CONFIG_DEFAULT_DEVICE_TREE="zynq-zc770-xm013"
+# CONFIG_SYS_MALLOC_F is not set
 CONFIG_FIT=y
 CONFIG_FIT_VERBOSE=y
 CONFIG_FIT_SIGNATURE=y

configs/zynq_zed_defconfig +1 -0

index 2500d84..01fa723 100644
@@ -4,6 +4,7 @@ CONFIG_ZYNQ=y
 CONFIG_TARGET_ZYNQ_ZED=y
 CONFIG_OF_CONTROL=y
 CONFIG_DEFAULT_DEVICE_TREE="zynq-zed"
+# CONFIG_SYS_MALLOC_F is not set
 CONFIG_FIT=y
 CONFIG_FIT_VERBOSE=y
 CONFIG_FIT_SIGNATURE=y

configs/zynq_zybo_defconfig +1 -0

index c9d0121..f1001f1 100644
@@ -4,6 +4,7 @@ CONFIG_ZYNQ=y
 CONFIG_TARGET_ZYNQ_ZYBO=y
 CONFIG_OF_CONTROL=y
 CONFIG_DEFAULT_DEVICE_TREE="zynq-zybo"
+# CONFIG_SYS_MALLOC_F is not set
 CONFIG_FIT=y
 CONFIG_FIT_VERBOSE=y
 CONFIG_FIT_SIGNATURE=y

Signature · 1 line

1.9.1

Michal Simek

2015-04-08 08:03 UTC #1 lore raw

PATCH v2 1/1 ARM: zynq: disable CONFIG_SYS_MALLOC_F to fix MMC boot

Quoted 25 lines · Masahiro Yamada

Since commit 326a682358c1 (malloc_f: enable SYS_MALLOC_F by default if DM is on), Zynq MMC boot hangs up after printing the following:
    U-Boot SPL 2015.04-rc5-00053-gadcc570 (Apr 08 2015 - 12:59:11)
    mmc boot
    reading system.dtb
Prior to commit 326a682358c1, Zynq boards enabled CONFIG_DM, but not CONFIG_SYS_MALLOC_F. That commit forcibly turned on CONFIG_SYS_MALLOC_F. I have not figured out the root cause, but anyway it looks like CONFIG_SYS_MALLOC_F gave a bad impact on the Zynq MMC boot.
We are planning to have the v2015.04 release in a few days. I know this is a defensive fixup, but what I can do now is to add
# CONFIG_SYS_MALLOC_F is not set
to every Zynq defconfig file to get back the original behavior.
Tested on:
- Zedboard
- ZC706 board
Signed-off-by Masahiro Yamada <[email protected]>
Cc Michal Simek <[email protected]>
Cc Simon Glass <[email protected]>

Quoted 7 lines

---
This problem is urgent!
If we cannot find the better solution, please apply this patch by the v2015.04 release.
^^^^^^^^^^^^^^^^^^^^^^^

Tested-by Michal Simek <[email protected]>

Tom: Can you please add it to your tree?

Thanks,
Michal

Simon Glass

2015-04-08 12:30 UTC #2 lore raw

PATCH v2 1/1 ARM: zynq: disable CONFIG_SYS_MALLOC_F to fix MMC boot

Hi,

Quoted 30 lines · Michal Simek

Quoted 29 lines · Masahiro Yamada
Since commit 326a682358c1 (malloc_f: enable SYS_MALLOC_F by default if DM is on), Zynq MMC boot hangs up after printing the following:
    U-Boot SPL 2015.04-rc5-00053-gadcc570 (Apr 08 2015 - 12:59:11)
    mmc boot
    reading system.dtb
Prior to commit 326a682358c1, Zynq boards enabled CONFIG_DM, but not CONFIG_SYS_MALLOC_F. That commit forcibly turned on CONFIG_SYS_MALLOC_F. I have not figured out the root cause, but anyway it looks like CONFIG_SYS_MALLOC_F gave a bad impact on the Zynq MMC boot.
We are planning to have the v2015.04 release in a few days. I know this is a defensive fixup, but what I can do now is to add
# CONFIG_SYS_MALLOC_F is not set
to every Zynq defconfig file to get back the original behavior.
Tested on:
- Zedboard
- ZC706 board
Signed-off-by Masahiro Yamada <[email protected]>
Cc Michal Simek <[email protected]>
Cc Simon Glass <[email protected]>
---
This problem is urgent!

Quoted 7 lines

Quoted 3 lines
If we cannot find the better solution, please apply this patch by the v2015.04 release.
^^^^^^^^^^^^^^^^^^^^^^^
Tested-by Michal Simek <[email protected]>
Tom: Can you please add it to your tree?

That's fine, although if we can wait a few days we might figure out the root cause. See the other thread for context.

Regards,
Simon

Tom Rini

2015-04-08 14:04 UTC #3 lore raw

PATCH v2 1/1 ARM: zynq: disable CONFIG_SYS_MALLOC_F to fix MMC boot

In reply to Michal Simek

Quoted 30 lines · Michal Simek

Quoted 29 lines · Masahiro Yamada
Since commit 326a682358c1 (malloc_f: enable SYS_MALLOC_F by default if DM is on), Zynq MMC boot hangs up after printing the following:
    U-Boot SPL 2015.04-rc5-00053-gadcc570 (Apr 08 2015 - 12:59:11)
    mmc boot
    reading system.dtb
Prior to commit 326a682358c1, Zynq boards enabled CONFIG_DM, but not CONFIG_SYS_MALLOC_F. That commit forcibly turned on CONFIG_SYS_MALLOC_F. I have not figured out the root cause, but anyway it looks like CONFIG_SYS_MALLOC_F gave a bad impact on the Zynq MMC boot.
We are planning to have the v2015.04 release in a few days. I know this is a defensive fixup, but what I can do now is to add
# CONFIG_SYS_MALLOC_F is not set
to every Zynq defconfig file to get back the original behavior.
Tested on:
- Zedboard
- ZC706 board
Signed-off-by Masahiro Yamada <[email protected]>
Cc Michal Simek <[email protected]>
Cc Simon Glass <[email protected]>
---
This problem is urgent!

Quoted 7 lines

Quoted 3 lines
If we cannot find the better solution, please apply this patch by the v2015.04 release.
^^^^^^^^^^^^^^^^^^^^^^^
Tested-by Michal Simek <[email protected]>
Tom: Can you please add it to your tree?

Do you want to do a PR with this (or wait a bit for Simon and Masahiro to root-cause) and your maintainers update or should I just grab that directly too? Thanks!

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150408/dba4d090/attachment.sig>

Michal Simek

2015-04-08 17:59 UTC #4 lore raw

PATCH v2 1/1 ARM: zynq: disable CONFIG_SYS_MALLOC_F to fix MMC boot

Quoted 35 lines · Tom Rini

Quoted 34 lines · Michal Simek
Quoted 32 lines · Masahiro Yamada
Since commit 326a682358c1 (malloc_f: enable SYS_MALLOC_F by default if DM is on), Zynq MMC boot hangs up after printing the following:
    U-Boot SPL 2015.04-rc5-00053-gadcc570 (Apr 08 2015 - 12:59:11)
    mmc boot
    reading system.dtb
Prior to commit 326a682358c1, Zynq boards enabled CONFIG_DM, but not CONFIG_SYS_MALLOC_F. That commit forcibly turned on CONFIG_SYS_MALLOC_F. I have not figured out the root cause, but anyway it looks like CONFIG_SYS_MALLOC_F gave a bad impact on the Zynq MMC boot.
We are planning to have the v2015.04 release in a few days. I know this is a defensive fixup, but what I can do now is to add
# CONFIG_SYS_MALLOC_F is not set
to every Zynq defconfig file to get back the original behavior.
Tested on:
- Zedboard
- ZC706 board
Signed-off-by Masahiro Yamada <[email protected]>
Cc Michal Simek <[email protected]>
Cc Simon Glass <[email protected]>
---
This problem is urgent!
If we cannot find the better solution, please apply this patch by the v2015.04 release.
^^^^^^^^^^^^^^^^^^^^^^^

Quoted 7 lines

Quoted 3 lines
Tested-by Michal Simek <[email protected]>
Tom: Can you please add it to your tree?
Do you want to do a PR with this (or wait a bit for Simon and Masahiro to root-cause) and your maintainers update or should I just grab that directly too? Thanks!

Please grab both patches directly to your tree. When Simon or Masahiro find out root cause then we can simple revert it. This seems to be the best strategy for now.

Thanks,
Michal

Masahiro Yamada

author

2015-04-09 10:09 UTC #5 lore raw

PATCH v2 1/1 ARM: zynq: disable CONFIG_SYS_MALLOC_F to fix MMC boot

Hi Tom, Michal,

2015-04-09 2:59 GMT+09:00 Michal Simek <[email protected]>:

Quoted 40 lines · Tom Rini

Quoted 39 lines · Michal Simek
Quoted 37 lines · Masahiro Yamada
Quoted 25 lines
Since commit 326a682358c1 (malloc_f: enable SYS_MALLOC_F by default if DM is on), Zynq MMC boot hangs up after printing the following:
    U-Boot SPL 2015.04-rc5-00053-gadcc570 (Apr 08 2015 - 12:59:11)
    mmc boot
    reading system.dtb
Prior to commit 326a682358c1, Zynq boards enabled CONFIG_DM, but not CONFIG_SYS_MALLOC_F. That commit forcibly turned on CONFIG_SYS_MALLOC_F. I have not figured out the root cause, but anyway it looks like CONFIG_SYS_MALLOC_F gave a bad impact on the Zynq MMC boot.
We are planning to have the v2015.04 release in a few days. I know this is a defensive fixup, but what I can do now is to add
# CONFIG_SYS_MALLOC_F is not set
to every Zynq defconfig file to get back the original behavior.
Tested on:
- Zedboard
- ZC706 board
Signed-off-by Masahiro Yamada <[email protected]>
Cc Michal Simek <[email protected]>
Cc Simon Glass <[email protected]>
Quoted 7 lines
---
This problem is urgent!
If we cannot find the better solution, please apply this patch by the v2015.04 release.
^^^^^^^^^^^^^^^^^^^^^^^
Tested-by Michal Simek <[email protected]>
Tom: Can you please add it to your tree?

Quoted 7 lines

Quoted 3 lines
Do you want to do a PR with this (or wait a bit for Simon and Masahiro to root-cause) and your maintainers update or should I just grab that directly too? Thanks!
Please grab both patches directly to your tree. When Simon or Masahiro find out root cause then we can simple revert it. This seems to be the best strategy for now.

I agree.

Signature · 2 lines

Best Regards
Masahiro Yamada

Tom Rini

2015-04-09 11:37 UTC #6 lore raw

PATCH v2 1/1 ARM: zynq: disable CONFIG_SYS_MALLOC_F to fix MMC boot

In reply to Masahiro Yamada

Quoted 18 lines · Masahiro Yamada

Since commit 326a682358c1 (malloc_f: enable SYS_MALLOC_F by default if DM is on), Zynq MMC boot hangs up after printing the following:
    U-Boot SPL 2015.04-rc5-00053-gadcc570 (Apr 08 2015 - 12:59:11)
    mmc boot
    reading system.dtb
Prior to commit 326a682358c1, Zynq boards enabled CONFIG_DM, but not CONFIG_SYS_MALLOC_F. That commit forcibly turned on CONFIG_SYS_MALLOC_F. I have not figured out the root cause, but anyway it looks like CONFIG_SYS_MALLOC_F gave a bad impact on the Zynq MMC boot.
We are planning to have the v2015.04 release in a few days. I know this is a defensive fixup, but what I can do now is to add
# CONFIG_SYS_MALLOC_F is not set
to every Zynq defconfig file to get back the original behavior.

Quoted 7 lines

Tested on:
- Zedboard
- ZC706 board
Signed-off-by Masahiro Yamada <[email protected]>
Cc Michal Simek <[email protected]>
Cc Simon Glass <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150409/99f52c12/attachment.sig>