pkg-.mk: add comment about argument 1 of inner--package

PATCH Superseded Masahiro Yamada 2 participants 3 messages Apr 9, 2015 – Apr 10, 2015

lore

Share & tools

lore

Masahiro Yamada

author

2015-04-09 12:14 UTC #0 lore raw

PATCH v2 1/1 pkg-*.mk: add comment about argument 1 of inner-*-package

Signed-off-by Masahiro Yamada <[email protected]>

---

Changes in v2:
- Fix pkg-cmake.mk too

 package/pkg-autotools.mk | 3 ++-
 package/pkg-cmake.mk     | 3 ++-
 package/pkg-generic.mk   | 3 ++-
 package/pkg-kconfig.mk   | 3 ++-
 package/pkg-luarocks.mk  | 3 ++-
 package/pkg-perl.mk      | 3 ++-
 package/pkg-python.mk    | 3 ++-
 package/pkg-rebar.mk     | 3 ++-
 package/pkg-virtual.mk   | 3 ++-
 9 files changed, 18 insertions(+), 9 deletions(-)

package/pkg-autotools.mk +2 -1

index 2ecf7d8..d094023 100644
@@ -101,7 +101,8 @@ endef
 # calls the generic package infrastructure to generate the necessary
 # make targets
 #
-#  argument 1 is the lowercase package name
+#  argument 1 is the lowercase package name, including a host_ prefix
+#             for host packages
 #  argument 2 is the uppercase package name, including a HOST_ prefix
 #             for host packages
 #  argument 3 is the uppercase package name, without the HOST_ prefix

package/pkg-cmake.mk +2 -1

index 2262012..8497a7b 100644
@@ -41,7 +41,8 @@ endif
 # tune the build process and calls the generic package infrastructure to
 # generate the necessary make targets
 #
-#  argument 1 is the lowercase package name
+#  argument 1 is the lowercase package name, including a host_ prefix
+#             for host packages
 #  argument 2 is the uppercase package name, including a HOST_ prefix
 #             for host packages
 #  argument 3 is the uppercase package name, without the HOST_ prefix

package/pkg-generic.mk +2 -1

index f77aab2..d561dc0 100644
@@ -273,7 +273,8 @@ endef
 # inner-generic-package -- generates the make targets needed to build a
 # generic package
 #
-#  argument 1 is the lowercase package name
+#  argument 1 is the lowercase package name, including a host_ prefix
+#             for host packages
 #  argument 2 is the uppercase package name, including a HOST_ prefix
 #             for host packages
 #  argument 3 is the uppercase package name, without the HOST_ prefix

package/pkg-kconfig.mk +2 -1

index fd9f19d..32193b7 100644
@@ -15,7 +15,8 @@
 # inner-kconfig-package -- generates the make targets needed to support a
 # kconfig package
 #
-#  argument 1 is the lowercase package name
+#  argument 1 is the lowercase package name, including a host_ prefix
+#             for host packages
 #  argument 2 is the uppercase package name, including a HOST_ prefix
 #             for host packages
 #  argument 3 is the uppercase package name, without the HOST_ prefix

package/pkg-luarocks.mk +2 -1

index 83f338e..36c2883 100644
@@ -23,7 +23,8 @@
 # tune the build process and calls the generic package infrastructure to
 # generate the necessary make targets
 #
-#  argument 1 is the lowercase package name
+#  argument 1 is the lowercase package name, including a host_ prefix
+#             for host packages
 #  argument 2 is the uppercase package name, including a HOST_ prefix
 #             for host packages
 #  argument 3 is the uppercase package name, without the HOST_ prefix

package/pkg-perl.mk +2 -1

index 6577588..4c191b5 100644
@@ -29,7 +29,8 @@ PERL_RUN = PERL5LIB= $(HOST_DIR)/usr/bin/perl
 # calls the generic package infrastructure to generate the necessary
 # make targets
 #
-#  argument 1 is the lowercase package name
+#  argument 1 is the lowercase package name, including a host_ prefix
+#             for host packages
 #  argument 2 is the uppercase package name, including a HOST_ prefix
 #             for host packages
 #  argument 3 is the uppercase package name, without the HOST_ prefix

package/pkg-python.mk +2 -1

index 426301a..11c6d2e 100644
@@ -81,7 +81,8 @@ HOST_PKG_PYTHON_SETUPTOOLS_INSTALL_OPTS = \
 # few hooks to tune the build process and calls the generic package
 # infrastructure to generate the necessary make targets
 #
-#  argument 1 is the lowercase package name
+#  argument 1 is the lowercase package name, including a host_ prefix
+#             for host packages
 #  argument 2 is the uppercase package name, including a HOST_ prefix
 #             for host packages
 #  argument 3 is the uppercase package name, without the HOST_ prefix

package/pkg-rebar.mk +2 -1

index 75facd5..d7cc175 100644
@@ -101,7 +101,8 @@ endef
 # calls the generic package infrastructure to generate the necessary
 # make targets.
 #
-#  argument 1 is the lowercase package name
+#  argument 1 is the lowercase package name, including a host_ prefix
+#             for host packages
 #  argument 2 is the uppercase package name, including a HOST_ prefix
 #             for host packages
 #  argument 3 is the uppercase package name, without the HOST_ prefix

package/pkg-virtual.mk +2 -1

index 2889ef9..d6367d9 100644
@@ -18,7 +18,8 @@
 # inner-virtual-package -- defines the dependency rules of the virtual
 # package against its provider.
 #
-#  argument 1 is the lowercase package name
+#  argument 1 is the lowercase package name, including a host_ prefix
+#             for host packages
 #  argument 2 is the uppercase package name, including a HOST_ prefix
 #             for host packages
 #  argument 3 is the uppercase package name, without the HOST_ prefix

Signature · 1 line

1.9.1

Thomas Petazzoni

2015-04-09 12:32 UTC #1 lore raw

PATCH v2 1/1 pkg-*.mk: add comment about argument 1 of inner-*-package

Dear Masahiro Yamada,

package/pkg-autotools.mk endef · line 105

Quoted 3 lines · Masahiro Yamada

package/pkg-autotools.mk +2 -1

-#  argument 1 is the lowercase package name
+#  argument 1 is the lowercase package name, including a host_ prefix
+#             for host packages

The prefix is 'host-', not 'host_'. Though I'm not sure this comment is really that useful: host-foo is really the name of the package. Since there is no parameter containing the lower case package name without the 'host-' prefix, I don't think such an additional comment is really needed.

The comment is needed for argument 2 and 3, because they are indeed different in the fact that one has HOST_ and not the other one.

Best regards,

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Masahiro Yamada

author

2015-04-10 02:19 UTC #2 lore raw

PATCH v2 1/1 pkg-*.mk: add comment about argument 1 of inner-*-package

Hi Thomas,

2015-04-09 21:32 GMT+09:00 Thomas Petazzoni
<[email protected]>:

Quoted 14 lines

Dear Masahiro Yamada,
package/pkg-autotools.mk endef · line 105
Quoted 3 lines · Masahiro Yamada
package/pkg-autotools.mk +2 -1
-#  argument 1 is the lowercase package name
+#  argument 1 is the lowercase package name, including a host_ prefix
+#             for host packages
The prefix is 'host-', not 'host_'. Though I'm not sure this comment is really that useful: host-foo is really the name of the package. Since there is no parameter containing the lower case package name without the 'host-' prefix, I don't think such an additional comment is really needed.

Quoted 4 lines

The comment is needed for argument 2 and 3, because they are indeed different in the fact that one has HOST_ and not the other one.
Best regards,

OK, thanks for explaining this!

Signature · 2 lines

Best Regards
Masahiro Yamada