Skip to contentSkip to conversation

linux: fix fbtft kernel extension

PATCH New Peter Seiderer 2 participants 4 messages Jan 11, 2015 – Apr 9, 2015

lore
Share & tools
lore

Peter Seiderer

author
#0 lore raw

PATCH 1/1 linux: fix fbtft kernel extension

Fixes fbtft kernel extension bug reported by Richard Fergusson ([1]):

drivers/video/Kconfig:2525: can't open file
"drivers/video/fbdev/fbtft/Kconfig"

Fix: write the right fbtft/KConfig path to video/Kconfig or video/fbdev/Kconfig (instead of hard coded one)

[1] http://lists.busybox.net/pipermail/buildroot/2015-January/117057.html

Reported-by Richard Fergusson <[email protected]>
Signed-off-by Peter Seiderer <[email protected]>
---
 linux/linux-ext-fbtft.mk | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
linux/linux-ext-fbtft.mk +7 -7
index 36f4fd2..71ebdf3 100644
@@ -12,15 +12,15 @@ LINUX_DEPENDENCIES += fbtft
 # for linux < 3.15 install to drivers/video/fbtft
 define FBTFT_PREPARE_KERNEL
 	if [ -e $(LINUX_DIR)/drivers/video/fbdev ]; then \
-		dest=$(LINUX_DIR)/drivers/video/fbdev ; \
+		dest=drivers/video/fbdev ; \
 	else \
-		dest=$(LINUX_DIR)/drivers/video/ ; \
+		dest=drivers/video ; \
 	fi ; \
-	mkdir -p $${dest}/fbtft; \
-	cp -dpfr $(FBTFT_DIR)/* $${dest}/fbtft/ ; \
-	echo 'source "drivers/video/fbdev/fbtft/Kconfig"' \
-		>> $${dest}/Kconfig ; \
-	echo 'obj-y += fbtft/' >> $${dest}/Makefile
+	mkdir -p $(LINUX_DIR)/$${dest}/fbtft; \
+	cp -dpfr $(FBTFT_DIR)/* $(LINUX_DIR)/$${dest}/fbtft/ ; \
+	echo "source \"$${dest}/fbtft/Kconfig\"" \
+		>> $(LINUX_DIR)/$${dest}/Kconfig ; \
+	echo 'obj-y += fbtft/' >> $(LINUX_DIR)/$${dest}/Makefile
 endef
 
 LINUX_PRE_PATCH_HOOKS += FBTFT_PREPARE_KERNEL
Signature · 1 line
2.1.2
#1 lore raw

PATCH 1/1 linux: fix fbtft kernel extension

Dear Peter Seiderer,

Quoted 5 lines · Peter Seiderer

Fixes fbtft kernel extension bug reported by Richard Fergusson ([1]):

drivers/video/Kconfig:2525: can't open file
"drivers/video/fbdev/fbtft/Kconfig"

Quoted 7 lines

Fix: write the right fbtft/KConfig path to video/Kconfig or video/fbdev/Kconfig (instead of hard coded one)

[1] http://lists.busybox.net/pipermail/buildroot/2015-January/117057.html

Reported-by Richard Fergusson <[email protected]>
Signed-off-by Peter Seiderer <[email protected]>

I only had a quick look, but I don't really see the relationship between the bug report and this fix. Could you elaborate a bit?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#2 lore raw

PATCH 1/1 linux: fix fbtft kernel extension

Hello Thomas,

Quoted 17 lines

Gesendet: Sonntag, 11. Januar 2015 um 19:48 Uhr
Von: "Thomas Petazzoni" <[email protected]>
An: "Peter Seiderer" <[email protected]>
Cc: buildroot at busybox.net, "Richard Fergusson" <[email protected]>
Betreff: Re: [PATCH] linux: fix fbtft kernel extension

Dear Peter Seiderer,

Quoted 8 lines · Peter Seiderer

Fixes fbtft kernel extension bug reported by Richard Fergusson ([1]):

drivers/video/Kconfig:2525: can't open file
"drivers/video/fbdev/fbtft/Kconfig"

Fix: write the right fbtft/KConfig path to video/Kconfig or video/fbdev/Kconfig (instead of hard coded one)

Quoted 8 lines
Quoted 4 lines

[1] http://lists.busybox.net/pipermail/buildroot/2015-January/117057.html

Reported-by Richard Fergusson <[email protected]>
Signed-off-by Peter Seiderer <[email protected]>

I only had a quick look, but I don't really see the relationship between the bug report and this fix. Could you elaborate a bit?

Without this patch (and raspberrypi_defconfig and BR2_LINUX_KERNEL_EXT_FBTFT=y) a wrong path is added to drivers/video/Kconfig

$ tail -2 build/linux-c256eb9968c8997dce47350d2075e42f1b3991d3/drivers/video/Kconfig 
endmenu
source "drivers/video/fbdev/fbtft/Kconfig"
$ ls build/linux-c256eb9968c8997dce47350d2075e42f1b3991d3/drivers/video/fbtft/Kconfig 
build/linux-c256eb9968c8997dce47350d2075e42f1b3991d3/drivers/video/fbtft/Kconfig

The patch changes the wrong addition 'source "drivers/video/fbdev/fbtft/Kconfig"' to the right 'source "drivers/video/fbtft/Kconfig"' in case linux < 3.15...

Hope this explenation is better?

Regards,
Peter

Quoted 8 lines

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
Applied
#3 lore raw

PATCH 1/1 linux: fix fbtft kernel extension

In reply to Peter Seiderer

Dear Peter Seiderer,

Quoted 5 lines · Peter Seiderer

Fixes fbtft kernel extension bug reported by Richard Fergusson ([1]):

drivers/video/Kconfig:2525: can't open file
"drivers/video/fbdev/fbtft/Kconfig"

Quoted 7 lines

Fix: write the right fbtft/KConfig path to video/Kconfig or video/fbdev/Kconfig (instead of hard coded one)

[1] http://lists.busybox.net/pipermail/buildroot/2015-January/117057.html

Reported-by Richard Fergusson <[email protected]>
Signed-off-by Peter Seiderer <[email protected]>

Applied, thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com