Skip to contentSkip to conversation

fftw: fix build failure with old gcc

PATCH New Gwenhael Goavec-Merou 3 participants 3 messages Apr 11, 2015

lore
Share & tools
lore

Gwenhael Goavec-Merou

author
#0 lore raw

PATCH 1/1 fftw: fix build failure with old gcc

From: Gwenhael Goavec-Merou <[email protected]>

-Ofast is not available on gcc <2.6. This option is equivalent to -O3 -ffast-math.

Fixes:
http://autobuild.buildroot.org/results/207/207a20a3ca5e62029823b1361479d5cd38fefeb0/
http://autobuild.buildroot.net/results/871/871b29c9bbf94aa05034c442f35c8771f83abe1e/

Signed-off-by Gwenhael Goavec-Merou <[email protected]>
Signed-off-by Yann E. MORIN <[email protected]>
---
 package/fftw/fftw.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/fftw/fftw.mk +1 -1
index 1148909..5045ab6 100644
@@ -18,7 +18,7 @@ FFTW_CONF_OPTS += $(if $(BR2_PACKAGE_FFTW_PRECISION_QUAD),--enable,--disable)-qu
 
 FFTW_CFLAGS = $(TARGET_CFLAGS)
 ifeq ($(BR2_PACKAGE_FFTW_FAST),y)
-FFTW_CFLAGS += -Ofast
+FFTW_CFLAGS += -O3 -ffast-math
 endif
 
 # x86 optimisations
Signature · 1 line
2.0.5
#1 lore raw

PATCH 1/1 fftw: fix build failure with old gcc

Gwenhael, All,

On 2015-04-11 12:41 +0200, Gwenhael Goavec-Merou spake thusly:

Quoted 3 lines

From: Gwenhael Goavec-Merou <[email protected]>

-Ofast is not available on gcc <2.6. This option is equivalent to

You probably meant gcc<4.6 ? gcc-2.6 is, well, quite old... The latest 2.6.x was released in 2002... ;-)

Quoted 8 lines

-O3 -ffast-math.

Fixes:
http://autobuild.buildroot.org/results/207/207a20a3ca5e62029823b1361479d5cd38fefeb0/
http://autobuild.buildroot.net/results/871/871b29c9bbf94aa05034c442f35c8771f83abe1e/

Signed-off-by Gwenhael Goavec-Merou <[email protected]>
Signed-off-by Yann E. MORIN <[email protected]>

Otherwise, I did not SoB this patch for real. A post-commit note would have been quite enough, in fact.

Regards,
Yann E. MORIN.

Quoted 20 lines
---
 package/fftw/fftw.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/fftw/fftw.mk +1 -1
index 1148909..5045ab6 100644
@@ -18,7 +18,7 @@ FFTW_CONF_OPTS += $(if $(BR2_PACKAGE_FFTW_PRECISION_QUAD),--enable,--disable)-qu
 
 FFTW_CFLAGS = $(TARGET_CFLAGS)
 ifeq ($(BR2_PACKAGE_FFTW_FAST),y)
-FFTW_CFLAGS += -Ofast
+FFTW_CFLAGS += -O3 -ffast-math
 endif
 
 # x86 optimisations
Signature · 1 line
2.0.5
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 fftw: fix build failure with old gcc

In reply to Gwenhael Goavec-Merou

Dear Gwenhael Goavec-Merou,

Quoted 9 lines · Gwenhael Goavec-Merou

From: Gwenhael Goavec-Merou <[email protected]>

(quoted diff) +0 -2
-Ofast is not available on gcc <2.6. This option is equivalent to 
-O3 -ffast-math.

Fixes:
http://autobuild.buildroot.org/results/207/207a20a3ca5e62029823b1361479d5cd38fefeb0/
http://autobuild.buildroot.net/results/871/871b29c9bbf94aa05034c442f35c8771f83abe1e/

Quoted 5 lines
Signed-off-by Gwenhael Goavec-Merou <[email protected]>
Signed-off-by Yann E. MORIN <[email protected]>
---
 package/fftw/fftw.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

I've removed Yann SoB, and fixed s/2.6/4.6/ in the commit log, and applied.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com