xserver_xorg-server: Change default to X.org modular server
PATCH v2 1/1 xserver_xorg-server: Change default to X.org modular server
---
v2: Change default for all toolchain configurations (Thomas)
package/x11r7/xserver_xorg-server/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/x11r7/xserver_xorg-server/Config.in +1 -1
@@ -58,7 +58,7 @@ if BR2_PACKAGE_XSERVER_XORG_SERVER choice prompt "X Window System server type" - default BR2_PACKAGE_XSERVER_XORG_SERVER_KDRIVE + default BR2_PACKAGE_XSERVER_XORG_SERVER_MODULAR help Select the X Window System server to use
Signature · 1 line
1.7.10.4
PATCH v2 1/1 xserver_xorg-server: Change default to X.org modular server
Dear Bernd Kuhls,
Quoted 4 lines · Bernd Kuhls
Signed-off-by Bernd Kuhls <[email protected]>---
v2: Change default for all toolchain configurations (Thomas)
Well, it's not actually changing the default for all toolchain configurations, since the modular X.org variant requires C++ support, while the KDrive variant does not.
However, probably this doesn't matter. On such a change, I'd like to have a Acked-by from a few other Buildroot developers. Yann, Arnout, Gustavo, what do you think?
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH v2 1/1 xserver_xorg-server: Change default to X.org modular server
Thomas, Bernd, All,
On 2015-04-11 19:58 +0200, Thomas Petazzoni spake thusly:
Quoted 6 lines · Bernd Kuhls
Quoted 4 lines
Signed-off-by Bernd Kuhls <[email protected]>---
v2: Change default for all toolchain configurations (Thomas)
Quoted 7 lines
Well, it's not actually changing the default for all toolchain configurations, since the modular X.org variant requires C++ support, while the KDrive variant does not.
However, probably this doesn't matter. On such a change, I'd like to have a Acked-by from a few other Buildroot developers. Yann, Arnout, Gustavo, what do you think?
I would not mind much doing the switch to the modular Xserver by default. But that would mean proper dependency propagation (i.e. C++).
However, an alternative solution would be to remove the 'default' clause altogether from the choice:
- if C++ is available, the modular Xserver is enabled by default,
being the first option in the choice;
- if C++ is not enabled, then KDrive is enabled, being the only option in the choice.
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH v2 1/1 xserver_xorg-server: Change default to X.org modular server
Dear Yann E. MORIN,
Quoted 2 lines · Yann E. MORIN
I would not mind much doing the switch to the modular Xserver by default. But that would mean proper dependency propagation (i.e. C++).
I don't understand what you mean here.
Quoted 8 lines
However, an alternative solution would be to remove the 'default' clause altogether from the choice:
- if C++ is available, the modular Xserver is enabled by default,
being the first option in the choice;- if C++ is not enabled, then KDrive is enabled, being the only option in the choice.
Well, Bernd's patch is doing that in a perfectly fine way. If C++ is available, the default on modular will work. If C++ is not available, since the modular option will not be available, the only remaining option in the choice will be Kdrive, and it will be the selected option.
Am I missing something?
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH v2 1/1 xserver_xorg-server: Change default to X.org modular server
Thomas, All,
On 2015-04-11 20:18 +0200, Thomas Petazzoni spake thusly:
Quoted 8 lines
Dear Yann E. MORIN,
Quoted 2 lines · Yann E. MORIN
I would not mind much doing the switch to the modular Xserver by default. But that would mean proper dependency propagation (i.e. C++).
I don't understand what you mean here.
See below...
Quoted 9 lines
Quoted 8 lines
However, an alternative solution would be to remove the 'default' clause altogether from the choice:
- if C++ is available, the modular Xserver is enabled by default,
being the first option in the choice;- if C++ is not enabled, then KDrive is enabled, being the only option in the choice.
Quoted 6 lines
Well, Bernd's patch is doing that in a perfectly fine way. If C++ is available, the default on modular will work. If C++ is not available, since the modular option will not be available, the only remaining option in the choice will be Kdrive, and it will be the selected option.
Am I missing something?
No, not really.
Even though 'default' in Kconfig is not authoritative, and that's not even a warning to default to an option that has unmet dependencies, I still find it odd to default to that option.
And since the default is defaulting to the first entry in the choice, it is no longer needed at all.
At best, we could add a comment summarising the situation.
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH v2 1/1 xserver_xorg-server: Change default to X.org modular server
Quoted 32 lines · Yann E. MORIN
Thomas, All,
On 2015-04-11 20:18 +0200, Thomas Petazzoni spake thusly:
Quoted 8 lines
Dear Yann E. MORIN,
Quoted 2 lines · Yann E. MORIN
I would not mind much doing the switch to the modular Xserver by default. But that would mean proper dependency propagation (i.e. C++).
I don't understand what you mean here.
See below...
Quoted 9 lines
Quoted 8 lines
However, an alternative solution would be to remove the 'default' clause altogether from the choice:
- if C++ is available, the modular Xserver is enabled by default,
being the first option in the choice;- if C++ is not enabled, then KDrive is enabled, being the only optionhttp://patchwork.ozlabs.org/patch/400833/ in the choice.
Quoted 6 lines
Well, Bernd's patch is doing that in a perfectly fine way. If C++ is available, the default on modular will work. If C++ is not available, since the modular option will not be available, the only remaining option in the choice will be Kdrive, and it will be the selected option.
Am I missing something?
No, not really.
Quoted 8 lines
Even though 'default' in
Kconfigis not authoritative, and that's not even a warning to default to an option that has unmet dependencies, I still find it odd to default to that option.And since the default is defaulting to the first entry in the choice, it is no longer needed at all.
At best, we could add a comment summarising the situation.
Then it's better to go for Bernd's original patch [1] because it explicitly
gives the different defaults for the different situations.
ThomasP's comment to that was that it is strange that a choice default depends
on the toolchain options. It makes sense to make a default depend on the arch options, because we consider that something that can't be controlled by the user, but changing the default based on toolchain options sounds a bit weird.
But of course, we already have a bunch of those, although it's not as explicit
as in [1]. E.g. the media backend of dvdrw-tools defaults to cdrkit if kernel-headers >= 3.0, else it defaults to xorriso; gpu-amd-bin-mx51 output defaults to X11 if X11 is selected, else it defaults to framebuffer.
So I'm in favour of going back to [1].
Regards,
Arnout
[1] http://patchwork.ozlabs.org/patch/400833/
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
PATCH v2 1/1 xserver_xorg-server: Change default to X.org modular server
In reply to Yann E. MORIN"Yann E. MORIN" <[email protected]> wrote in news:20150411181330.GL4221 at free.fr:
Quoted 2 lines
- if C++ is available, the modular Xserver is enabled by default,
being the first option in the choice;
Hi,
my original patch proposal included this
http://patchwork.ozlabs.org/patch/400833/
But is was nack?ed by Thomas ;)
Regards, Bernd