Skip to contentSkip to conversation

package/gdb: Add optional dependencies

PATCH Superseded Bernd Kuhls 2 participants 2 messages Apr 11, 2015 – Apr 12, 2015

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/gdb: Add optional dependencies

To allow reproducable builds add some optional dependencies

$ output/host/usr/bin/i586-buildroot-linux-uclibc-readelf -a output/target/usr/bin/gdb | grep NEEDED | sort
 0x00000001 (NEEDED)                     Shared library: [libc.so.0]
 0x00000001 (NEEDED)                     Shared library: [libdl.so.0]
 0x00000001 (NEEDED)                     Shared library: [libexpat.so.1]
 0x00000001 (NEEDED)                     Shared library: [libiconv.so.2]
 0x00000001 (NEEDED)                     Shared library: [libm.so.0]
 0x00000001 (NEEDED)                     Shared library: [libncurses.so.5]
 0x00000001 (NEEDED)                     Shared library: [libpthread.so.0]
 0x00000001 (NEEDED)                     Shared library: [libpython2.7.so.1.0]
 0x00000001 (NEEDED)                     Shared library: [libutil.so.0]
 0x00000001 (NEEDED)                     Shared library: [libz.so.1]
---
 package/gdb/gdb.mk |    5 +++++
 1 file changed, 5 insertions(+)
package/gdb/gdb.mk +5 -0
index 9818320..34f7b5c 100644
@@ -36,6 +36,11 @@ else
 GDB_DEPENDENCIES = ncurses
 endif
 
+GDB_DEPENDENCIES += \
+	$(if $(BR2_PACKAGE_EXPAT),expat) \
+	$(if $(BR2_PACKAGE_LIBICONV),libiconv) \
+	$(if $(BR2_PACKAGE_ZLIB),zlib)
+
 # For the host variant, we really want to build with XML support,
 # which is needed to read XML descriptions of target architectures. We
 # also need ncurses.
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 package/gdb: Add optional dependencies

Bernd, All,

On 2015-04-11 20:31 +0200, Bernd Kuhls spake thusly:

Quoted 24 lines

To allow reproducable builds add some optional dependencies

$ output/host/usr/bin/i586-buildroot-linux-uclibc-readelf -a output/target/usr/bin/gdb | grep NEEDED | sort
 0x00000001 (NEEDED)                     Shared library: [libc.so.0]
 0x00000001 (NEEDED)                     Shared library: [libdl.so.0]
 0x00000001 (NEEDED)                     Shared library: [libexpat.so.1]
 0x00000001 (NEEDED)                     Shared library: [libiconv.so.2]
 0x00000001 (NEEDED)                     Shared library: [libm.so.0]
 0x00000001 (NEEDED)                     Shared library: [libncurses.so.5]
 0x00000001 (NEEDED)                     Shared library: [libpthread.so.0]
 0x00000001 (NEEDED)                     Shared library: [libpython2.7.so.1.0]
 0x00000001 (NEEDED)                     Shared library: [libutil.so.0]
 0x00000001 (NEEDED)                     Shared library: [libz.so.1]
---
 package/gdb/gdb.mk |    5 +++++
 1 file changed, 5 insertions(+)
package/gdb/gdb.mk +0 -0
index 9818320..34f7b5c 100644

package/gdb/gdb.mk else · line 42

Quoted 7 lines
package/gdb/gdb.mk +4 -0
@@ -36,6 +36,11 @@ else
 GDB_DEPENDENCIES = ncurses
 endif
 
+GDB_DEPENDENCIES += \
+	$(if $(BR2_PACKAGE_EXPAT),expat) \
+	$(if $(BR2_PACKAGE_LIBICONV),libiconv) \
+	$(if $(BR2_PACKAGE_ZLIB),zlib)

Do we need those dependencies even when only gdbserver is built?

If not, move the dependencies into the if-block just above. If yes, add a comment about it.

Regards,
Yann E. MORIN.

Quoted 10 lines
package/gdb/gdb.mk +0 -0
 # For the host variant, we really want to build with XML support,
 # which is needed to read XML descriptions of target architectures. We
 # also need ncurses.
Signature · 6 lines
1.7.10.4

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'