Skip to contentSkip to conversation

Fix pointer cast for 32 bits arch

PATCH Superseded Peter Senna Tschudin 2 participants 2 messages Apr 12, 2015 – Apr 13, 2015 Staging

v3 of 6 Superseded Latest is v6 →

lore
Share & tools
lore

Peter Senna Tschudin

author
#0 lore raw

PATCH v3 1/1 Fix pointer cast for 32 bits arch

Sparse complains about casting void * to u64 on i386. Change the cast to resource_size_t.

Also update the type of the first argument of gf_write64() from unsigned long to resource_size_t.

Signed-off-by Peter Senna Tschudin <[email protected]>

---
Changes from V2:
- Fixed spelling of complains
- Updated commit message

Changes from V1:
- Updated commit message

Tested by compilation only. Compiled for x86 and x86_64.

 drivers/staging/goldfish/goldfish_nand.c | 3 ++-
 include/linux/goldfish.h                 | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)
drivers/staging/goldfish/goldfish_nand.c +2 -1
index d68f216..738fdc4 100644
@@ -87,7 +87,8 @@ static u32 goldfish_nand_cmd(struct mtd_info *mtd, enum nand_cmd cmd,
 		writel((u32)(addr >> 32), base + NAND_ADDR_HIGH);
 		writel((u32)addr, base + NAND_ADDR_LOW);
 		writel(len, base + NAND_TRANSFER_SIZE);
-		gf_write64((u64)ptr, base + NAND_DATA, base + NAND_DATA_HIGH);
+		gf_write64((resource_size_t)ptr, base + NAND_DATA,
+			   base + NAND_DATA_HIGH);
 		writel(cmd, base + NAND_COMMAND);
 		rv = readl(base + NAND_RESULT);
 	}
include/linux/goldfish.h +1 -1
index 569236e..494e943 100644
@@ -3,7 +3,7 @@
 
 /* Helpers for Goldfish virtual platform */
 
-static inline void gf_write64(unsigned long data,
+static inline void gf_write64(resource_size_t data,
 		void __iomem *portl, void __iomem *porth)
 {
 	writel((u32)data, portl);
Signature · 1 line
2.1.0
#1 lore raw

Greg, can you drop this one. I replied to the earlier thread.

regards,
dan carpenter