tracing: Increase stack skip on event trigger
PATCH 1/1 tracing: Increase stack skip on event trigger
When 'stacktrace' trigger is used for event tracing, it should skip 4 functions instead of 3. Otherwise it'll contain ftrace_raw_event_XXX like below:
# echo stacktrace > events/sched/sched_switch/trigger
# tail trace
=> rcu_gp_kthread
=> kthread
=> ret_from_fork
ksoftirqd/0-3 [000] d..3 53.343993: <stack trace>
=> ftrace_raw_event_sched_switch
=> __schedule
=> schedule
=> smpboot_thread_fn
=> kthread
=> ret_from_forkReported-by Minchan Kim <[email protected]>
Cc Tom Zanussi <[email protected]>
Signed-off-by Namhyung Kim <[email protected]>
--- kernel/trace/trace_events_trigger.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
kernel/trace/trace_events_trigger.c +3 -2
@@ -965,12 +965,13 @@ static __init int register_trigger_snapshot_cmd(void) { return 0; }#ifdef CONFIG_STACKTRACE /* -* Skip 3: +* Skip 4: * stacktrace_trigger() * event_triggers_post_call() +* ftrace_event_buffer_commit() * ftrace_raw_event_xxx() */ -#define STACK_SKIP 3 +#define STACK_SKIP 4static void stacktrace_trigger (struct event_trigger_data *data)
Signature · 1 line
2.3.3
Steven Rostedt
maintainerQuoted 17 lines · On Thu, 26 Mar 2015 09:39:23 +0900 Namhyung Kim <[email protected]> wrote:
When 'stacktrace' trigger is used for event tracing, it should skip 4 functions instead of 3. Otherwise it'll contain
ftrace_raw_event_XXXlike below:# echo stacktrace > events/sched/sched_switch/trigger # tail trace => rcu_gp_kthread => kthread => ret_from_fork ksoftirqd/0-3 [000] d..3 53.343993: <stack trace> => ftrace_raw_event_sched_switch => __schedule => schedule => smpboot_thread_fn => kthread => ret_from_fork
Quoted 4 lines
Reported-by Minchan Kim <[email protected]>Cc Tom Zanussi <[email protected]>Signed-off-by Namhyung Kim <[email protected]>---
Hmm, this breaks when frame pointers are not enabled.
I may come up with something though.
-- Steve