Skip to contentSkip to conversation

pkg-utils: update comments after renaming of package infra macros

PATCH New Thomas Petazzoni 2 participants 3 messages Apr 13, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pkg-utils: update comments after renaming of package infra macros

The package infrastructure macros have a long time ago been renamed from GENTARGETS, AUTOTARGETS to generic-package and autotools-package. However, one comment in pkg-utils.mk keeps a reference to these *TARGETS macros. This commit updates this comment to match the new name of these macros.

---
 package/pkg-utils.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/pkg-utils.mk +1 -1
index 7eddc47..5a385f8 100644
@@ -60,7 +60,7 @@ endef
 
 # Helper functions to determine the name of a package and its
 # directory from its makefile directory, using the $(MAKEFILE_LIST)
-# variable provided by make. This is used by the *TARGETS macros to
+# variable provided by make. This is used by the *-package macros to
 # automagically find where the package is located.
 pkgdir = $(dir $(lastword $(MAKEFILE_LIST)))
 pkgname = $(lastword $(subst /, ,$(pkgdir)))
Signature · 1 line
2.1.0
#1 lore raw

PATCH 1/1 pkg-utils: update comments after renaming of package infra macros

Thomas, All,

On 2015-04-13 11:53 +0200, Thomas Petazzoni spake thusly:

Quoted 7 lines

The package infrastructure macros have a long time ago been renamed from GENTARGETS, AUTOTARGETS to generic-package and autotools-package. However, one comment in pkg-utils.mk keeps a reference to these *TARGETS macros. This commit updates this comment to match the new name of these macros.

I was puzzled as to why I could still see 'TARGETS' even after your series was applied. This squashes that concenr of mine on your series. ;-)

Regards,
Yann E. MORIN.

Quoted 24 lines
---
 package/pkg-utils.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/pkg-utils.mk +1 -1
index 7eddc47..5a385f8 100644
@@ -60,7 +60,7 @@ endef
 
 # Helper functions to determine the name of a package and its
 # directory from its makefile directory, using the $(MAKEFILE_LIST)
-# variable provided by make. This is used by the *TARGETS macros to
+# variable provided by make. This is used by the *-package macros to
 # automagically find where the package is located.
 pkgdir = $(dir $(lastword $(MAKEFILE_LIST)))
 pkgname = $(lastword $(subst /, ,$(pkgdir)))
Signature · 6 lines
2.1.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
author Applied
#2 lore raw

PATCH 1/1 pkg-utils: update comments after renaming of package infra macros

In reply to Thomas Petazzoni

Hello,

Quoted 10 lines · Thomas Petazzoni

The package infrastructure macros have a long time ago been renamed from GENTARGETS, AUTOTARGETS to generic-package and autotools-package. However, one comment in pkg-utils.mk keeps a reference to these *TARGETS macros. This commit updates this comment to match the new name of these macros.

---
 package/pkg-utils.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com