ARM: dts: imx23-olinuxino: Fix dr_mode of usb0

PATCH New Stefan Wahren 5 participants 6 messages Apr 14, 2015 – Apr 27, 2015

Subsystems (2)

Device tree bindings Arm i.MX and Layerscape

lore

Share & tools

lore

Stefan Wahren

author

2015-04-14 20:37 UTC #0 lore raw

PATCH 1/1 ARM: dts: imx23-olinuxino: Fix dr_mode of usb0

The dr_mode of usb0 on imx233-olinuxino is left to default "otg". Since the green LED (GPIO2_1) on imx233-olinuxino is connected to the same pin as USB_OTG_ID it's possible to disable USB host by LED toggling:

echo 0 > /sys/class/leds/green/brightness

[ 1068.890000] ci_hdrc ci_hdrc.0: remove, state 1
[ 1068.890000] usb usb1: USB disconnect, device number 1
[ 1068.920000] usb 1-1: USB disconnect, device number 2
[ 1068.920000] usb 1-1.1: USB disconnect, device number 3
[ 1069.070000] usb 1-1.2: USB disconnect, device number 4
[ 1069.450000] ci_hdrc ci_hdrc.0: USB bus 1 deregistered
[ 1074.460000] ci_hdrc ci_hdrc.0: timeout waiting for 00000800 in 11

This patch fixes the issue by setting dr_mode to "host" in the dts file.

Reported-by Harald Geyer <[email protected]>

Signed-off-by Stefan Wahren <[email protected]>

---
 arch/arm/boot/dts/imx23-olinuxino.dts |    1 +
 1 file changed, 1 insertion(+)

arch/arm/boot/dts/imx23-olinuxino.dts +1 -0

index 7e6eef2..3b2d74d 100644
@@ -93,6 +93,7 @@
 
 	ahb at 80080000 {
 		usb0: usb at 80080000 {
+			dr_mode = "host";
 			vbus-supply = <&reg_usb0_vbus>;
 			status = "okay";
 		};

Signature · 1 line

1.7.9.5

Fabio Estevam

reviewer

2015-04-14 20:43 UTC #1 lore raw

PATCH 1/1 ARM: dts: imx23-olinuxino: Fix dr_mode of usb0

Quoted 13 lines · Stefan Wahren

The dr_mode of usb0 on imx233-olinuxino is left to default "otg". Since the green LED (GPIO2_1) on imx233-olinuxino is connected to the same pin as USB_OTG_ID it's possible to disable USB host by LED toggling:
echo 0 > /sys/class/leds/green/brightness
[ 1068.890000] ci_hdrc ci_hdrc.0: remove, state 1
[ 1068.890000] usb usb1: USB disconnect, device number 1
[ 1068.920000] usb 1-1: USB disconnect, device number 2
[ 1068.920000] usb 1-1.1: USB disconnect, device number 3
[ 1069.070000] usb 1-1.2: USB disconnect, device number 4
[ 1069.450000] ci_hdrc ci_hdrc.0: USB bus 1 deregistered
[ 1074.460000] ci_hdrc ci_hdrc.0: timeout waiting for 00000800 in 11

Quoted 4 lines

This patch fixes the issue by setting dr_mode to "host" in the dts file.
Reported-by Harald Geyer <[email protected]>
Signed-off-by Stefan Wahren <[email protected]>

Reviewed-by Fabio Estevam <[email protected]>

Thanks

Marek Vasut

2015-04-15 02:59 UTC #2 lore raw

PATCH 1/1 ARM: dts: imx23-olinuxino: Fix dr_mode of usb0

In reply to Stefan Wahren

Quoted 13 lines · Stefan Wahren

The dr_mode of usb0 on imx233-olinuxino is left to default "otg". Since the green LED (GPIO2_1) on imx233-olinuxino is connected to the same pin as USB_OTG_ID it's possible to disable USB host by LED toggling:
echo 0 > /sys/class/leds/green/brightness
[ 1068.890000] ci_hdrc ci_hdrc.0: remove, state 1
[ 1068.890000] usb usb1: USB disconnect, device number 1
[ 1068.920000] usb 1-1: USB disconnect, device number 2
[ 1068.920000] usb 1-1.1: USB disconnect, device number 3
[ 1069.070000] usb 1-1.2: USB disconnect, device number 4
[ 1069.450000] ci_hdrc ci_hdrc.0: USB bus 1 deregistered
[ 1074.460000] ci_hdrc ci_hdrc.0: timeout waiting for 00000800 in 11

Quoted 4 lines

This patch fixes the issue by setting dr_mode to "host" in the dts file.
Reported-by Harald Geyer <[email protected]>
Signed-off-by Stefan Wahren <[email protected]>

Reviewed-by Marek Vasut <[email protected]>

Best regards,
Marek Vasut

Peter Chen

2015-04-15 03:32 UTC #3 lore raw

PATCH 1/1 ARM: dts: imx23-olinuxino: Fix dr_mode of usb0

In reply to Stefan Wahren

Quoted 36 lines · Stefan Wahren

The dr_mode of usb0 on imx233-olinuxino is left to default "otg". Since the green LED (GPIO2_1) on imx233-olinuxino is connected to the same pin as USB_OTG_ID it's possible to disable USB host by LED toggling:
echo 0 > /sys/class/leds/green/brightness
[ 1068.890000] ci_hdrc ci_hdrc.0: remove, state 1
[ 1068.890000] usb usb1: USB disconnect, device number 1
[ 1068.920000] usb 1-1: USB disconnect, device number 2
[ 1068.920000] usb 1-1.1: USB disconnect, device number 3
[ 1069.070000] usb 1-1.2: USB disconnect, device number 4
[ 1069.450000] ci_hdrc ci_hdrc.0: USB bus 1 deregistered
[ 1074.460000] ci_hdrc ci_hdrc.0: timeout waiting for 00000800 in 11
This patch fixes the issue by setting dr_mode to "host" in the dts file.
Reported-by Harald Geyer <[email protected]>
Signed-off-by Stefan Wahren <[email protected]>
---
 arch/arm/boot/dts/imx23-olinuxino.dts |    1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/imx23-olinuxino.dts +1 -0
index 7e6eef2..3b2d74d 100644
@@ -93,6 +93,7 @@
 
 	ahb at 80080000 {
 		usb0: usb at 80080000 {
+			dr_mode = "host";
 			vbus-supply = <&reg_usb0_vbus>;
 			status = "okay";
 		};
Signature · 1 line
1.7.9.5

If this board has only host function, I am ok for it.

Acked-by Peter Chen <[email protected]>

Signature · 2 lines

Best Regards,
Peter Chen

Stefan Wahren

author

2015-04-15 19:11 UTC #4 lore raw

PATCH 1/1 ARM: dts: imx23-olinuxino: Fix dr_mode of usb0

Hi Peter,

Quoted 7 lines

Peter Chen <[email protected]> hat am 15. April 2015 um 05:32 geschrieben:
[...]
If this board has only host function, I am ok for it.

Yes, all 4 boards (Maxi [1], Micro [2], Mini [3], Nano [4]) have only host function.

Quoted 2 lines

Acked-by Peter Chen <[email protected]>

Thanks
Stefan

[1] -
https://github.com/OLIMEX/OLINUXINO/blob/master/HARDWARE/iMX233-OLinuXino-Maxi/iMX233-OLINUXINO-MAXI_Rev_D.pdf
[2] -
https://github.com/OLIMEX/OLINUXINO/blob/master/HARDWARE/iMX233-OLinuXino-Micro/iMX233-OLinuXino-Micro_Rev_D.pdf
[3] -
https://github.com/OLIMEX/OLINUXINO/blob/master/HARDWARE/iMX233-OLinuXino-Mini/iMX233-OLINUXINO-MINI_Rev_C.sch.pdf
[4] -
https://github.com/OLIMEX/OLINUXINO/blob/master/HARDWARE/iMX233-OLinuXino-NANO/iMX233-OLinuXino-NANO_Rev_B.pdf

Quoted 10 lines

--
Best Regards,
Peter Chen
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Shawn Guo

Applied

2015-04-27 12:26 UTC #5 lore raw

PATCH 1/1 ARM: dts: imx23-olinuxino: Fix dr_mode of usb0

In reply to Stefan Wahren

Quoted 13 lines · Stefan Wahren

The dr_mode of usb0 on imx233-olinuxino is left to default "otg". Since the green LED (GPIO2_1) on imx233-olinuxino is connected to the same pin as USB_OTG_ID it's possible to disable USB host by LED toggling:
echo 0 > /sys/class/leds/green/brightness
[ 1068.890000] ci_hdrc ci_hdrc.0: remove, state 1
[ 1068.890000] usb usb1: USB disconnect, device number 1
[ 1068.920000] usb 1-1: USB disconnect, device number 2
[ 1068.920000] usb 1-1.1: USB disconnect, device number 3
[ 1069.070000] usb 1-1.2: USB disconnect, device number 4
[ 1069.450000] ci_hdrc ci_hdrc.0: USB bus 1 deregistered
[ 1074.460000] ci_hdrc ci_hdrc.0: timeout waiting for 00000800 in 11

Quoted 4 lines

This patch fixes the issue by setting dr_mode to "host" in the dts file.
Reported-by Harald Geyer <[email protected]>
Signed-off-by Stefan Wahren <[email protected]>

Applied, thanks.