f_thor: Dont perform reset at the end of thor

PATCH RESEND Superseded Michal Simek 4 participants 5 messages Apr 15, 2015 USB

lore

Share & tools

lore

Michal Simek

author

2015-04-15 11:43 UTC #0 lore raw

PATCH RESEND 1/1 f_thor: Dont perform reset at the end of thor

From: Siva Durga Prasad Paladugu <[email protected]>

Dont perform reset at the end of thor download
if configured to do reset off.
Reset may not be required in all cases and hence
provided an option to do so.

Signed-off-by Siva Durga Prasad Paladugu <[email protected]>

Signed-off-by Michal Simek <[email protected]>

---

 drivers/usb/gadget/f_thor.c | 7 +++++++
 drivers/usb/gadget/f_thor.h | 3 +++
 2 files changed, 10 insertions(+)

drivers/usb/gadget/f_thor.c +7 -0

index e9a690eff5f1..5c8f6768519c 100644
@@ -123,6 +123,9 @@ static int process_rqt_cmd(const struct rqt_box *rqt)
 		send_rsp(rsp);
 		g_dnl_unregister();
 		dfu_free_entities();
+#ifdef CONFIG_THOR_RESET_OFF
+		return RESET_DONE;
+#endif
 		run_command("reset", 0);
 		break;
 	case RQT_CMD_POWEROFF:

@@ -728,6 +731,10 @@ int thor_handle(void)
 
 		if (ret > 0) {
 			ret = process_data();
+#ifdef CONFIG_THOR_RESET_OFF
+			if (ret == RESET_DONE)
+				break;
+#endif
 			if (ret < 0)
 				return ret;
 		} else {

drivers/usb/gadget/f_thor.h +3 -0

index 833a9d24ae7e..83412851dd17 100644
@@ -121,4 +121,7 @@ struct f_thor {
 #define F_NAME_BUF_SIZE 32
 #define THOR_PACKET_SIZE SZ_1M      /* 1 MiB */
 #define THOR_STORE_UNIT_SIZE SZ_32M /* 32 MiB */
+#ifdef CONFIG_THOR_RESET_OFF
+#define RESET_DONE 0xFFFFFFFF
+#endif
 #endif /* _USB_THOR_H_ */

Signature · 1 line

2.3.5

Marek Vasut

2015-04-15 11:46 UTC #1 lore raw

PATCH RESEND 1/1 f_thor: Dont perform reset at the end of thor

Quoted 6 lines · Michal Simek

From: Siva Durga Prasad Paladugu <[email protected]>
Dont perform reset at the end of thor download if configured to do reset off.
Reset may not be required in all cases and hence provided an option to do so.

Hi,

You fail to explain in which cases this option is needed. You also fail to document this option in README file.

Please fix.

Best regards,
Marek Vasut

Siva Durga Prasad Paladugu

2015-04-15 12:03 UTC #2 lore raw

PATCH RESEND 1/1 f_thor: Dont perform reset at the end of thor

Hi Marek,

Quoted 16 lines

-----Original Message-----
From: Marek Vasut [mailto:marex at denx.de]
Sent: Wednesday, April 15, 2015 5:17 PM
To: Michal Simek
Cc: Lukasz Majewski; u-boot at lists.denx.de; Siva Durga Prasad Paladugu; Tom Rini
Subject: Re: [RESEND PATCH] f_thor: Dont perform reset at the end of thor
Quoted 6 lines · Michal Simek
From: Siva Durga Prasad Paladugu <[email protected]>
Dont perform reset at the end of thor download if configured to do reset off.
Reset may not be required in all cases and hence provided an option to do so.

Quoted 4 lines

Hi,
You fail to explain in which cases this option is needed. You also fail to document this option in README file.

The case here would be to download the images just to DDR instead of to any flash device.

Regards,
Siva

Quoted 5 lines

Please fix.
Best regards,
Marek Vasut

This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.

Marek Vasut

2015-04-15 12:35 UTC #3 lore raw

PATCH RESEND 1/1 f_thor: Dont perform reset at the end of thor

Quoted 1 line · Siva Durga Prasad Paladugu

Hi Marek,

Hi!

Quoted 16 lines

Quoted 16 lines
-----Original Message-----
From: Marek Vasut [mailto:marex at denx.de]
Sent: Wednesday, April 15, 2015 5:17 PM
To: Michal Simek
Cc: Lukasz Majewski; u-boot at lists.denx.de; Siva Durga Prasad Paladugu; Tom Rini
Subject: Re: [RESEND PATCH] f_thor: Dont perform reset at the end of thor
Quoted 6 lines · Michal Simek
From: Siva Durga Prasad Paladugu <[email protected]>
Dont perform reset at the end of thor download if configured to do reset off.
Reset may not be required in all cases and hence provided an option to do so.

Quoted 7 lines

Quoted 4 lines
Hi,
You fail to explain in which cases this option is needed. You also fail to document this option in README file.
The case here would be to download the images just to DDR instead of to any flash device.

That should certainly be in the commit message :)

Quoted 6 lines

This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.

Oh my $DEITY, now the entire mailing list received this possibly proprietary email. What do we do ?! ...

Best regards,
Marek Vasut

Michal Simek

2015-04-15 13:06 UTC #4 lore raw

PATCH RESEND 1/1 f_thor: Dont perform reset at the end of thor

Quoted 38 lines · Marek Vasut

Quoted 1 line · Siva Durga Prasad Paladugu
Hi Marek,
Hi!
Quoted 16 lines
Quoted 16 lines
-----Original Message-----
From: Marek Vasut [mailto:marex at denx.de]
Sent: Wednesday, April 15, 2015 5:17 PM
To: Michal Simek
Cc: Lukasz Majewski; u-boot at lists.denx.de; Siva Durga Prasad Paladugu; Tom Rini
Subject: Re: [RESEND PATCH] f_thor: Dont perform reset at the end of thor
Quoted 6 lines · Michal Simek
From: Siva Durga Prasad Paladugu <[email protected]>
Dont perform reset at the end of thor download if configured to do reset off.
Reset may not be required in all cases and hence provided an option to do so.
Quoted 7 lines
Quoted 4 lines
Hi,
You fail to explain in which cases this option is needed. You also fail to document this option in README file.
The case here would be to download the images just to DDR instead of to any flash device.
That should certainly be in the commit message :)
Quoted 6 lines
This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.

Quoted 2 lines

Oh my $DEITY, now the entire mailing list received this possibly proprietary email. What do we do ?! ...

Just ignore it. I will update the commit message and will resend this patch as v2 but I will wait if someone else has any objection with it.

Thanks,
Michal

Signature · 14 lines

Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150415/447f2b9a/attachment.sig>