Skip to contentSkip to conversation

i2c: jz4780: Explicitly include linux/io.h

PATCH In review Mark Brown 2 participants 2 messages Apr 15, 2015 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 i2c: jz4780: Explicitly include linux/io.h

This driver uses readw() and writew() which are declared in asm/io.h but does not explicitly include that header, causing build failures on architectures where there is not an implicit inclusion such as arm and arm64:

../drivers/i2c/busses/i2c-jz4780.c:181:2: error: implicit declaration of function 'readw' [-Werror=implicit-function-declaration] ../drivers/i2c/busses/i2c-jz4780.c:187:2: error: implicit declaration of function 'writew' [-Werror=implicit-function-declaration]

Add an explicit inclusion to fix this.

---
 drivers/i2c/busses/i2c-jz4780.c | 1 +
 1 file changed, 1 insertion(+)
drivers/i2c/busses/i2c-jz4780.c +1 -0
index ce1d69324169..19b2d689a5ef 100644
@@ -23,6 +23,7 @@
 #include <linux/i2c.h>
 #include <linux/init.h>
 #include <linux/interrupt.h>
+#include <linux/io.h>
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/platform_device.h>
Signature · 1 line
2.1.4

A message that is not in the archive (sent off-list or not yet received): 1429121291-28643-1-git-send-email-broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org

#2 lore raw
Quoted 11 lines · Mark Brown

This driver uses readw() and writew() which are declared in asm/io.h but does not explicitly include that header, causing build failures on architectures where there is not an implicit inclusion such as arm and arm64:

../drivers/i2c/busses/i2c-jz4780.c:181:2: error: implicit declaration of function 'readw' [-Werror=implicit-function-declaration] ../drivers/i2c/busses/i2c-jz4780.c:187:2: error: implicit declaration of function 'writew' [-Werror=implicit-function-declaration]

Add an explicit inclusion to fix this.

Thanks, I just pushed the same fix from Guenter Roeck to -next.