ARM: SoC: add a new platform, UniPhier (arch/arm/mach-uniphier)

arch/arm/mach-uniphier/headsmp.S line 21

Quoted 5 lines

arch/arm/mach-uniphier/headsmp.S new file +4 -0

+ENTRY(uniphier_secondary_startup)
+       bl      v7_invalidate_l1
+       b       secondary_startup
+ENDPROC(uniphier_secondary_startup)

Since this file is really trivial, I wonder if you could just use a 'naked' inline assembly function from C code here, to have the entire SMP support in one file.

Review

Quoted 2 lines

(quoted diff) +2 -0

+
+#define ROM_BOOT_ROMRSV2             0x59801208

Please don't hardcode any physical addresses, instead find the DT node or syscon device in the _boot_secondary implementation.

Which device is this register part of?

Quoted 7 lines

arch/arm/mach-uniphier/uniphier.c new file +7 -0

+
+static const char * const uniphier_board_dt_compat[] __initconst = {
+     "socionext,ph1-sld3",
+     "socionext,ph1-ld4",
+     "socionext,ph1-pro4",
+     "socionext,ph1-sld8",
+     "socionext,ph1-pro5",

arch/arm/mach-uniphier/uniphier.c line 27

Quoted 4 lines

arch/arm/mach-uniphier/uniphier.c new file +4 -0

+     "socionext,ph1-proxstream2",
+     "socionext,ph1-ld6b",
+     NULL,
+};

Are these chip names or board names? The list should normally have just the socs, which I assume you do, but it's not completely clear from the source.

arch/arm/mach-uniphier/platsmp.c new file +8 -0

new file mode 100644
index 0000000..6b61f8d
@@ -0,0 +1,78 @@
+/*
+ * Copyright (C) 2015 Socionext Inc.
+ *   Author: Masahiro Yamada <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.

Quoted 18 lines

arch/arm/mach-uniphier/platsmp.c new file +12 -0

new file mode 100644
index 0000000..6b61f8d
@@ -0,0 +1,78 @@
+/*
+ * Copyright (C) 2015 Socionext Inc.
+ *   Author: Masahiro Yamada <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the

arch/arm/mach-uniphier/platsmp.c line 18

Quoted 6 lines

arch/arm/mach-uniphier/platsmp.c new file +6 -0

+ * GNU General Public License for more details.
+ */
+
+#include <linux/sizes.h>
+#include <linux/init.h>
+#include <asm/io.h>

Please use linux/io.h rather than asm/io.h

Add UniPhier, a new citizen in the ARM multi platform.

Signed-off-by Masahiro Yamada <[email protected]>

---

 arch/arm/configs/multi_v7_defconfig | 1 +
 1 file changed, 1 insertion(+)

arch/arm/configs/multi_v7_defconfig +0 -0

index d7f038d..24005cf 100644

Quoted 8 lines

Add UniPhier, a new citizen in the ARM multi platform.

Signed-off-by Masahiro Yamada <[email protected]>

---

 arch/arm/configs/multi_v7_defconfig | 1 +
 1 file changed, 1 insertion(+)

arch/arm/configs/multi_v7_defconfig CONFIG_ARCH_TEGRA_3x_SOC=y · line 87

Quoted 13 lines

arch/arm/configs/multi_v7_defconfig +1 -0

index d7f038d..24005cf 100644
@@ -81,6 +81,7 @@ CONFIG_ARCH_TEGRA_3x_SOC=y
 CONFIG_ARCH_TEGRA_114_SOC=y
 CONFIG_ARCH_TEGRA_124_SOC=y
 CONFIG_TEGRA_EMC_SCALING_ENABLE=y
+CONFIG_ARCH_UNIPHIER=y
 CONFIG_ARCH_U8500=y
 CONFIG_MACH_HREFV60=y
 CONFIG_MACH_SNOWBALL=y

Any additional device drivers you need?

2015-04-16 18:42 GMT+09:00 Arnd Bergmann <[email protected]>:

Quoted 9 lines · On Thursday 16 April 2015 16:40:36 Masahiro Yamada wrote:

Quoted 8 lines

Add UniPhier, a new citizen in the ARM multi platform.

Signed-off-by Masahiro Yamada <[email protected]>

---

 arch/arm/configs/multi_v7_defconfig | 1 +
 1 file changed, 1 insertion(+)

Quoted 16 lines

arch/arm/configs/multi_v7_defconfig CONFIG_ARCH_TEGRA_3x_SOC=y · line 87

Quoted 13 lines

arch/arm/configs/multi_v7_defconfig +1 -0

index d7f038d..24005cf 100644
@@ -81,6 +81,7 @@ CONFIG_ARCH_TEGRA_3x_SOC=y
 CONFIG_ARCH_TEGRA_114_SOC=y
 CONFIG_ARCH_TEGRA_124_SOC=y
 CONFIG_TEGRA_EMC_SCALING_ENABLE=y
+CONFIG_ARCH_UNIPHIER=y
 CONFIG_ARCH_U8500=y
 CONFIG_MACH_HREFV60=y
 CONFIG_MACH_SNOWBALL=y

Any additional device drivers you need?

Our drivers are still based-on old kernel version (pre-DT) with local ugly hacking.
I need more time to re-write them based on the current coding style (almost from scratch),
so I'd like to do it as a second round.

This series is just mainlining a minimal support with a serial console. I think it is a good starting point.
The UART device is 16550-compatible, so I do not need any additional driver.

arch/arm/boot/dts/uniphier-ph1-ld4-ref.dts line 33

Quoted 13 lines

arch/arm/boot/dts/uniphier-ph1-ld4-ref.dts new file +13 -0

+
+/ {
+     model = "UniPhier PH1-LD4 Reference Board";
+     compatible = "socionext,ph1-ld4-ref", "socionext,ph1-ld4";
+
+     memory {
+             device_type = "memory";
+             reg = <0x80000000 0x20000000>;
+     };
+
+     chosen {
+             bootargs = "console=ttyS0,115200 earlyprintk";
+     };

I would remove the 'earlyprintk' option here. You don't add any options for the platform in Kconfig.debug, and I hope that we can eventually start using earlycon. Please add an appropriate stdio-path property here, but note that we are still lacking the fixmap patches to make earlycon work.

Otherwise looks good.

Initial device trees for UniPhier SoCs: PH1-sLD3, PH1-LD4, PH1-Pro4, and PH1-sLD8.

Signed-off-by Masahiro Yamada <[email protected]>

---

 arch/arm/boot/dts/Makefile                   |  5 ++
 arch/arm/boot/dts/uniphier-ph1-ld4-ref.dts   | 51 +++++++++++++++++
 arch/arm/boot/dts/uniphier-ph1-ld4.dtsi      | 78 +++++++++++++++++++++++++
 arch/arm/boot/dts/uniphier-ph1-pro4-ref.dts  | 51 +++++++++++++++++
 arch/arm/boot/dts/uniphier-ph1-pro4.dtsi     | 85 ++++++++++++++++++++++++++++
 arch/arm/boot/dts/uniphier-ph1-sld3-ref.dts  | 52 +++++++++++++++++
 arch/arm/boot/dts/uniphier-ph1-sld3.dtsi     | 85 ++++++++++++++++++++++++++++
 arch/arm/boot/dts/uniphier-ph1-sld8-ref.dts  | 51 +++++++++++++++++
 arch/arm/boot/dts/uniphier-ph1-sld8.dtsi     | 78 +++++++++++++++++++++++++
 arch/arm/boot/dts/uniphier-support-card.dtsi | 39 +++++++++++++
 10 files changed, 575 insertions(+)
 create mode 100644 arch/arm/boot/dts/uniphier-ph1-ld4-ref.dts
 create mode 100644 arch/arm/boot/dts/uniphier-ph1-ld4.dtsi
 create mode 100644 arch/arm/boot/dts/uniphier-ph1-pro4-ref.dts
 create mode 100644 arch/arm/boot/dts/uniphier-ph1-pro4.dtsi
 create mode 100644 arch/arm/boot/dts/uniphier-ph1-sld3-ref.dts
 create mode 100644 arch/arm/boot/dts/uniphier-ph1-sld3.dtsi
 create mode 100644 arch/arm/boot/dts/uniphier-ph1-sld8-ref.dts
 create mode 100644 arch/arm/boot/dts/uniphier-ph1-sld8.dtsi
 create mode 100644 arch/arm/boot/dts/uniphier-support-card.dtsi

arch/arm/boot/dts/Makefile +5 -0

index a1c776b..d639a90 100644
@@ -588,6 +588,11 @@ dtb-$(CONFIG_ARCH_U8500) += \
 	ste-hrefv60plus-tvk.dtb \
 	ste-ccu8540.dtb \
 	ste-ccu9540.dtb
+dtb-$(CONFIG_ARCH_UNIPHIER) += \
+	uniphier-ph1-sld3-ref.dtb \
+	uniphier-ph1-ld4-ref.dtb \
+	uniphier-ph1-pro4-ref.dtb \
+	uniphier-ph1-sld8-ref.dtb
 dtb-$(CONFIG_ARCH_VERSATILE) += \
 	versatile-ab.dtb \
 	versatile-pb.dtb

arch/arm/boot/dts/uniphier-ph1-ld4-ref.dts new file +6 -0

new file mode 100644
index 0000000..2e83363
@@ -0,0 +1,51 @@
+/*
+ * Device Tree Source for UniPhier PH1-LD4 Reference Board
+ *
+ * Copyright (C) 2015 Socionext Inc.
+ *   Author: Masahiro Yamada <[email protected]>
+ *