drm/gma500: missing error codes in psb_driver_load()
Subsystems (4)
PATCH 1/1 drm/gma500: missing error codes in psb_driver_load()
We should return an error code here. In the current code they can only fail if there is an allocation error so -ENOMEM is appropriate.
Signed-off-by Dan Carpenter <[email protected]>
drivers/gpu/drm/gma500/psb_drv.c +6 -2
@@ -326,12 +326,16 @@ static int psb_driver_load(struct drm_device *dev, unsigned long flags) goto out_err; dev_priv->mmu =psb_mmu_driver_init (dev,1 ,0 ,0 ); -if (!dev_priv->mmu) +if (!dev_priv->mmu) { + ret = -ENOMEM ; goto out_err; + } dev_priv->pf_pd =psb_mmu_alloc_pd (dev_priv->mmu,1 ,0 ); -if (!dev_priv->pf_pd) +if (!dev_priv->pf_pd) { + ret = -ENOMEM ; goto out_err; + } ret =psb_do_init (dev);if (ret)
Quoted 4 lines · Dan Carpenter
We should return an error code here. In the current code they can only fail if there is an allocation error so
-ENOMEMis appropriate.Signed-off-by Dan Carpenter <[email protected]>
Reviewed-by Patrik Jakobsson <[email protected]>
Quoted 23 lines
drivers/gpu/drm/gma500/psb_drv.c +6
-2@@ -326,12 +326,16 @@ static int psb_driver_load(struct drm_device *dev, unsigned long flags) goto out_err; dev_priv->mmu =psb_mmu_driver_init (dev,1 ,0 ,0 ); -if (!dev_priv->mmu) +if (!dev_priv->mmu) { + ret = -ENOMEM ; goto out_err; + } dev_priv->pf_pd =psb_mmu_alloc_pd (dev_priv->mmu,1 ,0 ); -if (!dev_priv->pf_pd) +if (!dev_priv->pf_pd) { + ret = -ENOMEM ; goto out_err; + } ret =psb_do_init (dev);if (ret)
Quoted 4 lines
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel