Skip to contentSkip to conversation

Intel-gfx Digest, Vol 86, Issue 409

DISCUSSION Ben Widawsky 3 participants 3 messages Apr 18, 2015 – Apr 20, 2015 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 15 lines · On Thu, Mar 26, 2015 at 12:44:19PM -0700…

Send Intel-gfx mailing list submissions to
[email protected]

To subscribe or unsubscribe via the World Wide Web, visit
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
or, via email, send a message with subject or body 'help' to
[email protected]

You can reach the person managing the list at
[email protected]

When replying, please edit your Subject line so it is more specific than "Re: Contents of Intel-gfx digest..."

Quoted 7 lines

Today's Topics:

1. [PATCH 04/18] drm/i915: GuC firmware loader ([email protected])
2. [PATCH 05/18] drm/i915: Add firmware version check

      ([email protected])

3. [PATCH 06/18] drm/i915: Defer default hardware context initialisation until first open ([email protected])

There is a lot of work here from both Vinit and myself in these patches, and removing my authorship and the notes I made about Vinit's important contributions are not appropriate in all the cases. Our SOBs should be retained on several of the GuC patches, and authorship should be retained where appropriate.

If you've written a majority of the patch, or vastly changed how the code works, then you should change authorship.

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw
Quoted 24 lines · Ben Widawsky
Quoted 15 lines · On Thu, Mar 26, 2015 at 12:44:19PM -0700…

Send Intel-gfx mailing list submissions to
[email protected]

To subscribe or unsubscribe via the World Wide Web, visit
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
or, via email, send a message with subject or body 'help' to
[email protected]

You can reach the person managing the list at
[email protected]

When replying, please edit your Subject line so it is more specific than "Re: Contents of Intel-gfx digest..."

Quoted 7 lines

Today's Topics:

1. [PATCH 04/18] drm/i915: GuC firmware loader ([email protected])
2. [PATCH 05/18] drm/i915: Add firmware version check

      ([email protected])

3. [PATCH 06/18] drm/i915: Defer default hardware context initialisation until first open ([email protected])

Quoted 8 lines

There is a lot of work here from both Vinit and myself in these patches, and removing my authorship and the notes I made about Vinit's important contributions are not appropriate in all the cases. Our SOBs should be retained on several of the GuC patches, and authorship should be retained where appropriate.

If you've written a majority of the patch, or vastly changed how the code works, then you should change authorship.

And even when the patches are completely rewritten please retain a note along the lines of "based upon patches from $original_author". Yes I've recently complained about retaining the original authorship when the patch is completely rewritten, but removing all trails of the patch's history isn't the right thing either. Acknowledging other people's contributions is important.
-Daniel

Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#3 lore raw
Quoted 34 lines · Daniel Vetter
Quoted 24 lines · Ben Widawsky
Quoted 15 lines · On Thu, Mar 26, 2015 at 12:44:19PM -0700…

Send Intel-gfx mailing list submissions to
[email protected]

To subscribe or unsubscribe via the World Wide Web, visit
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
or, via email, send a message with subject or body 'help' to
[email protected]

You can reach the person managing the list at
[email protected]

When replying, please edit your Subject line so it is more specific than "Re: Contents of Intel-gfx digest..."

Quoted 7 lines

Today's Topics:

1. [PATCH 04/18] drm/i915: GuC firmware loader ([email protected])
2. [PATCH 05/18] drm/i915: Add firmware version check

      ([email protected])

3. [PATCH 06/18] drm/i915: Defer default hardware context initialisation until first open ([email protected])

Quoted 8 lines

There is a lot of work here from both Vinit and myself in these patches, and removing my authorship and the notes I made about Vinit's important contributions are not appropriate in all the cases. Our SOBs should be retained on several of the GuC patches, and authorship should be retained where appropriate.

If you've written a majority of the patch, or vastly changed how the code works, then you should change authorship.

Quoted 7 lines

And even when the patches are completely rewritten please retain a note along the lines of "based upon patches from $original_author". Yes I've recently complained about retaining the original authorship when the patch is completely rewritten, but removing all trails of the patch's history isn't the right thing either. Acknowledging other people's contributions is important.
-Daniel

Totally agree. Thanks Ben and Daniel. The authors information will be shown either in file header or commit message in next submission.

Thanks,
Alex
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx