Please pull u-boot-dm.git [take 2]

Hi Tom,

As mentioned I reverted this patch as it conflicted with the dm tree and I suspect it might be buggy:

cd749658 usb_storage : scan all interfaces to find a storage device

Assuming this is OK and applies successfully I will rebase and resend this patch, then reply with some comments I have on the patch.

The following changes since commit 4564faeafbf11feb839e2e3f927be2f1a919ba96:

ti: dwc3: Enable clocks in enable_basic_clocks() in hw_data.c
(2015-04-16 15:08:36 -0400)

are available in the git repository at:

http://git.denx.de/u-boot-dm.git

for you to fetch changes up to 2e6263093b3a5c2d2c586afaedfd346d6628f784:

sandbox: exynos: Move CONFIG_SOUND_SANDBOX to Kconfig (2015-04-16
20:47:57 -0600)

Quoted 20 lines · Simon Glass

Hi Tom,

As mentioned I reverted this patch as it conflicted with the dm tree and I suspect it might be buggy:

cd749658 usb_storage : scan all interfaces to find a storage device

Assuming this is OK and applies successfully I will rebase and resend this patch, then reply with some comments I have on the patch.

The following changes since commit 4564faeafbf11feb839e2e3f927be2f1a919ba96:

ti: dwc3: Enable clocks in enable_basic_clocks() in hw_data.c
(2015-04-16 15:08:36 -0400)

are available in the git repository at:

http://git.denx.de/u-boot-dm.git

Quoted 4 lines

for you to fetch changes up to 2e6263093b3a5c2d2c586afaedfd346d6628f784:

sandbox: exynos: Move CONFIG_SOUND_SANDBOX to Kconfig (2015-04-16
20:47:57 -0600)

With this PR, am335x_boneblack (which has DM enabled) no longer functions. I'm running a bisect now, but heads up.

Hi Tom,

Quoted 25 lines · Tom Rini

Quoted 22 lines · Simon Glass

Hi Tom,

As mentioned I reverted this patch as it conflicted with the dm tree and I suspect it might be buggy:

cd749658 usb_storage : scan all interfaces to find a storage device

Assuming this is OK and applies successfully I will rebase and resend this patch, then reply with some comments I have on the patch.

The following changes since commit 4564faeafbf11feb839e2e3f927be2f1a919ba96:

ti: dwc3: Enable clocks in enable_basic_clocks() in hw_data.c
(2015-04-16 15:08:36 -0400)

are available in the git repository at:

http://git.denx.de/u-boot-dm.git

for you to fetch changes up to 2e6263093b3a5c2d2c586afaedfd346d6628f784:

Quoted 5 lines

Quoted 2 lines

sandbox: exynos: Move CONFIG_SOUND_SANDBOX to Kconfig (2015-04-16
20:47:57 -0600)

With this PR, am335x_boneblack (which has DM enabled) no longer functions. I'm running a bisect now, but heads up.

OK, I'll wait for your bisect - also what is the console output when it breaks?

Quoted 28 lines · Simon Glass

Hi Tom,

Quoted 25 lines · Tom Rini

Quoted 22 lines · Simon Glass

Hi Tom,

As mentioned I reverted this patch as it conflicted with the dm tree and I suspect it might be buggy:

cd749658 usb_storage : scan all interfaces to find a storage device

Assuming this is OK and applies successfully I will rebase and resend this patch, then reply with some comments I have on the patch.

The following changes since commit 4564faeafbf11feb839e2e3f927be2f1a919ba96:

ti: dwc3: Enable clocks in enable_basic_clocks() in hw_data.c
(2015-04-16 15:08:36 -0400)

are available in the git repository at:

http://git.denx.de/u-boot-dm.git

for you to fetch changes up to 2e6263093b3a5c2d2c586afaedfd346d6628f784:

Quoted 7 lines

Quoted 5 lines

Quoted 2 lines

sandbox: exynos: Move CONFIG_SOUND_SANDBOX to Kconfig (2015-04-16
20:47:57 -0600)

With this PR, am335x_boneblack (which has DM enabled) no longer functions. I'm running a bisect now, but heads up.

OK, I'll wait for your bisect - also what is the console output when it breaks?

OK, disregard Beaglebone Black error, that was me (need to remember that eMMC boot only works off of am335x_boneblack_config). But, A20-OLinuXino-Lime2_defconfig is broken by this. The error log:
Command(A20 OLinuXino Lime2 console)> on
(user:trini) Power turned on

U-Boot SPL 2015.04-00342-g2e62630 (Apr 17 2015 - 12:40:45)
DRAM: 1024 MiB

CPU: 912000000Hz, AXI/AHB/APB: 3/2/2

U-Boot 2015.04-00342-g2e62630 (Apr 17 2015 - 12:40:45) Allwinner Technology

CPU:   Allwinner A20 (SUN7I)
I2C:   ready
DRAM:  1 GiB
MMC:   SUNXI SD/MMC: 0

*** Warning - bad CRC, using default environment

In:    serial
Out:   serial
Err:   serial
SCSI:  SUNXI SCSI INIT
SATA link 0 timeout.
AHCI 0001.0100 32 slots 1 ports 3 Gbps 0x1 impl SATA mode
flags: ncq stag pm led clo only pmp pio slum part ccc apst
Net:   dwmac.1c50000

starting USB...
USB0: USB EHCI 1.00
scanning bus 0 for devices...
U-Boot SPL 2015.04-00342-g2e62630 (Apr 17 2015 - 12:40:45)
DRAM: 1024 MiB

CPU: 912000000Hz, AXI/AHB/APB: 3/2/2

MMC Device 0 not found
spl: mmc device not found!!
### ERROR ### Please RESET the board ###

And good:
Command(A20 OLinuXino Lime2 console)> on
(user:trini) Power turned on

U-Boot SPL 2015.04-00121-g4564fae (Apr 17 2015 - 12:42:40)
DRAM: 1024 MiB

CPU: 912000000Hz, AXI/AHB/APB: 3/2/2

U-Boot 2015.04-00121-g4564fae (Apr 17 2015 - 12:42:40) Allwinner Technology

CPU:   Allwinner A20 (SUN7I)
I2C:   ready
DRAM:  1 GiB
MMC:   SUNXI SD/MMC: 0

*** Warning - bad CRC, using default environment

In:    serial
Out:   serial
Err:   serial
SCSI:  SUNXI SCSI INIT
SATA link 0 timeout.
AHCI 0001.0100 32 slots 1 ports 3 Gbps 0x1 impl SATA mode
flags: ncq stag pm led clo only pmp pio slum part ccc apst
Net:   dwmac.1c50000

starting USB...
USB0: USB EHCI 1.00
scanning bus 0 for devices... 1 USB Device(s) found
USB1: USB EHCI 1.00
scanning bus 1 for devices... 1 USB Device(s) found
scanning usb for storage devices... 0 Storage Device(s) found
Hit any key to stop autoboot: 0
sunxi#

So... we cause a reset during USB scan and then fail to boot a second time?

Hi Tom,

Quoted 108 lines · Tom Rini

Quoted 28 lines · Simon Glass

Hi Tom,

Quoted 25 lines · Tom Rini

Quoted 22 lines · Simon Glass

Hi Tom,

As mentioned I reverted this patch as it conflicted with the dm tree and I suspect it might be buggy:

cd749658 usb_storage : scan all interfaces to find a storage device

Assuming this is OK and applies successfully I will rebase and resend this patch, then reply with some comments I have on the patch.

The following changes since commit 4564faeafbf11feb839e2e3f927be2f1a919ba96:

ti: dwc3: Enable clocks in enable_basic_clocks() in hw_data.c
(2015-04-16 15:08:36 -0400)

are available in the git repository at:

   http://git.denx.de/u-boot-dm.git

for you to fetch changes up to 2e6263093b3a5c2d2c586afaedfd346d6628f784:

Quoted 7 lines

Quoted 5 lines

Quoted 2 lines

sandbox: exynos: Move CONFIG_SOUND_SANDBOX to Kconfig (2015-04-16
20:47:57 -0600)

With this PR, am335x_boneblack (which has DM enabled) no longer functions. I'm running a bisect now, but heads up.

OK, I'll wait for your bisect - also what is the console output when it breaks?

OK, disregard Beaglebone Black error, that was me (need to remember that eMMC boot only works off of am335x_boneblack_config). But, A20-OLinuXino-Lime2_defconfig is broken by this. The error log:
Command(A20 OLinuXino Lime2 console)> on
(user:trini) Power turned on

U-Boot SPL 2015.04-00342-g2e62630 (Apr 17 2015 - 12:40:45)
DRAM: 1024 MiB

CPU: 912000000Hz, AXI/AHB/APB: 3/2/2

U-Boot 2015.04-00342-g2e62630 (Apr 17 2015 - 12:40:45) Allwinner Technology

CPU:   Allwinner A20 (SUN7I)
I2C:   ready
DRAM:  1 GiB
MMC:   SUNXI SD/MMC: 0

*** Warning - bad CRC, using default environment

In:    serial
Out:   serial
Err:   serial
SCSI:  SUNXI SCSI INIT
SATA link 0 timeout.
AHCI 0001.0100 32 slots 1 ports 3 Gbps 0x1 impl SATA mode
flags: ncq stag pm led clo only pmp pio slum part ccc apst
Net:   dwmac.1c50000

starting USB...
USB0: USB EHCI 1.00
scanning bus 0 for devices...
U-Boot SPL 2015.04-00342-g2e62630 (Apr 17 2015 - 12:40:45)
DRAM: 1024 MiB

CPU: 912000000Hz, AXI/AHB/APB: 3/2/2

MMC Device 0 not found
spl: mmc device not found!!
### ERROR ### Please RESET the board ###

And good:
Command(A20 OLinuXino Lime2 console)> on
(user:trini) Power turned on

U-Boot SPL 2015.04-00121-g4564fae (Apr 17 2015 - 12:42:40)
DRAM: 1024 MiB

CPU: 912000000Hz, AXI/AHB/APB: 3/2/2

U-Boot 2015.04-00121-g4564fae (Apr 17 2015 - 12:42:40) Allwinner Technology

CPU:   Allwinner A20 (SUN7I)
I2C:   ready
DRAM:  1 GiB
MMC:   SUNXI SD/MMC: 0

*** Warning - bad CRC, using default environment

In:    serial
Out:   serial
Err:   serial
SCSI:  SUNXI SCSI INIT
SATA link 0 timeout.
AHCI 0001.0100 32 slots 1 ports 3 Gbps 0x1 impl SATA mode
flags: ncq stag pm led clo only pmp pio slum part ccc apst
Net:   dwmac.1c50000

starting USB...
USB0: USB EHCI 1.00
scanning bus 0 for devices... 1 USB Device(s) found
USB1: USB EHCI 1.00
scanning bus 1 for devices... 1 USB Device(s) found
scanning usb for storage devices... 0 Storage Device(s) found
Hit any key to stop autoboot: 0
sunxi#

Quoted 2 lines

So... we cause a reset during USB scan and then fail to boot a second time?

Thanks for testing this.

I'm not sure if I have a Lime (I might do, will need to look). I was testing sunxi on a pcduino3 but USB does not work on that for reasons I was looking into (it just says lowlevel init failure due to moving to driver model for GPIO).

I will take a look. In the meantime, which commit breaks this? I could perhaps issue a pull for commits up to that point to reduce the load.

Hi Tom,

Quoted 108 lines · Tom Rini

Quoted 28 lines · Simon Glass

Hi Tom,

Quoted 25 lines · Tom Rini

Quoted 22 lines · Simon Glass

Hi Tom,

As mentioned I reverted this patch as it conflicted with the dm tree and I suspect it might be buggy:

cd749658 usb_storage : scan all interfaces to find a storage device

Assuming this is OK and applies successfully I will rebase and resend this patch, then reply with some comments I have on the patch.

The following changes since commit 4564faeafbf11feb839e2e3f927be2f1a919ba96:

ti: dwc3: Enable clocks in enable_basic_clocks() in hw_data.c
(2015-04-16 15:08:36 -0400)

are available in the git repository at:

http://git.denx.de/u-boot-dm.git

for you to fetch changes up to 2e6263093b3a5c2d2c586afaedfd346d6628f784:

Quoted 7 lines

Quoted 5 lines

Quoted 2 lines

sandbox: exynos: Move CONFIG_SOUND_SANDBOX to Kconfig (2015-04-16
20:47:57 -0600)

With this PR, am335x_boneblack (which has DM enabled) no longer functions. I'm running a bisect now, but heads up.

OK, I'll wait for your bisect - also what is the console output when it breaks?

OK, disregard Beaglebone Black error, that was me (need to remember that eMMC boot only works off of am335x_boneblack_config). But, A20-OLinuXino-Lime2_defconfig is broken by this. The error log:
Command(A20 OLinuXino Lime2 console)> on
(user:trini) Power turned on

U-Boot SPL 2015.04-00342-g2e62630 (Apr 17 2015 - 12:40:45)
DRAM: 1024 MiB

CPU: 912000000Hz, AXI/AHB/APB: 3/2/2

U-Boot 2015.04-00342-g2e62630 (Apr 17 2015 - 12:40:45) Allwinner Technology

CPU:   Allwinner A20 (SUN7I)
I2C:   ready
DRAM:  1 GiB
MMC:   SUNXI SD/MMC: 0

*** Warning - bad CRC, using default environment

In:    serial
Out:   serial
Err:   serial
SCSI:  SUNXI SCSI INIT
SATA link 0 timeout.
AHCI 0001.0100 32 slots 1 ports 3 Gbps 0x1 impl SATA mode
flags: ncq stag pm led clo only pmp pio slum part ccc apst
Net:   dwmac.1c50000

starting USB...
USB0: USB EHCI 1.00
scanning bus 0 for devices...
U-Boot SPL 2015.04-00342-g2e62630 (Apr 17 2015 - 12:40:45)
DRAM: 1024 MiB

CPU: 912000000Hz, AXI/AHB/APB: 3/2/2

MMC Device 0 not found
spl: mmc device not found!!
### ERROR ### Please RESET the board ###

And good:
Command(A20 OLinuXino Lime2 console)> on
(user:trini) Power turned on

U-Boot SPL 2015.04-00121-g4564fae (Apr 17 2015 - 12:42:40)
DRAM: 1024 MiB

CPU: 912000000Hz, AXI/AHB/APB: 3/2/2

U-Boot 2015.04-00121-g4564fae (Apr 17 2015 - 12:42:40) Allwinner Technology

CPU:   Allwinner A20 (SUN7I)
I2C:   ready
DRAM:  1 GiB
MMC:   SUNXI SD/MMC: 0

*** Warning - bad CRC, using default environment

In:    serial
Out:   serial
Err:   serial
SCSI:  SUNXI SCSI INIT
SATA link 0 timeout.
AHCI 0001.0100 32 slots 1 ports 3 Gbps 0x1 impl SATA mode
flags: ncq stag pm led clo only pmp pio slum part ccc apst
Net:   dwmac.1c50000

starting USB...
USB0: USB EHCI 1.00
scanning bus 0 for devices... 1 USB Device(s) found
USB1: USB EHCI 1.00
scanning bus 1 for devices... 1 USB Device(s) found
scanning usb for storage devices... 0 Storage Device(s) found
Hit any key to stop autoboot: 0
sunxi#

Quoted 2 lines

So... we cause a reset during USB scan and then fail to boot a second time?

Thanks for testing this.

I'm not sure if I have a Lime (I might do, will need to look). I was testing sunxi on a pcduino3 but USB does not work on that for reasons I was looking into (it just says lowlevel init failure due to moving to driver model for GPIO).

I will take a look. In the meantime, which commit breaks this? I could perhaps issue a pull for commits up to that point to reduce the load.

Quoted 121 lines · Simon Glass

Hi Tom,

Quoted 108 lines · Tom Rini

Quoted 28 lines · Simon Glass

Hi Tom,

Quoted 25 lines · Tom Rini

Quoted 22 lines · Simon Glass

Hi Tom,

As mentioned I reverted this patch as it conflicted with the dm tree and I suspect it might be buggy:

cd749658 usb_storage : scan all interfaces to find a storage device

Assuming this is OK and applies successfully I will rebase and resend this patch, then reply with some comments I have on the patch.

The following changes since commit 4564faeafbf11feb839e2e3f927be2f1a919ba96:

ti: dwc3: Enable clocks in enable_basic_clocks() in hw_data.c
(2015-04-16 15:08:36 -0400)

are available in the git repository at:

   http://git.denx.de/u-boot-dm.git

for you to fetch changes up to 2e6263093b3a5c2d2c586afaedfd346d6628f784:

Quoted 7 lines

Quoted 5 lines

Quoted 2 lines

sandbox: exynos: Move CONFIG_SOUND_SANDBOX to Kconfig (2015-04-16
20:47:57 -0600)

With this PR, am335x_boneblack (which has DM enabled) no longer functions. I'm running a bisect now, but heads up.

OK, I'll wait for your bisect - also what is the console output when it breaks?

OK, disregard Beaglebone Black error, that was me (need to remember that eMMC boot only works off of am335x_boneblack_config). But, A20-OLinuXino-Lime2_defconfig is broken by this. The error log:
Command(A20 OLinuXino Lime2 console)> on
(user:trini) Power turned on

U-Boot SPL 2015.04-00342-g2e62630 (Apr 17 2015 - 12:40:45)
DRAM: 1024 MiB

CPU: 912000000Hz, AXI/AHB/APB: 3/2/2

U-Boot 2015.04-00342-g2e62630 (Apr 17 2015 - 12:40:45) Allwinner Technology

CPU:   Allwinner A20 (SUN7I)
I2C:   ready
DRAM:  1 GiB
MMC:   SUNXI SD/MMC: 0

*** Warning - bad CRC, using default environment

In:    serial
Out:   serial
Err:   serial
SCSI:  SUNXI SCSI INIT
SATA link 0 timeout.
AHCI 0001.0100 32 slots 1 ports 3 Gbps 0x1 impl SATA mode
flags: ncq stag pm led clo only pmp pio slum part ccc apst
Net:   dwmac.1c50000

starting USB...
USB0: USB EHCI 1.00
scanning bus 0 for devices...
U-Boot SPL 2015.04-00342-g2e62630 (Apr 17 2015 - 12:40:45)
DRAM: 1024 MiB

CPU: 912000000Hz, AXI/AHB/APB: 3/2/2

MMC Device 0 not found
spl: mmc device not found!!
### ERROR ### Please RESET the board ###

And good:
Command(A20 OLinuXino Lime2 console)> on
(user:trini) Power turned on

U-Boot SPL 2015.04-00121-g4564fae (Apr 17 2015 - 12:42:40)
DRAM: 1024 MiB

CPU: 912000000Hz, AXI/AHB/APB: 3/2/2

U-Boot 2015.04-00121-g4564fae (Apr 17 2015 - 12:42:40) Allwinner Technology

CPU:   Allwinner A20 (SUN7I)
I2C:   ready
DRAM:  1 GiB
MMC:   SUNXI SD/MMC: 0

*** Warning - bad CRC, using default environment

In:    serial
Out:   serial
Err:   serial
SCSI:  SUNXI SCSI INIT
SATA link 0 timeout.
AHCI 0001.0100 32 slots 1 ports 3 Gbps 0x1 impl SATA mode
flags: ncq stag pm led clo only pmp pio slum part ccc apst
Net:   dwmac.1c50000

starting USB...
USB0: USB EHCI 1.00
scanning bus 0 for devices... 1 USB Device(s) found
USB1: USB EHCI 1.00
scanning bus 1 for devices... 1 USB Device(s) found
scanning usb for storage devices... 0 Storage Device(s) found
Hit any key to stop autoboot: 0
sunxi#

Quoted 2 lines

So... we cause a reset during USB scan and then fail to boot a second time?

Thanks for testing this.

I'm not sure if I have a Lime (I might do, will need to look). I was testing sunxi on a pcduino3 but USB does not work on that for reasons I was looking into (it just says lowlevel init failure due to moving to driver model for GPIO).

Quoted 2 lines

I will take a look. In the meantime, which commit breaks this? I could perhaps issue a pull for commits up to that point to reduce the load.

I haven't had a chance to bisect yet but I will in a few hours.

Hi,

Quoted 122 lines · Tom Rini

Quoted 121 lines · Simon Glass

Hi Tom,

Quoted 108 lines · Tom Rini

Quoted 28 lines · Simon Glass

Hi Tom,

Quoted 25 lines · Tom Rini

Quoted 22 lines · Simon Glass

Hi Tom,

As mentioned I reverted this patch as it conflicted with the dm tree and I suspect it might be buggy:

cd749658 usb_storage : scan all interfaces to find a storage device

Assuming this is OK and applies successfully I will rebase and resend this patch, then reply with some comments I have on the patch.

The following changes since commit 4564faeafbf11feb839e2e3f927be2f1a919ba96:

ti: dwc3: Enable clocks in enable_basic_clocks() in hw_data.c
(2015-04-16 15:08:36 -0400)

are available in the git repository at:

   http://git.denx.de/u-boot-dm.git

for you to fetch changes up to 2e6263093b3a5c2d2c586afaedfd346d6628f784:

Quoted 7 lines

Quoted 5 lines

Quoted 2 lines

sandbox: exynos: Move CONFIG_SOUND_SANDBOX to Kconfig (2015-04-16
20:47:57 -0600)

With this PR, am335x_boneblack (which has DM enabled) no longer functions. I'm running a bisect now, but heads up.

OK, I'll wait for your bisect - also what is the console output when it breaks?

OK, disregard Beaglebone Black error, that was me (need to remember that eMMC boot only works off of am335x_boneblack_config). But, A20-OLinuXino-Lime2_defconfig is broken by this. The error log:
Command(A20 OLinuXino Lime2 console)> on
(user:trini) Power turned on

U-Boot SPL 2015.04-00342-g2e62630 (Apr 17 2015 - 12:40:45)
DRAM: 1024 MiB

CPU: 912000000Hz, AXI/AHB/APB: 3/2/2

U-Boot 2015.04-00342-g2e62630 (Apr 17 2015 - 12:40:45) Allwinner Technology

CPU:   Allwinner A20 (SUN7I)
I2C:   ready
DRAM:  1 GiB
MMC:   SUNXI SD/MMC: 0

*** Warning - bad CRC, using default environment

In:    serial
Out:   serial
Err:   serial
SCSI:  SUNXI SCSI INIT
SATA link 0 timeout.
AHCI 0001.0100 32 slots 1 ports 3 Gbps 0x1 impl SATA mode
flags: ncq stag pm led clo only pmp pio slum part ccc apst
Net:   dwmac.1c50000

starting USB...
USB0: USB EHCI 1.00
scanning bus 0 for devices...
U-Boot SPL 2015.04-00342-g2e62630 (Apr 17 2015 - 12:40:45)
DRAM: 1024 MiB

CPU: 912000000Hz, AXI/AHB/APB: 3/2/2

MMC Device 0 not found
spl: mmc device not found!!
### ERROR ### Please RESET the board ###

And good:
Command(A20 OLinuXino Lime2 console)> on
(user:trini) Power turned on

U-Boot SPL 2015.04-00121-g4564fae (Apr 17 2015 - 12:42:40)
DRAM: 1024 MiB

CPU: 912000000Hz, AXI/AHB/APB: 3/2/2

U-Boot 2015.04-00121-g4564fae (Apr 17 2015 - 12:42:40) Allwinner Technology

CPU:   Allwinner A20 (SUN7I)
I2C:   ready
DRAM:  1 GiB
MMC:   SUNXI SD/MMC: 0

*** Warning - bad CRC, using default environment

In:    serial
Out:   serial
Err:   serial
SCSI:  SUNXI SCSI INIT
SATA link 0 timeout.
AHCI 0001.0100 32 slots 1 ports 3 Gbps 0x1 impl SATA mode
flags: ncq stag pm led clo only pmp pio slum part ccc apst
Net:   dwmac.1c50000

starting USB...
USB0: USB EHCI 1.00
scanning bus 0 for devices... 1 USB Device(s) found
USB1: USB EHCI 1.00
scanning bus 1 for devices... 1 USB Device(s) found
scanning usb for storage devices... 0 Storage Device(s) found
Hit any key to stop autoboot: 0
sunxi#

Quoted 2 lines

So... we cause a reset during USB scan and then fail to boot a second time?

Thanks for testing this.

I'm not sure if I have a Lime (I might do, will need to look). I was testing sunxi on a pcduino3 but USB does not work on that for reasons I was looking into (it just says lowlevel init failure due to moving to driver model for GPIO).

Quoted 4 lines

Quoted 2 lines

I will take a look. In the meantime, which commit breaks this? I could perhaps issue a pull for commits up to that point to reduce the load.

I haven't had a chance to bisect yet but I will in a few hours.

No need to, I've just completed a bisect, it points to:

5bca5a6303f3526ab2cf9c0a62cd26c16e0d5c2f is the first bad commit commit 5bca5a6303f3526ab2cf9c0a62cd26c16e0d5c2f

Author: Simon Glass <[email protected]>
Date:   Wed Mar 25 12:22:27 2015 -0600

dm: usb: Drop the EHCI weak functions

These are a pain with driver model because we might have different EHCI drivers which want to implement them differently. Now that they use consistent function signatures, we can in good conscience move them to a struct.

Signed-off-by Simon Glass <[email protected]>

Reviewed-by Marek Vasut <[email protected]>

I'm going to first spend some time with my family now, I may look into this later tonight, or otherwise this weekend. I'll be sure to check mail first to avoid double work, so feel free to fix the problem while I'm relaxing :)

Regards,

Hans

Hi,

Quoted 144 lines · Hans de Goede

Hi,

Quoted 122 lines · Tom Rini

Quoted 121 lines · Simon Glass

Hi Tom,

Quoted 108 lines · Tom Rini

Quoted 28 lines · Simon Glass

Hi Tom,

Quoted 25 lines · Tom Rini

Quoted 22 lines · Simon Glass

Hi Tom,

As mentioned I reverted this patch as it conflicted with the dm tree and I suspect it might be buggy:

cd749658 usb_storage : scan all interfaces to find a storage device

Assuming this is OK and applies successfully I will rebase and resend this patch, then reply with some comments I have on the patch.

The following changes since commit 4564faeafbf11feb839e2e3f927be2f1a919ba96:

ti: dwc3: Enable clocks in enable_basic_clocks() in hw_data.c
(2015-04-16 15:08:36 -0400)

are available in the git repository at:

http://git.denx.de/u-boot-dm.git

for you to fetch changes up to 2e6263093b3a5c2d2c586afaedfd346d6628f784:

Quoted 7 lines

Quoted 5 lines

Quoted 2 lines

sandbox: exynos: Move CONFIG_SOUND_SANDBOX to Kconfig (2015-04-16
20:47:57 -0600)

With this PR, am335x_boneblack (which has DM enabled) no longer functions. I'm running a bisect now, but heads up.

OK, I'll wait for your bisect - also what is the console output when it breaks?

OK, disregard Beaglebone Black error, that was me (need to remember that eMMC boot only works off of am335x_boneblack_config). But, A20-OLinuXino-Lime2_defconfig is broken by this. The error log:
Command(A20 OLinuXino Lime2 console)> on
(user:trini) Power turned on

U-Boot SPL 2015.04-00342-g2e62630 (Apr 17 2015 - 12:40:45)
DRAM: 1024 MiB

CPU: 912000000Hz, AXI/AHB/APB: 3/2/2

U-Boot 2015.04-00342-g2e62630 (Apr 17 2015 - 12:40:45) Allwinner Technology

CPU:   Allwinner A20 (SUN7I)
I2C:   ready
DRAM:  1 GiB
MMC:   SUNXI SD/MMC: 0

*** Warning - bad CRC, using default environment

In:    serial
Out:   serial
Err:   serial
SCSI:  SUNXI SCSI INIT
SATA link 0 timeout.
AHCI 0001.0100 32 slots 1 ports 3 Gbps 0x1 impl SATA mode
flags: ncq stag pm led clo only pmp pio slum part ccc apst
Net:   dwmac.1c50000

starting USB...
USB0: USB EHCI 1.00
scanning bus 0 for devices...
U-Boot SPL 2015.04-00342-g2e62630 (Apr 17 2015 - 12:40:45)
DRAM: 1024 MiB

CPU: 912000000Hz, AXI/AHB/APB: 3/2/2

MMC Device 0 not found
spl: mmc device not found!!
### ERROR ### Please RESET the board ###

And good:
Command(A20 OLinuXino Lime2 console)> on
(user:trini) Power turned on

U-Boot SPL 2015.04-00121-g4564fae (Apr 17 2015 - 12:42:40)
DRAM: 1024 MiB

CPU: 912000000Hz, AXI/AHB/APB: 3/2/2

U-Boot 2015.04-00121-g4564fae (Apr 17 2015 - 12:42:40) Allwinner Technology

CPU:   Allwinner A20 (SUN7I)
I2C:   ready
DRAM:  1 GiB
MMC:   SUNXI SD/MMC: 0

*** Warning - bad CRC, using default environment

In:    serial
Out:   serial
Err:   serial
SCSI:  SUNXI SCSI INIT
SATA link 0 timeout.
AHCI 0001.0100 32 slots 1 ports 3 Gbps 0x1 impl SATA mode
flags: ncq stag pm led clo only pmp pio slum part ccc apst
Net:   dwmac.1c50000

starting USB...
USB0: USB EHCI 1.00
scanning bus 0 for devices... 1 USB Device(s) found
USB1: USB EHCI 1.00
scanning bus 1 for devices... 1 USB Device(s) found
scanning usb for storage devices... 0 Storage Device(s) found
Hit any key to stop autoboot: 0
sunxi#

Quoted 2 lines

So... we cause a reset during USB scan and then fail to boot a second time?

Thanks for testing this.

I'm not sure if I have a Lime (I might do, will need to look). I was testing sunxi on a pcduino3 but USB does not work on that for reasons I was looking into (it just says lowlevel init failure due to moving to driver model for GPIO).

Quoted 4 lines

Quoted 2 lines

I will take a look. In the meantime, which commit breaks this? I could perhaps issue a pull for commits up to that point to reduce the load.

I haven't had a chance to bisect yet but I will in a few hours.

No need to, I've just completed a bisect, it points to:

5bca5a6303f3526ab2cf9c0a62cd26c16e0d5c2f is the first bad commit commit 5bca5a6303f3526ab2cf9c0a62cd26c16e0d5c2f

Author: Simon Glass <[email protected]>
Date:   Wed Mar 25 12:22:27 2015 -0600

dm: usb: Drop the EHCI weak functions

These are a pain with driver model because we might have different EHCI drivers which want to implement them differently. Now that they use consistent function signatures, we can in good conscience move them to a struct.

Quoted 7 lines

Signed-off-by Simon Glass <[email protected]>

Reviewed-by Marek Vasut <[email protected]>

I'm going to first spend some time with my family now, I may look into this later tonight, or otherwise this weekend. I'll be sure to check mail first to avoid double work, so feel free to fix the problem while I'm relaxing :)

Ok, so I could not help myself and took a quick look at the patch causing the issue, this fixes the reset on usb scan problem:

drivers/usb/host/ehci-sunxi.c +2 -0

index eda9f69..a847ac5 100644
@@ -34,6 +34,8 @@ int ehci_hcd_init(int index, enum usb_init_type init, struct ehci_hccr **hccr,
              (uint32_t)*hccr, (uint32_t)*hcor,
              (uint32_t)HC_LENGTH(ehci_readl(&(*hccr)->cr_capbase)));
 
+ ehci_set_controller_priv(index, NULL, NULL);
+
        return 0;
 }
 

And should probably be squashed into the original patch to avoid bisect problems.

But with this in place, all is still not well wrt non devicetree usb, usb keyboard support does not work, "usb tree" says:

USB device tree:
1 Hub (480 Mb/s, 0mA)
| u-boot EHCI Host Controller
|

  +-2  Hub (480 Mb/s, 100mA)
    |
    +-3  Hub (12 Mb/s, 100mA)
      |
      | -1  See Interface (12 Mb/s, 0mA)
      |

Note the -1 as device number for the "See Interface" device.

This particular usb setup used to work fine.

I guess this is another issue to git bisect, no idea when I'll get around to that.

Hi,

Quoted 144 lines · Hans de Goede

Hi,

Quoted 122 lines · Tom Rini

Quoted 121 lines · Simon Glass

Hi Tom,

Quoted 108 lines · Tom Rini

Quoted 28 lines · Simon Glass

Hi Tom,

Quoted 25 lines · Tom Rini

Quoted 22 lines · Simon Glass

Hi Tom,

As mentioned I reverted this patch as it conflicted with the dm tree and I suspect it might be buggy:

cd749658 usb_storage : scan all interfaces to find a storage device

Assuming this is OK and applies successfully I will rebase and resend this patch, then reply with some comments I have on the patch.

The following changes since commit 4564faeafbf11feb839e2e3f927be2f1a919ba96:

ti: dwc3: Enable clocks in enable_basic_clocks() in hw_data.c
(2015-04-16 15:08:36 -0400)

are available in the git repository at:

http://git.denx.de/u-boot-dm.git

for you to fetch changes up to 2e6263093b3a5c2d2c586afaedfd346d6628f784:

Quoted 7 lines

Quoted 5 lines

Quoted 2 lines

sandbox: exynos: Move CONFIG_SOUND_SANDBOX to Kconfig (2015-04-16
20:47:57 -0600)

With this PR, am335x_boneblack (which has DM enabled) no longer functions. I'm running a bisect now, but heads up.

OK, I'll wait for your bisect - also what is the console output when it breaks?

OK, disregard Beaglebone Black error, that was me (need to remember that eMMC boot only works off of am335x_boneblack_config). But, A20-OLinuXino-Lime2_defconfig is broken by this. The error log:
Command(A20 OLinuXino Lime2 console)> on
(user:trini) Power turned on

U-Boot SPL 2015.04-00342-g2e62630 (Apr 17 2015 - 12:40:45)
DRAM: 1024 MiB

CPU: 912000000Hz, AXI/AHB/APB: 3/2/2

U-Boot 2015.04-00342-g2e62630 (Apr 17 2015 - 12:40:45) Allwinner Technology

CPU:   Allwinner A20 (SUN7I)
I2C:   ready
DRAM:  1 GiB
MMC:   SUNXI SD/MMC: 0

*** Warning - bad CRC, using default environment

In:    serial
Out:   serial
Err:   serial
SCSI:  SUNXI SCSI INIT
SATA link 0 timeout.
AHCI 0001.0100 32 slots 1 ports 3 Gbps 0x1 impl SATA mode
flags: ncq stag pm led clo only pmp pio slum part ccc apst
Net:   dwmac.1c50000

starting USB...
USB0: USB EHCI 1.00
scanning bus 0 for devices...
U-Boot SPL 2015.04-00342-g2e62630 (Apr 17 2015 - 12:40:45)
DRAM: 1024 MiB

CPU: 912000000Hz, AXI/AHB/APB: 3/2/2

MMC Device 0 not found
spl: mmc device not found!!
### ERROR ### Please RESET the board ###

And good:
Command(A20 OLinuXino Lime2 console)> on
(user:trini) Power turned on

U-Boot SPL 2015.04-00121-g4564fae (Apr 17 2015 - 12:42:40)
DRAM: 1024 MiB

CPU: 912000000Hz, AXI/AHB/APB: 3/2/2

U-Boot 2015.04-00121-g4564fae (Apr 17 2015 - 12:42:40) Allwinner Technology

CPU:   Allwinner A20 (SUN7I)
I2C:   ready
DRAM:  1 GiB
MMC:   SUNXI SD/MMC: 0

*** Warning - bad CRC, using default environment

In:    serial
Out:   serial
Err:   serial
SCSI:  SUNXI SCSI INIT
SATA link 0 timeout.
AHCI 0001.0100 32 slots 1 ports 3 Gbps 0x1 impl SATA mode
flags: ncq stag pm led clo only pmp pio slum part ccc apst
Net:   dwmac.1c50000

starting USB...
USB0: USB EHCI 1.00
scanning bus 0 for devices... 1 USB Device(s) found
USB1: USB EHCI 1.00
scanning bus 1 for devices... 1 USB Device(s) found
scanning usb for storage devices... 0 Storage Device(s) found
Hit any key to stop autoboot: 0
sunxi#

Quoted 2 lines

So... we cause a reset during USB scan and then fail to boot a second time?

Thanks for testing this.

I'm not sure if I have a Lime (I might do, will need to look). I was testing sunxi on a pcduino3 but USB does not work on that for reasons I was looking into (it just says lowlevel init failure due to moving to driver model for GPIO).

Quoted 4 lines

Quoted 2 lines

I will take a look. In the meantime, which commit breaks this? I could perhaps issue a pull for commits up to that point to reduce the load.

I haven't had a chance to bisect yet but I will in a few hours.

No need to, I've just completed a bisect, it points to:

5bca5a6303f3526ab2cf9c0a62cd26c16e0d5c2f is the first bad commit commit 5bca5a6303f3526ab2cf9c0a62cd26c16e0d5c2f

Author: Simon Glass <[email protected]>
Date:   Wed Mar 25 12:22:27 2015 -0600

dm: usb: Drop the EHCI weak functions

These are a pain with driver model because we might have different EHCI drivers which want to implement them differently. Now that they use consistent function signatures, we can in good conscience move them to a struct.

Quoted 7 lines

Signed-off-by Simon Glass <[email protected]>

Reviewed-by Marek Vasut <[email protected]>

I'm going to first spend some time with my family now, I may look into this later tonight, or otherwise this weekend. I'll be sure to check mail first to avoid double work, so feel free to fix the problem while I'm relaxing :)

Ok, so I could not help myself and took a quick look at the patch causing the issue, this fixes the reset on usb scan problem:

drivers/usb/host/ehci-sunxi.c +2 -0

index eda9f69..a847ac5 100644
@@ -34,6 +34,8 @@ int ehci_hcd_init(int index, enum usb_init_type init, struct ehci_hccr **hccr,
              (uint32_t)*hccr, (uint32_t)*hcor,
              (uint32_t)HC_LENGTH(ehci_readl(&(*hccr)->cr_capbase)));
 
+ ehci_set_controller_priv(index, NULL, NULL);
+
        return 0;
 }
 

And should probably be squashed into the original patch to avoid bisect problems.

But with this in place, all is still not well wrt non devicetree usb, usb keyboard support does not work, "usb tree" says:

USB device tree:
1 Hub (480 Mb/s, 0mA)
| u-boot EHCI Host Controller
|

  +-2  Hub (480 Mb/s, 100mA)
    |
    +-3  Hub (12 Mb/s, 100mA)
      |
      | -1  See Interface (12 Mb/s, 0mA)
      |

Note the -1 as device number for the "See Interface" device.

This particular usb setup used to work fine.

I guess this is another issue to git bisect, no idea when I'll get around to that.

Quoted 188 lines · Hans de Goede

Hi,

Quoted 144 lines · Hans de Goede

Hi,

Quoted 122 lines · Tom Rini

Quoted 121 lines · Simon Glass

Hi Tom,

Quoted 108 lines · Tom Rini

Quoted 28 lines · Simon Glass

Hi Tom,

Quoted 25 lines · Tom Rini

Quoted 22 lines · Simon Glass

Hi Tom,

As mentioned I reverted this patch as it conflicted with the dm tree and I suspect it might be buggy:

cd749658 usb_storage : scan all interfaces to find a storage device

Assuming this is OK and applies successfully I will rebase and resend this patch, then reply with some comments I have on the patch.

The following changes since commit 4564faeafbf11feb839e2e3f927be2f1a919ba96:

ti: dwc3: Enable clocks in enable_basic_clocks() in hw_data.c
(2015-04-16 15:08:36 -0400)

are available in the git repository at:

http://git.denx.de/u-boot-dm.git

for you to fetch changes up to 2e6263093b3a5c2d2c586afaedfd346d6628f784:

Quoted 7 lines

Quoted 5 lines

Quoted 2 lines

sandbox: exynos: Move CONFIG_SOUND_SANDBOX to Kconfig (2015-04-16
20:47:57 -0600)

With this PR, am335x_boneblack (which has DM enabled) no longer functions. I'm running a bisect now, but heads up.

OK, I'll wait for your bisect - also what is the console output when it breaks?

OK, disregard Beaglebone Black error, that was me (need to remember that eMMC boot only works off of am335x_boneblack_config). But, A20-OLinuXino-Lime2_defconfig is broken by this. The error log:
Command(A20 OLinuXino Lime2 console)> on
(user:trini) Power turned on

U-Boot SPL 2015.04-00342-g2e62630 (Apr 17 2015 - 12:40:45)
DRAM: 1024 MiB

CPU: 912000000Hz, AXI/AHB/APB: 3/2/2

U-Boot 2015.04-00342-g2e62630 (Apr 17 2015 - 12:40:45) Allwinner Technology

CPU:   Allwinner A20 (SUN7I)
I2C:   ready
DRAM:  1 GiB
MMC:   SUNXI SD/MMC: 0

*** Warning - bad CRC, using default environment

In:    serial
Out:   serial
Err:   serial
SCSI:  SUNXI SCSI INIT
SATA link 0 timeout.
AHCI 0001.0100 32 slots 1 ports 3 Gbps 0x1 impl SATA mode
flags: ncq stag pm led clo only pmp pio slum part ccc apst
Net:   dwmac.1c50000

starting USB...
USB0: USB EHCI 1.00
scanning bus 0 for devices...
U-Boot SPL 2015.04-00342-g2e62630 (Apr 17 2015 - 12:40:45)
DRAM: 1024 MiB

CPU: 912000000Hz, AXI/AHB/APB: 3/2/2

MMC Device 0 not found
spl: mmc device not found!!
### ERROR ### Please RESET the board ###

And good:
Command(A20 OLinuXino Lime2 console)> on
(user:trini) Power turned on

U-Boot SPL 2015.04-00121-g4564fae (Apr 17 2015 - 12:42:40)
DRAM: 1024 MiB

CPU: 912000000Hz, AXI/AHB/APB: 3/2/2

U-Boot 2015.04-00121-g4564fae (Apr 17 2015 - 12:42:40) Allwinner Technology

CPU:   Allwinner A20 (SUN7I)
I2C:   ready
DRAM:  1 GiB
MMC:   SUNXI SD/MMC: 0

*** Warning - bad CRC, using default environment

In:    serial
Out:   serial
Err:   serial
SCSI:  SUNXI SCSI INIT
SATA link 0 timeout.
AHCI 0001.0100 32 slots 1 ports 3 Gbps 0x1 impl SATA mode
flags: ncq stag pm led clo only pmp pio slum part ccc apst
Net:   dwmac.1c50000

starting USB...
USB0: USB EHCI 1.00
scanning bus 0 for devices... 1 USB Device(s) found
USB1: USB EHCI 1.00
scanning bus 1 for devices... 1 USB Device(s) found
scanning usb for storage devices... 0 Storage Device(s) found
Hit any key to stop autoboot: 0
sunxi#

Quoted 2 lines

So... we cause a reset during USB scan and then fail to boot a second time?

Thanks for testing this.

I'm not sure if I have a Lime (I might do, will need to look). I was testing sunxi on a pcduino3 but USB does not work on that for reasons I was looking into (it just says lowlevel init failure due to moving to driver model for GPIO).

Quoted 4 lines

Quoted 2 lines

I will take a look. In the meantime, which commit breaks this? I could perhaps issue a pull for commits up to that point to reduce the load.

I haven't had a chance to bisect yet but I will in a few hours.

No need to, I've just completed a bisect, it points to:

5bca5a6303f3526ab2cf9c0a62cd26c16e0d5c2f is the first bad commit commit 5bca5a6303f3526ab2cf9c0a62cd26c16e0d5c2f

Author: Simon Glass <[email protected]>
Date:   Wed Mar 25 12:22:27 2015 -0600

dm: usb: Drop the EHCI weak functions

These are a pain with driver model because we might have different EHCI drivers which want to implement them differently. Now that they use consistent function signatures, we can in good conscience move them to a struct.

Quoted 7 lines

Signed-off-by Simon Glass <[email protected]>

Reviewed-by Marek Vasut <[email protected]>

I'm going to first spend some time with my family now, I may look into this later tonight, or otherwise this weekend. I'll be sure to check mail first to avoid double work, so feel free to fix the problem while I'm relaxing :)

Ok, so I could not help myself and took a quick look at the patch causing the issue, this fixes the reset on usb scan problem:

drivers/usb/host/ehci-sunxi.c +2 -0

index eda9f69..a847ac5 100644
@@ -34,6 +34,8 @@ int ehci_hcd_init(int index, enum usb_init_type init, struct ehci_hccr **hccr,
              (uint32_t)*hccr, (uint32_t)*hcor,
              (uint32_t)HC_LENGTH(ehci_readl(&(*hccr)->cr_capbase)));
 
+ ehci_set_controller_priv(index, NULL, NULL);
+
        return 0;
 }
 

And should probably be squashed into the original patch to avoid bisect problems.

But with this in place, all is still not well wrt non devicetree usb, usb keyboard support does not work, "usb tree" says:

USB device tree:
1 Hub (480 Mb/s, 0mA)
| u-boot EHCI Host Controller
|

  +-2  Hub (480 Mb/s, 100mA)
    |
    +-3  Hub (12 Mb/s, 100mA)
      |
      | -1  See Interface (12 Mb/s, 0mA)
      |

Quoted 6 lines

Note the -1 as device number for the "See Interface" device.

This particular usb setup used to work fine.

I guess this is another issue to git bisect, no idea when I'll get around to that.

So, another bisect. The problem commit is:
commit 5bbc627e33a9b3666438e03d560d06ab3de28f6f

Author: Simon Glass <[email protected]>
Date:   Wed Mar 25 12:22:06 2015 -0600

dm: usb: Split out more code from usb_new_device()

Move the code that sets up the device with a new address into its own function, usb_prepare_device().

Signed-off-by Simon Glass <[email protected]>

Reviewed-by Marek Vasut <[email protected]>

Prior to this commit on a non-DM board (my A20 Lime2) a USB keyboard being inserted causes:
scanning bus 1 for devices... cannot reset port 1!?
1 USB Device(s) found
And then at the end, USB is "running" and I can usb tree. Afterwards, same message about reset but then No USB Device found.

Hi,

Quoted 3 lines · Hans de Goede

Hi,

On 17-04-15 19:53, Tom Rini wrote:

Quoted 16 lines

Quoted 1 line

I haven't had a chance to bisect yet but I will in a few hours.

No need to, I've just completed a bisect, it points to:

5bca5a6303f3526ab2cf9c0a62cd26c16e0d5c2f is the first bad commit commit 5bca5a6303f3526ab2cf9c0a62cd26c16e0d5c2f

Author: Simon Glass <[email protected]>
Date:   Wed Mar 25 12:22:27 2015 -0600

dm: usb: Drop the EHCI weak functions

These are a pain with driver model because we might have different EHCI drivers which want to implement them differently. Now that they use consistent function signatures, we can in good conscience move them to a struct.

Quoted 7 lines

Signed-off-by Simon Glass <[email protected]>

Reviewed-by Marek Vasut <[email protected]>

I'm going to first spend some time with my family now, I may look into this later tonight, or otherwise this weekend. I'll be sure to check mail first to avoid double work, so feel free to fix the problem while I'm relaxing :)

Ok, so I could not help myself and took a quick look at the patch causing the issue, this fixes the reset on usb scan problem:

drivers/usb/host/ehci-sunxi.c +2 -0

index eda9f69..a847ac5 100644
@@ -34,6 +34,8 @@ int ehci_hcd_init(int index, enum usb_init_type init, struct ehci_hccr **hccr,
               (uint32_t)*hccr, (uint32_t)*hcor,
               (uint32_t)HC_LENGTH(ehci_readl(&(*hccr)->cr_capbase)));
 
+ ehci_set_controller_priv(index, NULL, NULL);
+
         return 0;
  }
 

And should probably be squashed into the original patch to avoid bisect problems.

But with this in place, all is still not well wrt non devicetree usb, usb keyboard support does not work, "usb tree" says:

USB device tree:

   1  Hub (480 Mb/s, 0mA)
   |  u-boot EHCI Host Controller
   |
   +-2  Hub (480 Mb/s, 100mA)
     |
     +-3  Hub (12 Mb/s, 100mA)
       |
       | -1  See Interface (12 Mb/s, 0mA)
       |

Note the -1 as device number for the "See Interface" device.

This particular usb setup used to work fine.

I guess this is another issue to git bisect, no idea when I'll get around to that.

Hi,

Quoted 6 lines · Hans de Goede

Hi,

Quoted 3 lines · Hans de Goede

Hi,

On 17-04-15 19:53, Tom Rini wrote:

<snip>

Quoted 57 lines

Quoted 16 lines

Quoted 1 line

I haven't had a chance to bisect yet but I will in a few hours.

No need to, I've just completed a bisect, it points to:

5bca5a6303f3526ab2cf9c0a62cd26c16e0d5c2f is the first bad commit commit 5bca5a6303f3526ab2cf9c0a62cd26c16e0d5c2f

Author: Simon Glass <[email protected]>
Date:   Wed Mar 25 12:22:27 2015 -0600

dm: usb: Drop the EHCI weak functions

These are a pain with driver model because we might have different EHCI drivers which want to implement them differently. Now that they use consistent function signatures, we can in good conscience move them to a struct.

Quoted 7 lines

Signed-off-by Simon Glass <[email protected]>

Reviewed-by Marek Vasut <[email protected]>

I'm going to first spend some time with my family now, I may look into this later tonight, or otherwise this weekend. I'll be sure to check mail first to avoid double work, so feel free to fix the problem while I'm relaxing :)

Ok, so I could not help myself and took a quick look at the patch causing the issue, this fixes the reset on usb scan problem:

drivers/usb/host/ehci-sunxi.c +2 -0

index eda9f69..a847ac5 100644
@@ -34,6 +34,8 @@ int ehci_hcd_init(int index, enum usb_init_type init, struct ehci_hccr **hccr,
               (uint32_t)*hccr, (uint32_t)*hcor,
               (uint32_t)HC_LENGTH(ehci_readl(&(*hccr)->cr_capbase)));
 
+ ehci_set_controller_priv(index, NULL, NULL);
+
         return 0;
  }
 

And should probably be squashed into the original patch to avoid bisect problems.

But with this in place, all is still not well wrt non devicetree usb, usb keyboard support does not work, "usb tree" says:

USB device tree:

   1  Hub (480 Mb/s, 0mA)
   |  u-boot EHCI Host Controller
   |
   +-2  Hub (480 Mb/s, 100mA)
     |
     +-3  Hub (12 Mb/s, 100mA)
       |
       | -1  See Interface (12 Mb/s, 0mA)
       |

Quoted 6 lines

Note the -1 as device number for the "See Interface" device.

This particular usb setup used to work fine.

I guess this is another issue to git bisect, no idea when I'll get around to that.

Ok, so I've done a git bisect of this (using a branch with my patch for the usb-reset issue squashed into the original commit to keep things bisectable), and it points to:

commit 3f7af70db23fc1c6b8f9e1bd966cadf2eb139f93

Author: Simon Glass <[email protected]>
Date:   Wed Mar 25 12:22:07 2015 -0600

dm: usb: Complete the splitting up of usb_new_device()

This function now calls usb_setup_device() to set up the device and usb_hub_probe() to check if it is a hub. The XHCI special case is now a parameter to usb_setup_device(). The latter will be used by the USB uclass when it is added, since it does not rely on any CONFIGs or legacy data structures.

Signed-off-by Simon Glass <[email protected]>

Reviewed-by Marek Vasut <[email protected]>

(the commit id may be of because as said I'm using a custom branch for this).

I'll see if I can figure out why that commit breaks things, but I thought I would share the bisect result ASAP to avoid double work.

Hi,

Quoted 92 lines · Hans de Goede

Hi,

Quoted 6 lines · Hans de Goede

Hi,

Quoted 3 lines · Hans de Goede

Hi,

On 17-04-15 19:53, Tom Rini wrote:

<snip>

Quoted 57 lines

Quoted 16 lines

Quoted 1 line

I haven't had a chance to bisect yet but I will in a few hours.

No need to, I've just completed a bisect, it points to:

5bca5a6303f3526ab2cf9c0a62cd26c16e0d5c2f is the first bad commit commit 5bca5a6303f3526ab2cf9c0a62cd26c16e0d5c2f

Author: Simon Glass <[email protected]>
Date:   Wed Mar 25 12:22:27 2015 -0600

dm: usb: Drop the EHCI weak functions

These are a pain with driver model because we might have different EHCI drivers which want to implement them differently. Now that they use consistent function signatures, we can in good conscience move them to a struct.

Quoted 7 lines

Signed-off-by Simon Glass <[email protected]>

Reviewed-by Marek Vasut <[email protected]>

I'm going to first spend some time with my family now, I may look into this later tonight, or otherwise this weekend. I'll be sure to check mail first to avoid double work, so feel free to fix the problem while I'm relaxing :)

Ok, so I could not help myself and took a quick look at the patch causing the issue, this fixes the reset on usb scan problem:

drivers/usb/host/ehci-sunxi.c +2 -0

index eda9f69..a847ac5 100644
@@ -34,6 +34,8 @@ int ehci_hcd_init(int index, enum usb_init_type init, struct ehci_hccr **hccr,
              (uint32_t)*hccr, (uint32_t)*hcor,
              (uint32_t)HC_LENGTH(ehci_readl(&(*hccr)->cr_capbase)));
 
+ ehci_set_controller_priv(index, NULL, NULL);
+
        return 0;
 }
 

And should probably be squashed into the original patch to avoid bisect problems.

But with this in place, all is still not well wrt non devicetree usb, usb keyboard support does not work, "usb tree" says:

USB device tree:
1 Hub (480 Mb/s, 0mA)
| u-boot EHCI Host Controller
|

  +-2  Hub (480 Mb/s, 100mA)
    |
    +-3  Hub (12 Mb/s, 100mA)
      |
      | -1  See Interface (12 Mb/s, 0mA)
      |

Quoted 6 lines

Note the -1 as device number for the "See Interface" device.

This particular usb setup used to work fine.

I guess this is another issue to git bisect, no idea when I'll get around to that.

Ok, so I've done a git bisect of this (using a branch with my patch for the usb-reset issue squashed into the original commit to keep things bisectable), and it points to:

commit 3f7af70db23fc1c6b8f9e1bd966cadf2eb139f93

Author: Simon Glass <[email protected]>
Date:   Wed Mar 25 12:22:07 2015 -0600

dm: usb: Complete the splitting up of usb_new_device()

This function now calls usb_setup_device() to set up the device and usb_hub_probe() to check if it is a hub. The XHCI special case is now a parameter to usb_setup_device(). The latter will be used by the USB uclass when it is added, since it does not rely on any CONFIGs or legacy data structures.

Quoted 7 lines

Signed-off-by Simon Glass <[email protected]>

Reviewed-by Marek Vasut <[email protected]>

(the commit id may be of because as said I'm using a custom branch for this).

I'll see if I can figure out why that commit breaks things, but I thought I would share the bisect result ASAP to avoid double work.

Attached are 2 patches (to be squashed into the original for bisectability) which fix things. See the commit messages for details.

Note these do not apply on top of u-boot-dm/master, they apply on top of the offending commit.

What I've done to get these "integrated" into my dm-master branch is:

1) checkout the offending commit
2) git am the 2 patches
3) note down the commit id of the 2 patches as just applied
4) checkout u-boot-dm/master
5) git rebase -i origin/master
And then add lines with "pick <commit-id>" directly after the line for the troublesome commit

And then when everything looks good, redo the rebase -i and change the pick into fixup.

Quoted 119 lines · Hans de Goede

Hi,

Quoted 92 lines · Hans de Goede

Hi,

Quoted 6 lines · Hans de Goede

Hi,

Quoted 3 lines · Hans de Goede

Hi,

On 17-04-15 19:53, Tom Rini wrote:

<snip>

Quoted 57 lines

Quoted 16 lines

Quoted 1 line

I haven't had a chance to bisect yet but I will in a few hours.

No need to, I've just completed a bisect, it points to:

5bca5a6303f3526ab2cf9c0a62cd26c16e0d5c2f is the first bad commit commit 5bca5a6303f3526ab2cf9c0a62cd26c16e0d5c2f

Author: Simon Glass <[email protected]>
Date:   Wed Mar 25 12:22:27 2015 -0600

dm: usb: Drop the EHCI weak functions

These are a pain with driver model because we might have different EHCI drivers which want to implement them differently. Now that they use consistent function signatures, we can in good conscience move them to a struct.

Quoted 7 lines

Signed-off-by Simon Glass <[email protected]>

Reviewed-by Marek Vasut <[email protected]>

I'm going to first spend some time with my family now, I may look into this later tonight, or otherwise this weekend. I'll be sure to check mail first to avoid double work, so feel free to fix the problem while I'm relaxing :)

Ok, so I could not help myself and took a quick look at the patch causing the issue, this fixes the reset on usb scan problem:

drivers/usb/host/ehci-sunxi.c +2 -0

index eda9f69..a847ac5 100644
@@ -34,6 +34,8 @@ int ehci_hcd_init(int index, enum usb_init_type init, struct ehci_hccr **hccr,
              (uint32_t)*hccr, (uint32_t)*hcor,
              (uint32_t)HC_LENGTH(ehci_readl(&(*hccr)->cr_capbase)));
 
+ ehci_set_controller_priv(index, NULL, NULL);
+
        return 0;
 }
 

And should probably be squashed into the original patch to avoid bisect problems.

But with this in place, all is still not well wrt non devicetree usb, usb keyboard support does not work, "usb tree" says:

USB device tree:
1 Hub (480 Mb/s, 0mA)
| u-boot EHCI Host Controller
|

  +-2  Hub (480 Mb/s, 100mA)
    |
    +-3  Hub (12 Mb/s, 100mA)
      |
      | -1  See Interface (12 Mb/s, 0mA)
      |

Quoted 6 lines

Note the -1 as device number for the "See Interface" device.

This particular usb setup used to work fine.

I guess this is another issue to git bisect, no idea when I'll get around to that.

Ok, so I've done a git bisect of this (using a branch with my patch for the usb-reset issue squashed into the original commit to keep things bisectable), and it points to:

commit 3f7af70db23fc1c6b8f9e1bd966cadf2eb139f93

Author: Simon Glass <[email protected]>
Date:   Wed Mar 25 12:22:07 2015 -0600

dm: usb: Complete the splitting up of usb_new_device()

This function now calls usb_setup_device() to set up the device and usb_hub_probe() to check if it is a hub. The XHCI special case is now a parameter to usb_setup_device(). The latter will be used by the USB uclass when it is added, since it does not rely on any CONFIGs or legacy data structures.

Quoted 7 lines

Signed-off-by Simon Glass <[email protected]>

Reviewed-by Marek Vasut <[email protected]>

(the commit id may be of because as said I'm using a custom branch for this).

I'll see if I can figure out why that commit breaks things, but I thought I would share the bisect result ASAP to avoid double work.

Attached are 2 patches (to be squashed into the original for bisectability) which fix things. See the commit messages for details.

Note these do not apply on top of u-boot-dm/master, they apply on top of the offending commit.

What I've done to get these "integrated" into my dm-master branch is:

1) checkout the offending commit
2) git am the 2 patches
3) note down the commit id of the 2 patches as just applied
4) checkout u-boot-dm/master
5) git rebase -i origin/master
And then add lines with "pick <commit-id>" directly after the line for the troublesome commit

Quoted 2 lines

And then when everything looks good, redo the rebase -i and change the pick into fixup.

Interesting, you bisected down to a slightly different commit for the problem I'm having also with a keyboard. I'll squash yours in, in my local testing branch, and see if that helps my issue as well, thanks!

Quoted 123 lines · Tom Rini

Quoted 121 lines · Hans de Goede

Hi,

Quoted 92 lines · Hans de Goede

Hi,

Quoted 6 lines · Hans de Goede

Hi,

Quoted 3 lines · Hans de Goede

Hi,

On 17-04-15 19:53, Tom Rini wrote:

<snip>

Quoted 57 lines

Quoted 16 lines

Quoted 1 line

I haven't had a chance to bisect yet but I will in a few hours.

No need to, I've just completed a bisect, it points to:

5bca5a6303f3526ab2cf9c0a62cd26c16e0d5c2f is the first bad commit commit 5bca5a6303f3526ab2cf9c0a62cd26c16e0d5c2f

Author: Simon Glass <[email protected]>
Date:   Wed Mar 25 12:22:27 2015 -0600

dm: usb: Drop the EHCI weak functions

These are a pain with driver model because we might have different EHCI drivers which want to implement them differently. Now that they use consistent function signatures, we can in good conscience move them to a struct.

Quoted 7 lines

Signed-off-by Simon Glass <[email protected]>

Reviewed-by Marek Vasut <[email protected]>

I'm going to first spend some time with my family now, I may look into this later tonight, or otherwise this weekend. I'll be sure to check mail first to avoid double work, so feel free to fix the problem while I'm relaxing :)

Ok, so I could not help myself and took a quick look at the patch causing the issue, this fixes the reset on usb scan problem:

drivers/usb/host/ehci-sunxi.c +2 -0

index eda9f69..a847ac5 100644
@@ -34,6 +34,8 @@ int ehci_hcd_init(int index, enum usb_init_type init, struct ehci_hccr **hccr,
              (uint32_t)*hccr, (uint32_t)*hcor,
              (uint32_t)HC_LENGTH(ehci_readl(&(*hccr)->cr_capbase)));
 
+ ehci_set_controller_priv(index, NULL, NULL);
+
        return 0;
 }
 

And should probably be squashed into the original patch to avoid bisect problems.

But with this in place, all is still not well wrt non devicetree usb, usb keyboard support does not work, "usb tree" says:

USB device tree:
1 Hub (480 Mb/s, 0mA)
| u-boot EHCI Host Controller
|

  +-2  Hub (480 Mb/s, 100mA)
    |
    +-3  Hub (12 Mb/s, 100mA)
      |
      | -1  See Interface (12 Mb/s, 0mA)
      |

Quoted 6 lines

Note the -1 as device number for the "See Interface" device.

This particular usb setup used to work fine.

I guess this is another issue to git bisect, no idea when I'll get around to that.

Ok, so I've done a git bisect of this (using a branch with my patch for the usb-reset issue squashed into the original commit to keep things bisectable), and it points to:

commit 3f7af70db23fc1c6b8f9e1bd966cadf2eb139f93

Author: Simon Glass <[email protected]>
Date:   Wed Mar 25 12:22:07 2015 -0600

dm: usb: Complete the splitting up of usb_new_device()

This function now calls usb_setup_device() to set up the device and usb_hub_probe() to check if it is a hub. The XHCI special case is now a parameter to usb_setup_device(). The latter will be used by the USB uclass when it is added, since it does not rely on any CONFIGs or legacy data structures.

Quoted 7 lines

Signed-off-by Simon Glass <[email protected]>

Reviewed-by Marek Vasut <[email protected]>

(the commit id may be of because as said I'm using a custom branch for this).

I'll see if I can figure out why that commit breaks things, but I thought I would share the bisect result ASAP to avoid double work.

Attached are 2 patches (to be squashed into the original for bisectability) which fix things. See the commit messages for details.

Note these do not apply on top of u-boot-dm/master, they apply on top of the offending commit.

What I've done to get these "integrated" into my dm-master branch is:

1) checkout the offending commit
2) git am the 2 patches
3) note down the commit id of the 2 patches as just applied
4) checkout u-boot-dm/master
5) git rebase -i origin/master
And then add lines with "pick <commit-id>" directly after the line for the troublesome commit

And then when everything looks good, redo the rebase -i and change the pick into fixup.

Quoted 3 lines

Interesting, you bisected down to a slightly different commit for the problem I'm having also with a keyboard. I'll squash yours in, in my local testing branch, and see if that helps my issue as well, thanks!

Also fixes the issue I saw.

Tested-by Tom Rini <[email protected]>

Hi,

Quoted 129 lines · Tom Rini

Quoted 126 lines · Tom Rini

Quoted 119 lines · Hans de Goede

Hi,

Quoted 92 lines · Hans de Goede

Hi,

Quoted 6 lines · Hans de Goede

Hi,

Quoted 3 lines · Hans de Goede

Hi,

On 17-04-15 19:53, Tom Rini wrote:

<snip>

Quoted 57 lines

Quoted 16 lines

Quoted 1 line

I haven't had a chance to bisect yet but I will in a few hours.

No need to, I've just completed a bisect, it points to:

5bca5a6303f3526ab2cf9c0a62cd26c16e0d5c2f is the first bad commit commit 5bca5a6303f3526ab2cf9c0a62cd26c16e0d5c2f

Author: Simon Glass <[email protected]>
Date:   Wed Mar 25 12:22:27 2015 -0600

dm: usb: Drop the EHCI weak functions

These are a pain with driver model because we might have different EHCI drivers which want to implement them differently. Now that they use consistent function signatures, we can in good conscience move them to a struct.

Quoted 7 lines

Signed-off-by Simon Glass <[email protected]>

Reviewed-by Marek Vasut <[email protected]>

I'm going to first spend some time with my family now, I may look into this later tonight, or otherwise this weekend. I'll be sure to check mail first to avoid double work, so feel free to fix the problem while I'm relaxing :)

Ok, so I could not help myself and took a quick look at the patch causing the issue, this fixes the reset on usb scan problem:

drivers/usb/host/ehci-sunxi.c +2 -0

index eda9f69..a847ac5 100644
@@ -34,6 +34,8 @@ int ehci_hcd_init(int index, enum usb_init_type init, struct ehci_hccr **hccr,
              (uint32_t)*hccr, (uint32_t)*hcor,
              (uint32_t)HC_LENGTH(ehci_readl(&(*hccr)->cr_capbase)));
 
+ ehci_set_controller_priv(index, NULL, NULL);
+
        return 0;
 }
 

And should probably be squashed into the original patch to avoid bisect problems.

But with this in place, all is still not well wrt non devicetree usb, usb keyboard support does not work, "usb tree" says:

USB device tree:
1 Hub (480 Mb/s, 0mA)
| u-boot EHCI Host Controller
|

  +-2  Hub (480 Mb/s, 100mA)
    |
    +-3  Hub (12 Mb/s, 100mA)
      |
      | -1  See Interface (12 Mb/s, 0mA)
      |

Quoted 6 lines

Note the -1 as device number for the "See Interface" device.

This particular usb setup used to work fine.

I guess this is another issue to git bisect, no idea when I'll get around to that.

Ok, so I've done a git bisect of this (using a branch with my patch for the usb-reset issue squashed into the original commit to keep things bisectable), and it points to:

commit 3f7af70db23fc1c6b8f9e1bd966cadf2eb139f93

Author: Simon Glass <[email protected]>
Date:   Wed Mar 25 12:22:07 2015 -0600

dm: usb: Complete the splitting up of usb_new_device()

This function now calls usb_setup_device() to set up the device and usb_hub_probe() to check if it is a hub. The XHCI special case is now a parameter to usb_setup_device(). The latter will be used by the USB uclass when it is added, since it does not rely on any CONFIGs or legacy data structures.

Quoted 7 lines

Signed-off-by Simon Glass <[email protected]>

Reviewed-by Marek Vasut <[email protected]>

(the commit id may be of because as said I'm using a custom branch for this).

I'll see if I can figure out why that commit breaks things, but I thought I would share the bisect result ASAP to avoid double work.

Attached are 2 patches (to be squashed into the original for bisectability) which fix things. See the commit messages for details.

Note these do not apply on top of u-boot-dm/master, they apply on top of the offending commit.

What I've done to get these "integrated" into my dm-master branch is:

1) checkout the offending commit
2) git am the 2 patches
3) note down the commit id of the 2 patches as just applied
4) checkout u-boot-dm/master
5) git rebase -i origin/master
And then add lines with "pick <commit-id>" directly after the line for the troublesome commit

Quoted 2 lines

And then when everything looks good, redo the rebase -i and change the pick into fixup.

Interesting, you bisected down to a slightly different commit for the problem I'm having also with a keyboard. I'll squash yours in, in my local testing branch, and see if that helps my issue as well, thanks!

Quoted 3 lines

Also fixes the issue I saw.

Tested-by Tom Rini <[email protected]>

Thank you both, and sorry that I had such limited time the last few days to really dig into this.

Quoted 134 lines · Simon Glass

Hi,

Quoted 131 lines · Tom Rini

Quoted 120 lines · Tom Rini

Quoted 119 lines · Hans de Goede

Hi,

Quoted 92 lines · Hans de Goede

Hi,

Quoted 6 lines · Hans de Goede

Hi,

Quoted 3 lines · Hans de Goede

Hi,

On 17-04-15 19:53, Tom Rini wrote:

<snip>

Quoted 57 lines

Quoted 16 lines

Quoted 1 line

I haven't had a chance to bisect yet but I will in a few hours.

No need to, I've just completed a bisect, it points to:

5bca5a6303f3526ab2cf9c0a62cd26c16e0d5c2f is the first bad commit commit 5bca5a6303f3526ab2cf9c0a62cd26c16e0d5c2f

Author: Simon Glass <[email protected]>
Date:   Wed Mar 25 12:22:27 2015 -0600

dm: usb: Drop the EHCI weak functions

These are a pain with driver model because we might have different EHCI drivers which want to implement them differently. Now that they use consistent function signatures, we can in good conscience move them to a struct.

Quoted 7 lines

Signed-off-by Simon Glass <[email protected]>

Reviewed-by Marek Vasut <[email protected]>

I'm going to first spend some time with my family now, I may look into this later tonight, or otherwise this weekend. I'll be sure to check mail first to avoid double work, so feel free to fix the problem while I'm relaxing :)

Ok, so I could not help myself and took a quick look at the patch causing the issue, this fixes the reset on usb scan problem:

drivers/usb/host/ehci-sunxi.c +2 -0

index eda9f69..a847ac5 100644
@@ -34,6 +34,8 @@ int ehci_hcd_init(int index, enum usb_init_type init, struct ehci_hccr **hccr,
              (uint32_t)*hccr, (uint32_t)*hcor,
              (uint32_t)HC_LENGTH(ehci_readl(&(*hccr)->cr_capbase)));
 
+ ehci_set_controller_priv(index, NULL, NULL);
+
        return 0;
 }
 

And should probably be squashed into the original patch to avoid bisect problems.

But with this in place, all is still not well wrt non devicetree usb, usb keyboard support does not work, "usb tree" says:

USB device tree:
1 Hub (480 Mb/s, 0mA)
| u-boot EHCI Host Controller
|

  +-2  Hub (480 Mb/s, 100mA)
    |
    +-3  Hub (12 Mb/s, 100mA)
      |
      | -1  See Interface (12 Mb/s, 0mA)
      |

Quoted 6 lines

Note the -1 as device number for the "See Interface" device.

This particular usb setup used to work fine.

I guess this is another issue to git bisect, no idea when I'll get around to that.

Ok, so I've done a git bisect of this (using a branch with my patch for the usb-reset issue squashed into the original commit to keep things bisectable), and it points to:

commit 3f7af70db23fc1c6b8f9e1bd966cadf2eb139f93

Author: Simon Glass <[email protected]>
Date:   Wed Mar 25 12:22:07 2015 -0600

dm: usb: Complete the splitting up of usb_new_device()

This function now calls usb_setup_device() to set up the device and usb_hub_probe() to check if it is a hub. The XHCI special case is now a parameter to usb_setup_device(). The latter will be used by the USB uclass when it is added, since it does not rely on any CONFIGs or legacy data structures.

Quoted 7 lines

Signed-off-by Simon Glass <[email protected]>

Reviewed-by Marek Vasut <[email protected]>

(the commit id may be of because as said I'm using a custom branch for this).

I'll see if I can figure out why that commit breaks things, but I thought I would share the bisect result ASAP to avoid double work.

Attached are 2 patches (to be squashed into the original for bisectability) which fix things. See the commit messages for details.

Note these do not apply on top of u-boot-dm/master, they apply on top of the offending commit.

What I've done to get these "integrated" into my dm-master branch is:

1) checkout the offending commit
2) git am the 2 patches
3) note down the commit id of the 2 patches as just applied
4) checkout u-boot-dm/master
5) git rebase -i origin/master
And then add lines with "pick <commit-id>" directly after the line for the troublesome commit

Quoted 6 lines

Quoted 2 lines

And then when everything looks good, redo the rebase -i and change the pick into fixup.

Interesting, you bisected down to a slightly different commit for the problem I'm having also with a keyboard. I'll squash yours in, in my local testing branch, and see if that helps my issue as well, thanks!

Also fixes the issue I saw.

Quoted 4 lines

Quoted 1 line

Tested-by Tom Rini <[email protected]>

Thank you both, and sorry that I had such limited time the last few days to really dig into this.

No worries. It's almost like this is a community effort and not just "lets make Simon do all the DM work" ;) And thanks for doing so much of the DM work!

Hi,

Quoted 122 lines · Tom Rini

Quoted 121 lines · Simon Glass

Hi Tom,

Quoted 108 lines · Tom Rini

Quoted 28 lines · Simon Glass

Hi Tom,

Quoted 25 lines · Tom Rini

Quoted 22 lines · Simon Glass

Hi Tom,

As mentioned I reverted this patch as it conflicted with the dm tree and I suspect it might be buggy:

cd749658 usb_storage : scan all interfaces to find a storage device

Assuming this is OK and applies successfully I will rebase and resend this patch, then reply with some comments I have on the patch.

The following changes since commit 4564faeafbf11feb839e2e3f927be2f1a919ba96:

ti: dwc3: Enable clocks in enable_basic_clocks() in hw_data.c
(2015-04-16 15:08:36 -0400)

are available in the git repository at:

http://git.denx.de/u-boot-dm.git

for you to fetch changes up to 2e6263093b3a5c2d2c586afaedfd346d6628f784:

Quoted 7 lines

Quoted 5 lines

Quoted 2 lines

sandbox: exynos: Move CONFIG_SOUND_SANDBOX to Kconfig (2015-04-16
20:47:57 -0600)

With this PR, am335x_boneblack (which has DM enabled) no longer functions. I'm running a bisect now, but heads up.

OK, I'll wait for your bisect - also what is the console output when it breaks?

OK, disregard Beaglebone Black error, that was me (need to remember that eMMC boot only works off of am335x_boneblack_config). But, A20-OLinuXino-Lime2_defconfig is broken by this. The error log:
Command(A20 OLinuXino Lime2 console)> on
(user:trini) Power turned on

U-Boot SPL 2015.04-00342-g2e62630 (Apr 17 2015 - 12:40:45)
DRAM: 1024 MiB

CPU: 912000000Hz, AXI/AHB/APB: 3/2/2

U-Boot 2015.04-00342-g2e62630 (Apr 17 2015 - 12:40:45) Allwinner Technology

CPU:   Allwinner A20 (SUN7I)
I2C:   ready
DRAM:  1 GiB
MMC:   SUNXI SD/MMC: 0

*** Warning - bad CRC, using default environment

In:    serial
Out:   serial
Err:   serial
SCSI:  SUNXI SCSI INIT
SATA link 0 timeout.
AHCI 0001.0100 32 slots 1 ports 3 Gbps 0x1 impl SATA mode
flags: ncq stag pm led clo only pmp pio slum part ccc apst
Net:   dwmac.1c50000

starting USB...
USB0: USB EHCI 1.00
scanning bus 0 for devices...
U-Boot SPL 2015.04-00342-g2e62630 (Apr 17 2015 - 12:40:45)
DRAM: 1024 MiB

CPU: 912000000Hz, AXI/AHB/APB: 3/2/2

MMC Device 0 not found
spl: mmc device not found!!
### ERROR ### Please RESET the board ###

And good:
Command(A20 OLinuXino Lime2 console)> on
(user:trini) Power turned on

U-Boot SPL 2015.04-00121-g4564fae (Apr 17 2015 - 12:42:40)
DRAM: 1024 MiB

CPU: 912000000Hz, AXI/AHB/APB: 3/2/2

U-Boot 2015.04-00121-g4564fae (Apr 17 2015 - 12:42:40) Allwinner Technology

CPU:   Allwinner A20 (SUN7I)
I2C:   ready
DRAM:  1 GiB
MMC:   SUNXI SD/MMC: 0

*** Warning - bad CRC, using default environment

In:    serial
Out:   serial
Err:   serial
SCSI:  SUNXI SCSI INIT
SATA link 0 timeout.
AHCI 0001.0100 32 slots 1 ports 3 Gbps 0x1 impl SATA mode
flags: ncq stag pm led clo only pmp pio slum part ccc apst
Net:   dwmac.1c50000

starting USB...
USB0: USB EHCI 1.00
scanning bus 0 for devices... 1 USB Device(s) found
USB1: USB EHCI 1.00
scanning bus 1 for devices... 1 USB Device(s) found
scanning usb for storage devices... 0 Storage Device(s) found
Hit any key to stop autoboot: 0
sunxi#

Quoted 2 lines

So... we cause a reset during USB scan and then fail to boot a second time?

Thanks for testing this.

I'm not sure if I have a Lime (I might do, will need to look). I was testing sunxi on a pcduino3 but USB does not work on that for reasons I was looking into (it just says lowlevel init failure due to moving to driver model for GPIO).

Quoted 4 lines

Quoted 2 lines

I will take a look. In the meantime, which commit breaks this? I could perhaps issue a pull for commits up to that point to reduce the load.

I haven't had a chance to bisect yet but I will in a few hours.

No need to, I've just completed a bisect, it points to:

5bca5a6303f3526ab2cf9c0a62cd26c16e0d5c2f is the first bad commit commit 5bca5a6303f3526ab2cf9c0a62cd26c16e0d5c2f

Author: Simon Glass <[email protected]>
Date:   Wed Mar 25 12:22:27 2015 -0600

dm: usb: Drop the EHCI weak functions

These are a pain with driver model because we might have different EHCI drivers which want to implement them differently. Now that they use consistent function signatures, we can in good conscience move them to a struct.

Signed-off-by Simon Glass <[email protected]>

Reviewed-by Marek Vasut <[email protected]>

I'm going to first spend some time with my family now, I may look into this later tonight, or otherwise this weekend. I'll be sure to check mail first to avoid double work, so feel free to fix the problem while I'm relaxing :)

In order to switch to a set of function pointers for certain operations we need to ensure that the defaults are first set so that they can be overriden as needed by SoC/board specific code.

Signed-off-by Tom Rini <[email protected]>

---
 drivers/usb/host/ehci-hcd.c |   10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

drivers/usb/host/ehci-hcd.c +0 -0

index 79cf3b3..e7c438c 100644

drivers/usb/host/ehci-hcd.c +1 -0

+       if (ops) {
                ctrl->ops = *ops;
                if (!ctrl->ops.set_usb_mode)
                        ctrl->ops.set_usb_mode = ehci_set_usbmode;

drivers/usb/host/ehci-hcd.c +0 -1

        rc = ehci_hcd_init(index, init, &ctrl->hccr, &ctrl->hcor);
        if (rc)
                return rc;
--

1.7.9.5

Hi Tom,

Quoted 15 lines · Tom Rini

In order to switch to a set of function pointers for certain operations we need to ensure that the defaults are first set so that they can be overriden as needed by SoC/board specific code.

Signed-off-by Tom Rini <[email protected]>

---
 drivers/usb/host/ehci-hcd.c |   10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

drivers/usb/host/ehci-hcd.c +0 -0

index 79cf3b3..e7c438c 100644
@@ -945,9 +945,7 @@ const struct ehci_ops default_ehci_ops = {
 

drivers/usb/host/ehci-hcd.c const struct ehci_ops default_ehci_ops = { · line 950

Quoted 5 lines

drivers/usb/host/ehci-hcd.c +0 -3

 static void ehci_setup_ops(struct ehci_ctrl *ctrl, const struct ehci_ops *ops)
 {
-       if (!ops) {
-               ctrl->ops = default_ehci_ops;
-       } else {

Do we need to remove this? I think this will break when driver model is used, if NULL is passed in to select the default ops.

Quoted 8 lines

drivers/usb/host/ehci-hcd.c +1 -0

+       if (ops) {
                ctrl->ops = *ops;
                if (!ctrl->ops.set_usb_mode)
                        ctrl->ops.set_usb_mode = ehci_set_usbmode;

@@ -1095,6 +1093,12 @@ int usb_lowlevel_init(int index, enum usb_init_type init, void **controller)
        uint tweaks = 0;
        int rc;
 

drivers/usb/host/ehci-hcd.c int usb_lowlevel_init(int index, enum usb_init_type init, void **controller) · line 1101

Quoted 6 lines

drivers/usb/host/ehci-hcd.c +6 -0

+       /**
+        * Set ops to default_ehci_ops, ehci_hcd_init should call
+        * ehci_set_controller_priv to change any of these function pointers.
+        */
+       ctrl->ops = default_ehci_ops;
+

OK what I missed is that lots of things call ehci_hcd_init(). I only changed a few to call ehci_set_controller_priv().

Quoted 18 lines · Simon Glass

Hi Tom,

Quoted 15 lines · Tom Rini

In order to switch to a set of function pointers for certain operations we need to ensure that the defaults are first set so that they can be overriden as needed by SoC/board specific code.

Signed-off-by Tom Rini <[email protected]>

---
 drivers/usb/host/ehci-hcd.c |   10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

drivers/usb/host/ehci-hcd.c +0 -0

index 79cf3b3..e7c438c 100644
@@ -945,9 +945,7 @@ const struct ehci_ops default_ehci_ops = {
 

Quoted 8 lines

drivers/usb/host/ehci-hcd.c const struct ehci_ops default_ehci_ops = { · line 950

Quoted 5 lines

drivers/usb/host/ehci-hcd.c +0 -3

 static void ehci_setup_ops(struct ehci_ctrl *ctrl, const struct ehci_ops *ops)
 {
-       if (!ops) {
-               ctrl->ops = default_ehci_ops;
-       } else {

Do we need to remove this? I think this will break when driver model is used, if NULL is passed in to select the default ops.

Nope, just cleaning up the code as-is.

Quoted 9 lines

Quoted 9 lines

drivers/usb/host/ehci-hcd.c +1 -0

+       if (ops) {
                ctrl->ops = *ops;
                if (!ctrl->ops.set_usb_mode)
                        ctrl->ops.set_usb_mode = ehci_set_usbmode;

@@ -1095,6 +1093,12 @@ int usb_lowlevel_init(int index, enum usb_init_type init, void **controller)
        uint tweaks = 0;
        int rc;
 

Quoted 9 lines

drivers/usb/host/ehci-hcd.c int usb_lowlevel_init(int index, enum usb_init_type init, void **controller) · line 1101

Quoted 6 lines

drivers/usb/host/ehci-hcd.c +6 -0

+       /**
+        * Set ops to default_ehci_ops, ehci_hcd_init should call
+        * ehci_set_controller_priv to change any of these function pointers.
+        */
+       ctrl->ops = default_ehci_ops;
+

OK what I missed is that lots of things call ehci_hcd_init(). I only changed a few to call ehci_set_controller_priv().

Yes, you changed the ehci_hcd_init()'s that need to call ehci_set_controller_priv() to either set a priv or now to set the ops pointer. Most need neither so I think this is the right solution.

--
Tom

Hi Tom.

Quoted 28 lines · Tom Rini

Quoted 26 lines · Simon Glass

Hi Tom,

Quoted 14 lines · Tom Rini

In order to switch to a set of function pointers for certain operations we need to ensure that the defaults are first set so that they can be overriden as needed by SoC/board specific code.

Signed-off-by Tom Rini <[email protected]>

---
 drivers/usb/host/ehci-hcd.c |   10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

drivers/usb/host/ehci-hcd.c +0 -0

index 79cf3b3..e7c438c 100644

drivers/usb/host/ehci-hcd.c const struct ehci_ops default_ehci_ops = { · line 950

Quoted 6 lines

drivers/usb/host/ehci-hcd.c +0 -3

@@ -945,9 +945,7 @@ const struct ehci_ops default_ehci_ops = {
 
 static void ehci_setup_ops(struct ehci_ctrl *ctrl, const struct ehci_ops *ops)
 {
-       if (!ops) {
-               ctrl->ops = default_ehci_ops;
-       } else {

Do we need to remove this? I think this will break when driver model is used, if NULL is passed in to select the default ops.

Quoted 1 line

Nope, just cleaning up the code as-is.

I'm missing something though. For ehci_register() it calls this will ops possibly equal to NULL, expecting it to set up the ops.

Quoted 31 lines · Simon Glass

Hi Tom.

Quoted 28 lines · Tom Rini

Quoted 26 lines · Simon Glass

Hi Tom,

Quoted 14 lines · Tom Rini

In order to switch to a set of function pointers for certain operations we need to ensure that the defaults are first set so that they can be overriden as needed by SoC/board specific code.

Signed-off-by Tom Rini <[email protected]>

---
 drivers/usb/host/ehci-hcd.c |   10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

drivers/usb/host/ehci-hcd.c +0 -0

index 79cf3b3..e7c438c 100644

drivers/usb/host/ehci-hcd.c const struct ehci_ops default_ehci_ops = { · line 950

Quoted 6 lines

drivers/usb/host/ehci-hcd.c +0 -3

@@ -945,9 +945,7 @@ const struct ehci_ops default_ehci_ops = {
 
 static void ehci_setup_ops(struct ehci_ctrl *ctrl, const struct ehci_ops *ops)
 {
-       if (!ops) {
-               ctrl->ops = default_ehci_ops;
-       } else {

Do we need to remove this? I think this will break when driver model is used, if NULL is passed in to select the default ops.

Quoted 4 lines

Quoted 1 line

Nope, just cleaning up the code as-is.

I'm missing something though. For ehci_register() it calls this will ops possibly equal to NULL, expecting it to set up the ops.

OK, I missed a case too then, drop this hunk when you squash it in :)

Hi Tom,

Quoted 32 lines · Tom Rini

Quoted 31 lines · Simon Glass

Hi Tom.

Quoted 28 lines · Tom Rini

Quoted 26 lines · Simon Glass

Hi Tom,

Quoted 14 lines · Tom Rini

In order to switch to a set of function pointers for certain operations we need to ensure that the defaults are first set so that they can be overriden as needed by SoC/board specific code.

Signed-off-by Tom Rini <[email protected]>

---
 drivers/usb/host/ehci-hcd.c |   10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

drivers/usb/host/ehci-hcd.c +0 -0

index 79cf3b3..e7c438c 100644

drivers/usb/host/ehci-hcd.c const struct ehci_ops default_ehci_ops = { · line 950

Quoted 6 lines

drivers/usb/host/ehci-hcd.c +0 -3

@@ -945,9 +945,7 @@ const struct ehci_ops default_ehci_ops = {
 
 static void ehci_setup_ops(struct ehci_ctrl *ctrl, const struct ehci_ops *ops)
 {
-       if (!ops) {
-               ctrl->ops = default_ehci_ops;
-       } else {

Do we need to remove this? I think this will break when driver model is used, if NULL is passed in to select the default ops.

Quoted 6 lines

Quoted 4 lines

Quoted 1 line

Nope, just cleaning up the code as-is.

I'm missing something though. For ehci_register() it calls this will ops possibly equal to NULL, expecting it to set up the ops.

OK, I missed a case too then, drop this hunk when you squash it in :)

Will do. My plan is:

- pull in this patch
- figure out what else broke with the keyboard since my terrible conflict resolution attempt

Anything else?