common/lcd_console: introduce display/framebuffer rotation
v4 cover common/lcd_console: introduce display/framebuffer rotation
Sometimes, for example if the display is mounted in portrait mode or even if it mounted landscape but rotated by 180 degree, we need to rotate our content of the display respectively the framebuffer, so that user can read the messages who are printed out.
For this we introduce the feature called "CONFIG_LCD_ROTATION", this may be defined in the board-configuration if needed. After this the lcd_console will be initialized with a given rotation from "vl_rot" out of "vidinfo_t" which is provided by the board specific code.
The value for vl_rot is coded as following (matching to fbcon=rotate:<n> linux- kernel commandline):
0 = no rotation respectively 0 degree
1 = 90 degree rotation
2 = 180 degree rotation
3 = 270 degree rotation
If CONFIG_LCD_ROTATION is not defined, the console will be initialized with 0 degrees rotation.
Patch 1-3 make preparations to the code.
Patch 4 implements the new feature
Changes in v4:
- cosmetic changes to README
- avoid code-duplication (reuse console_calc_rowcol within rotation code).
Changes in v3:
- rename lcd_address to fbbase for better readability.
- remove empty line lcd_console.c
- use printf instead puts to inform about invalid-fb rotation.
- avoid code-duplication (move define of fbptr_t into lcd.h)
Changes in v2:
- cleanup README text for feature
- don't make code cleanups (lcd_console.c) within this patch
- remove (unnary) comment in lcd_console.h
- update year to 2015 within copyright in lcd_console.c
- move rotation related code into separate file lcd_console_rotation.c
- rework rotation code
- change meaning of vl_rot to match fbcon=rotate:<n> from the linux-kernel
Hannes Petermaier (4):
common/lcd_console: cleanup lcd_drawchars/lcd_putc_xy common/lcd_console: ask only one-time for bg/fg-color per call common/lcd_console: move single static variables into common (static)
structure
common/lcd_console: introduce display/framebuffer rotation
README | 20 +++++ common/Makefile | 1 + common/lcd.c | 15 ++-- common/lcd_console.c | 200 +++++++++++++++++++++-------------------- common/lcd_console_rotation.c | 195 ++++++++++++++++++++++++++++++++++++++++ include/lcd.h | 9 ++ include/lcd_console.h | 28 +++++- 7 files changed, 358 insertions(+), 110 deletions(-) create mode 100644 common/lcd_console_rotation.c
Signature · 1 line
1.7.9.5
PATCH v4 1/4 common/lcd_console: cleanup lcd_drawchars/lcd_putc_xy
From: Hannes Petermaier <[email protected]>
the capability of drawing some *str with count from lcd_drawchars is unnary. It is always called from lcd_putc_xy with one character of and count = 1.
So we simply rename lcd_drawchars into lcd_putc_xy and remove the loops inside.
---
Changes in v4: None
Changes in v3: None
Changes in v2: None
common/lcd_console.c | 23 +++++++---------------- 1 file changed, 7 insertions(+), 16 deletions(-)
common/lcd_console.c +7 -16
@@ -55,18 +55,17 @@ int lcd_get_screen_columns(void)return console_cols; } -static void lcd_drawchars (ushort x,ushort y,uchar *str,int count) +static void lcd_putc_xy (ushort x,ushort y,char c) {uchar *dest;ushort row;int fg_color, bg_color; +int i; dest = (uchar *)(lcd_console_address + y * lcd_line_length + x *NBITS (LCD_BPP ) /8 );for (row =0 ; row <VIDEO_FONT_HEIGHT ; ++row, dest += lcd_line_length) { -uchar *s = str; -int i;#if LCD_BPP ==LCD_COLOR16 ushort *d = (ushort *)dest;#elif LCD_BPP ==LCD_COLOR32
@@ -77,25 +76,17 @@ static void lcd_drawchars(ushort x, ushort y, uchar *str, int count) fg_color =lcd_getfgcolor (); bg_color =lcd_getbgcolor (); -for (i =0 ; i < count; ++i) { -uchar c, bits; - c = *s++; - bits = video_fontdata[c *VIDEO_FONT_HEIGHT + row]; +uchar bits; + bits = video_fontdata[c *VIDEO_FONT_HEIGHT + row]; -for (c =0 ; c <8 ; ++c) { - *d++ = (bits &0x80 ) ? fg_color : bg_color; - bits <<=1 ; - } +for (i =0 ; i <8 ; ++i) { + *d++ = (bits &0x80 ) ? fg_color : bg_color; + bits <<=1 ; } } } -static inline void lcd_putc_xy (ushort x,ushort y,uchar c) -{ -lcd_drawchars (x, y, &c,1 ); -} -static void console_scrollup (void ) {const int rows =CONFIG_CONSOLE_SCROLL_LINES ;
Signature · 1 line
1.7.9.5
PATCH v4 2/4 common/lcd_console: ask only one-time for bg/fg-color per call
In reply to Hannes PetermaierFrom: Hannes Petermaier <[email protected]>
Don't call the lcd_getfgcolor and lcd_getbgcolor within the "draw-loop", this only wastes time.
---
Changes in v4: None
Changes in v3: None
Changes in v2: None
common/lcd_console.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
common/lcd_console.c +2 -5
@@ -59,7 +59,8 @@ static void lcd_putc_xy(ushort x, ushort y, char c) {uchar *dest;ushort row; -int fg_color, bg_color; +int fg_color =lcd_getfgcolor (); +int bg_color =lcd_getbgcolor ();int i; dest = (uchar *)(lcd_console_address +
@@ -73,10 +74,6 @@ static void lcd_putc_xy(ushort x, ushort y, char c)#else uchar *d = dest;#endif - - fg_color =lcd_getfgcolor (); - bg_color =lcd_getbgcolor (); -uchar bits; bits = video_fontdata[c *VIDEO_FONT_HEIGHT + row];
Signature · 1 line
1.7.9.5
PATCH v4 3/4 common/lcd_console: move single static variables into common (static) structure
In reply to Hannes PetermaierFrom: Hannes Petermaier <[email protected]>
For coming implementation of lcd_console rotation, we will need some more variables for holding information about framebuffer size, rotation, ...
For better readability we catch all them into a common structure.
---
Changes in v4: None
Changes in v3: None
Changes in v2: None
common/lcd_console.c | 76 +++++++++++++++++++++++++------------------------- 1 file changed, 38 insertions(+), 38 deletions(-)
common/lcd_console.c +38 -38
@@ -11,48 +11,49 @@#include <video_font.h> /* Get font data, width and height */ #define CONSOLE_ROW_SIZE (VIDEO_FONT_HEIGHT * lcd_line_length) -#define CONSOLE_ROW_FIRST lcd_console_address -#define CONSOLE_SIZE (CONSOLE_ROW_SIZE * console_rows) +#define CONSOLE_ROW_FIRST cons.lcd_address +#define CONSOLE_SIZE (CONSOLE_ROW_SIZE * cons.rows) -static short console_curr_col; -static short console_curr_row; -static short console_cols; -static short console_rows; -static void *lcd_console_address; +struct console_t { +short curr_col, curr_row; +short cols, rows; +void *lcd_address; +}; +static struct console_t cons;void lcd_init_console (void *address,int rows,int cols) { - console_curr_col =0 ; - console_curr_row =0 ; - console_cols = cols; - console_rows = rows; - lcd_console_address = address; +memset (&cons,0 ,sizeof (cons)); + cons.cols = cols; + cons.rows = rows; + cons.lcd_address = address; + }void lcd_set_col (short col) { - console_curr_col = col; + cons.curr_col = col; }void lcd_set_row (short row) { - console_curr_row = row; + cons.curr_row = row; }void lcd_position_cursor (unsigned col,unsigned row) { - console_curr_col =min_t (short, col, console_cols -1 ); - console_curr_row =min_t (short, row, console_rows -1 ); + cons.curr_col =min_t (short, col, cons.cols -1 ); + cons.curr_row =min_t (short, row, cons.rows -1 ); }int lcd_get_screen_rows (void ) { -return console_rows; +return cons.rows; }int lcd_get_screen_columns (void ) { -return console_cols; +return cons.cols; }static void lcd_putc_xy (ushort x,ushort y,char c)
@@ -63,7 +64,7 @@ static void lcd_putc_xy(ushort x, ushort y, char c)int bg_color =lcd_getbgcolor ();int i; - dest = (uchar *)(lcd_console_address + + dest = (uchar *)(cons.lcd_address + y * lcd_line_length + x *NBITS (LCD_BPP ) /8 );for (row =0 ; row <VIDEO_FONT_HEIGHT ; ++row, dest += lcd_line_length) {
@@ -91,7 +92,7 @@ static void console_scrollup(void)/* Copy up rows ignoring those that will be overwritten */ memcpy (CONSOLE_ROW_FIRST , - lcd_console_address +CONSOLE_ROW_SIZE * rows, + cons.lcd_address +CONSOLE_ROW_SIZE * rows,CONSOLE_SIZE -CONSOLE_ROW_SIZE * rows);/* Clear the last rows */
@@ -99,7 +100,7 @@ static void console_scrollup(void)memset (lcd_console_address +CONSOLE_SIZE -CONSOLE_ROW_SIZE * rows, bg_color,CONSOLE_ROW_SIZE * rows);#else -u32 *ppix = lcd_console_address + +u32 *ppix = cons.lcd_address +CONSOLE_SIZE -CONSOLE_ROW_SIZE * rows;u32 i; for (i = 0;
@@ -109,27 +110,27 @@ static void console_scrollup(void) }#endif lcd_sync (); - console_curr_row -= rows; + cons.curr_row -= rows; }static inline void console_back (void ) { -if (--console_curr_col <0 ) { - console_curr_col = console_cols -1 ; -if (--console_curr_row <0 ) - console_curr_row =0 ; +if (--cons.curr_col <0 ) { + cons.curr_col = cons.cols -1 ; +if (--cons.curr_row <0 ) + cons.curr_row =0 ; } -lcd_putc_xy (console_curr_col *VIDEO_FONT_WIDTH , - console_curr_row *VIDEO_FONT_HEIGHT ,' ' ); +lcd_putc_xy (cons.curr_col *VIDEO_FONT_WIDTH , + cons.curr_row *VIDEO_FONT_HEIGHT ,' ' ); }static inline void console_newline (void ) { - console_curr_col =0 ; + cons.curr_col =0 ;/* Check if we need to scroll the terminal */ -if (++console_curr_row >= console_rows) +if (++cons.curr_row >= cons.rows)console_scrollup ();else lcd_sync ();
@@ -145,18 +146,17 @@ void lcd_putc(const char c)switch (c) {case '\r' : - console_curr_col =0 ; - + cons.curr_col =0 ;return ;case '\n' :console_newline ();return ;case '\t' :/* Tab (8 chars alignment) */ - console_curr_col +=8 ; - console_curr_col &= ~7 ; + cons.curr_col +=8 ; + cons.curr_col &= ~7 ; -if (console_curr_col >= console_cols) +if (cons.curr_col >= cons.cols)console_newline ();return ;
@@ -165,9 +165,9 @@ void lcd_putc(const char c)return ;default : -lcd_putc_xy (console_curr_col *VIDEO_FONT_WIDTH , - console_curr_row *VIDEO_FONT_HEIGHT , c); -if (++console_curr_col >= console_cols) +lcd_putc_xy (cons.curr_col *VIDEO_FONT_WIDTH , + cons.curr_row *VIDEO_FONT_HEIGHT , c); +if (++cons.curr_col >= cons.cols)console_newline (); } }
Signature · 1 line
1.7.9.5
PATCH v4 4/4 common/lcd_console: introduce display/framebuffer rotation
In reply to Hannes PetermaierFrom: Hannes Petermaier <[email protected]>
Sometimes, for example if the display is mounted in portrait mode or even if it mounted landscape but rotated by 180 degrees, we need to rotate our content of the display respectively the framebuffer, so that user can read the messages who are printed out.
For this we introduce the feature called "CONFIG_LCD_ROTATION", this may be defined in the board-configuration if needed. After this the lcd_console will be initialized with a given rotation from "vl_rot" out of "vidinfo_t" which is provided by the board specific code.
If CONFIG_LCD_ROTATION is not defined, the console will be initialized with 0 degrees rotation.
---
Changes in v4:
- cosmetic changes to README
- avoid code-duplication (reuse console_calc_rowcol within rotation code).
Changes in v3:
- rename lcd_address to fbbase for better readability.
- remove empty line lcd_console.c
- use printf instead puts to inform about invalid-fb rotation.
- avoid code-duplication (move define of fbptr_t into lcd.h)
Changes in v2:
- cleanup README text for feature
- don't make code cleanups (lcd_console.c) within this patch
- remove (unnary) comment in lcd_console.h
- update year to 2015 within copyright in lcd_console.c
- move rotation related code into separate file lcd_console_rotation.c
- rework rotation code
- change meaning of vl_rot to match fbcon=rotate:<n> from the linux-kernel
README | 20 +++++ common/Makefile | 1 + common/lcd.c | 15 ++-- common/lcd_console.c | 160 ++++++++++++++++++--------------- common/lcd_console_rotation.c | 195 +++++++++++++++++++++++++++++++++++++++++ include/lcd.h | 9 ++ include/lcd_console.h | 28 +++++- 7 files changed, 344 insertions(+), 84 deletions(-) create mode 100644 common/lcd_console_rotation.c
README +20 -0
@@ -1947,6 +1947,26 @@ CBFS (Coreboot Filesystem) support the console jump but can help speed up operation when scrolling is slow. + CONFIG_LCD_ROTATION + + Sometimes, for example if the display is mounted in portrait + mode or even if it's mounted landscape but rotated by 180degree, + we need to rotate our content of the display relative to the + framebuffer, so that user can read the messages which are + printed out. + Once CONFIG_LCD_ROTATION is defined, the lcd_console will be + initialized with a given rotation from "vl_rot" out of + "vidinfo_t" which is provided by the board specific code. + The value for vl_rot is coded as following (matching to + fbcon=rotate:<n> linux-kernel commandline): + 0 = no rotation respectively 0 degree + 1 = 90 degree rotation + 2 = 180 degree rotation + 3 = 270 degree rotation + + If CONFIG_LCD_ROTATION is not defined, the console will be + initialized with 0degree rotation. + CONFIG_LCD_BMP_RLE8 Support drawing of RLE8-compressed bitmaps on the LCD.
common/Makefile +1 -0
@@ -200,6 +200,7 @@ obj-$(CONFIG_KALLSYMS) += kallsyms.o obj-y += splash.o obj-$(CONFIG_SPLASH_SOURCE) += splash_source.o obj-$(CONFIG_LCD) += lcd.o lcd_console.o +obj-$(CONFIG_LCD_ROTATION) += lcd_console_rotation.o obj-$(CONFIG_LCD_DT_SIMPLEFB) += lcd_simplefb.o obj-$(CONFIG_LYNXKDI) += lynxkdi.o obj-$(CONFIG_MENU) += menu.o
common/lcd.c +6 -9
@@ -167,7 +167,6 @@ int drv_lcd_init(void)void lcd_clear (void ) { -short console_rows, console_cols;int bg_color;char *s;ulong addr;
@@ -211,16 +210,14 @@ void lcd_clear(void) }#endif #endif +/* setup text-console */ +debug ("[LCD] setting up console...\n" ); +lcd_init_console (lcd_base, + panel_info.vl_col, + panel_info.vl_row, + panel_info.vl_rot);/* Paint the logo and retrieve LCD base address */ debug ("[LCD] Drawing the logo...\n" ); -#if defined(CONFIG_LCD_LOGO ) && !defined(CONFIG_LCD_INFO_BELOW_LOGO ) - console_rows = (panel_info.vl_row -BMP_LOGO_HEIGHT ); - console_rows /=VIDEO_FONT_HEIGHT ; -#else - console_rows = panel_info.vl_row /VIDEO_FONT_HEIGHT ; -#endif - console_cols = panel_info.vl_col /VIDEO_FONT_WIDTH ; -lcd_init_console (lcd_base, console_rows, console_cols);if (do_splash) { s =getenv ("splashimage" );if (s) {
common/lcd_console.c +89 -71
210 lines not on this page · raw message
common/lcd_console_rotation.c new file +195 -0
195 lines not on this page · raw message
include/lcd.h +9 -0
@@ -51,6 +51,7 @@ void lcd_set_flush_dcache(int flush); typedef struct vidinfo { ushort vl_col; /* Number of columns (i.e. 160) */ ushort vl_row; /* Number of rows (i.e. 100) */ + ushort vl_rot; /* Rotation of Display (0, 1, 2, 3) */ u_char vl_bpix; /* Bits per pixel, 0 = 1 */ ushort *cmap; /* Pointer to the colormap */ void *priv; /* Pointer to driver-specific data */
@@ -196,6 +197,14 @@ void lcd_sync(void);#define CONSOLE_COLOR_WHITE 0xffff/* Must remain last / highest */ #endif /* color definitions */ +#if LCD_BPP ==LCD_COLOR16 +#define fbptr_t ushort +#elif LCD_BPP ==LCD_COLOR32 +#define fbptr_t u32 +#else +#define fbptr_t uchar +#endif +#ifndef PAGE_SIZE #define PAGE_SIZE 4096#endif
include/lcd_console.h +24 -4
@@ -9,6 +9,26 @@#define CONFIG_CONSOLE_SCROLL_LINES 1#endif +struct console_t { +short curr_col, curr_row; +short cols, rows; +void *fbbase; +u32 lcdsizex, lcdsizey, lcdrot; +void (*fp_putc_xy)(struct console_t *pcons,ushort x,ushort y,char c); +void (*fp_console_moverow)(struct console_t *pcons, +u32 rowdst,u32 rowsrc); +void (*fp_console_setrow)(struct console_t *pcons,u32 row,int clr); +}; + +/** +* console_calc_rowcol() - calculate available rows / columns wihtin a given +* screen-size based on used VIDEO_FONT. +* +* @pcons: Pointer to struct console_t +* @sizex: size X of the screen in pixel +* @sizey: size Y of the screen in pixel +*/ +void console_calc_rowcol (struct console_t *pcons,u32 sizex,u32 sizey);/** * lcd_init_console() - Initialize lcd console parameters *
@@ -16,11 +36,11 @@* console has. * * @address: Console base address -* @rows: Number of rows in the console -* @cols: Number of columns in the console +* @vl_rows: Number of rows in the console +* @vl_cols: Number of columns in the console +* @vl_rot: Rotation of display in degree (0 - 90 - 180 - 270) counterlockwise */ -void lcd_init_console (void *address,int rows,int cols); - +void lcd_init_console (void *address,int vl_cols,int vl_rows,int vl_rot);/** * lcd_set_col() - Set the number of the current lcd console column *
Signature · 1 line
1.7.9.5
v4 cover common/lcd_console: introduce display/framebuffer rotation
In reply to Hannes PetermaierQuoted 16 lines · Hannes Petermaier
Sometimes, for example if the display is mounted in portrait mode or even if it mounted landscape but rotated by 180 degree, we need to rotate our content of the display respectively the framebuffer, so that user can read the messages who are printed out.
For this we introduce the feature called "
CONFIG_LCD_ROTATION", this may be defined in the board-configuration if needed. After this thelcd_consolewill be initialized with a given rotation from "vl_rot" out of "vidinfo_t" which is provided by the board specific code.
The value forvl_rotis coded as following (matching to fbcon=rotate:<n> linux- kernel commandline):
0 = no rotation respectively 0 degree
1 = 90 degree rotation
2 = 180 degree rotation
3 = 270 degree rotation
Quoted 6 lines
If
CONFIG_LCD_ROTATIONis not defined, the console will be initialized with 0 degrees rotation.Patch 1-3 make preparations to the code.
Patch 4 implements the new feature
Whole series:
Signature · 2 lines
Regards, Nikita Kiryanov
v4 cover common/lcd_console: introduce display/framebuffer rotation
In reply to Hannes PetermaierOn Fri, 27 Mar 2015 08:01:34 +0100
Hannes Petermaier <[email protected]> wrote:
...
Quoted 7 lines
Hannes Petermaier (4):
common/lcd_console: cleanup lcd_drawchars/lcd_putc_xy common/lcd_console: ask only one-time for bg/fg-color per call common/lcd_console: move single static variables into common (static)
structure
common/lcd_console: introduce display/framebuffer rotation
Quoted 9 lines
README | 20 +++++ common/Makefile | 1 + common/lcd.c | 15 ++-- common/lcd_console.c | 200 +++++++++++++++++++++-------------------- common/lcd_console_rotation.c | 195 ++++++++++++++++++++++++++++++++++++++++ include/lcd.h | 9 ++ include/lcd_console.h | 28 +++++- 7 files changed, 358 insertions(+), 110 deletions(-) create mode 100644 common/lcd_console_rotation.c
series applied after fixing build issues with some boards.
Thanks,
Anatolij