Skip to contentSkip to conversation

package/exim: Dependency host-pkgconf is only needed for OpenSSL detection

PATCH New Bernd Kuhls 3 participants 3 messages Apr 16, 2015 – Apr 19, 2015

lore
Share & tools
lore

Bernd Kuhls

author
#0 lore raw

PATCH 1/1 package/exim: Dependency host-pkgconf is only needed for OpenSSL detection

Signed-off-by Bernd Kuhls <[email protected]>
---
 package/exim/exim.mk |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/exim/exim.mk +2 -2
index 67dbd64..a95559d 100644
@@ -9,7 +9,7 @@ EXIM_SOURCE = exim-$(EXIM_VERSION).tar.bz2
 EXIM_SITE = ftp://ftp.exim.org/pub/exim/exim4
 EXIM_LICENSE = GPLv2+
 EXIM_LICENSE_FILES = LICENCE
-EXIM_DEPENDENCIES = pcre berkeleydb host-pkgconf
+EXIM_DEPENDENCIES = pcre berkeleydb
 
 # Modify a variable value. It must already exist in the file, either
 # commented or not.

@@ -63,7 +63,7 @@ endef
 endif
 
 ifeq ($(BR2_PACKAGE_OPENSSL),y)
-EXIM_DEPENDENCIES += openssl
+EXIM_DEPENDENCIES += openssl host-pkgconf
 define EXIM_USE_DEFAULT_CONFIG_FILE_OPENSSL
 	$(call exim-config-change,SUPPORT_TLS,yes)
 	$(call exim-config-change,USE_OPENSSL_PC,openssl)
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 package/exim: Dependency host-pkgconf is only needed for OpenSSL detection

Bernd, All,

On 2015-04-16 20:52 +0200, Bernd Kuhls spake thusly:

Quoted 20 lines
Signed-off-by Bernd Kuhls <[email protected]>
---
 package/exim/exim.mk |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/exim/exim.mk +1 -1
index 67dbd64..a95559d 100644
@@ -9,7 +9,7 @@ EXIM_SOURCE = exim-$(EXIM_VERSION).tar.bz2
 EXIM_SITE = ftp://ftp.exim.org/pub/exim/exim4
 EXIM_LICENSE = GPLv2+
 EXIM_LICENSE_FILES = LICENCE
-EXIM_DEPENDENCIES = pcre berkeleydb host-pkgconf
+EXIM_DEPENDENCIES = pcre berkeleydb
 
 # Modify a variable value. It must already exist in the file, either
 # commented or not.

package/exim/exim.mk endef · line 66

Quoted 5 lines
package/exim/exim.mk +1 -1
@@ -63,7 +63,7 @@ endef
 endif
 
 ifeq ($(BR2_PACKAGE_OPENSSL),y)
-EXIM_DEPENDENCIES += openssl
+EXIM_DEPENDENCIES += openssl host-pkgconf

Well, even though we currently only support berkleydb as a DB backend, exim can also use sqlite. And detecting sqlite is done via pkg-config.

Also, exim uses pkg-config for a lot of other stuff; quoting their (awfull) buildsystem:

    for name_mod in \
        CDB DBM:dbmdb DNSDB DSEARCH IBASE LSEARCH MYSQL NIS NISPLUS ORACLE \
        PASSWD PGSQL SQLITE TESTDB WHOSON
    do
      emit_module_rule $name_mod
    done

and emit_module_rule() contains this code:

    [--SNIP--]
      echo "LOOKUP_${mod_name}_INCLUDE = $(pkg-config --cflags $pkgconf)"
      echo "LOOKUP_${mod_name}_LIBS = $(pkg-config --libs $pkgconf)"
    [--SNIP--]

So, even though we do not really need it when OpenSSL is disabled, I think we want to keep it as an uncoditionaly dependency.

Regards,
Yann E. MORIN.

Quoted 10 lines
package/exim/exim.mk +0 -0
 define EXIM_USE_DEFAULT_CONFIG_FILE_OPENSSL
 	$(call exim-config-change,SUPPORT_TLS,yes)
 	$(call exim-config-change,USE_OPENSSL_PC,openssl)
Signature · 6 lines
1.7.10.4

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 package/exim: Dependency host-pkgconf is only needed for OpenSSL detection

In reply to Bernd Kuhls

Dear Bernd Kuhls,

Quoted 5 lines · Bernd Kuhls
Signed-off-by Bernd Kuhls <[email protected]>
---
 package/exim/exim.mk |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Following the feedback from Yann, who suggested to keep the dependency unconditional, I marked your patch as Rejected in patchwork.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com