Skip to contentSkip to conversation

ARM: mvebu: Fix the main PLL frequency on Armada 375, 38x and 39x SoCs

PATCH New Gregory CLEMENT 2 participants 3 messages Apr 20, 2015 – Apr 21, 2015 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: mvebu: Fix the main PLL frequency on Armada 375, 38x and 39x SoCs

Whereas for Armada 370 and XP the main PLL frequency was 2GHz for the Armada 375, 38x and 39x, the frequency is 1GHz. When writting support for these last SoCs, there was no offical value for the PLL. Now that we have it, this patch fixes it in the device tree.

This value is currently only used by the NAND driver for the setting the NAND timing. Fortunately it is not acutally used: all the mainline board with a NAND flash comes with a NAND device tree node using the "marvell,nand-keep-config" property. With this property the timings are not modified in the kernel driver and are kept from the botloader.

---
 arch/arm/boot/dts/armada-375.dtsi | 2 +-
 arch/arm/boot/dts/armada-38x.dtsi | 2 +-
 arch/arm/boot/dts/armada-39x.dtsi | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
arch/arm/boot/dts/armada-375.dtsi +1 -1
index c675257f2377..f076ff856d8b 100644
@@ -69,7 +69,7 @@
 		mainpll: mainpll {
 			compatible = "fixed-clock";
 			#clock-cells = <0>;
-			clock-frequency = <2000000000>;
+			clock-frequency = <1000000000>;
 		};
 		/* 25 MHz reference crystal */
 		refclk: oscillator {
arch/arm/boot/dts/armada-38x.dtsi +1 -1
index ed2dd8ba4080..218a2acd36e5 100644
@@ -585,7 +585,7 @@
 		mainpll: mainpll {
 			compatible = "fixed-clock";
 			#clock-cells = <0>;
-			clock-frequency = <2000000000>;
+			clock-frequency = <1000000000>;
 		};
 
 		/* 25 MHz reference crystal */
arch/arm/boot/dts/armada-39x.dtsi +1 -1
index 0e85fc15ceda..ecd1318109ba 100644
@@ -502,7 +502,7 @@
 		mainpll: mainpll {
 			compatible = "fixed-clock";
 			#clock-cells = <0>;
-			clock-frequency = <2000000000>;
+			clock-frequency = <1000000000>;
 		};
 	};
 };
Signature · 1 line
2.1.0
#1 lore raw

PATCH 1/1 ARM: mvebu: Fix the main PLL frequency on Armada 375, 38x and 39x SoCs

Hi,

Quoted 2 lines · Gregory CLEMENT

Whereas for Armada 370 and XP the main PLL frequency was 2GHz for the Armada 375, 38x and 39x, the frequency is 1GHz. When writting support

^ writing

Quoted 5 lines

for these last SoCs, there was no offical value for the PLL. Now that we have it, this patch fixes it in the device tree.

This value is currently only used by the NAND driver for the setting the NAND timing. Fortunately it is not acutally used: all the mainline

^ actually

Quoted 1 line

board with a NAND flash comes with a NAND device tree node using the

^ boards ^ come

Quoted 2 lines

"marvell,nand-keep-config" property. With this property the timings are not modified in the kernel driver and are kept from the botloader.

^ bootloader

Maxime

Signature · 10 lines
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150420/ebb59058/attachment.sig>
#2 lore raw

PATCH 1/1 ARM: mvebu: Fix the main PLL frequency on Armada 375, 38x and 39x SoCs

Hi Maxime,

Quoted 8 lines · Maxime Ripard

Hi,

Quoted 2 lines · Gregory CLEMENT

Whereas for Armada 370 and XP the main PLL frequency was 2GHz for the Armada 375, 38x and 39x, the frequency is 1GHz. When writting support

^ writing

Quoted 1 line

for these last SoCs, there was no offical value for the PLL. Now that

^ official

Quoted 6 lines
Quoted 4 lines

we have it, this patch fixes it in the device tree.

This value is currently only used by the NAND driver for the setting the NAND timing. Fortunately it is not acutally used: all the mainline

^ actually

Quoted 7 lines
Quoted 1 line

board with a NAND flash comes with a NAND device tree node using the

^ boards ^ come

Quoted 2 lines

"marvell,nand-keep-config" property. With this property the timings are not modified in the kernel driver and are kept from the botloader.

^ bootloader

It seemed that my flyspell mode was not activated, thanks for your spell check. I will send a new patch in a few day, waiting for other review.

Thanks,

Gregory

Quoted 10 lines

Maxime

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Signature · 4 lines
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com