heimdal: needs host-flex and explicitly set -lpthread
PATCH 1/1 heimdal: needs host-flex and explicitly set -lpthread
--- package/heimdal/heimdal.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
package/heimdal/heimdal.mk +2 -2
@@ -6,11 +6,11 @@ HEIMDAL_VERSION = 1.5.3 HEIMDAL_SITE = http://www.h5l.org/dist/src -HEIMDAL_DEPENDENCIES = host-e2fsprogs host-pkgconf +HEIMDAL_DEPENDENCIES = host-e2fsprogs host-pkgconf host-flex HEIMDAL_INSTALL_STAGING = YES # static because of -fPIC issues with e2fsprogs on x86_64 host HOST_HEIMDAL_CONF_OPTS = --with-x=no --disable-shared --enable-static -HOST_HEIMDAL_CONF_ENV = MAKEINFO=true +HOST_HEIMDAL_CONF_ENV = MAKEINFO=true LIBS="-lpthread" HEIMDAL_MAKE = $(MAKE1) # For heimdal-0004-compile_et.patch HEIMDAL_AUTORECONF = YES
Signature · 1 line
2.3.5
PATCH 1/1 heimdal: needs host-flex and explicitly set -lpthread
Dear Ryan Coe,
Quoted 10 lines · Ryan Coe
Signed-off-by Ryan Coe <[email protected]>--- package/heimdal/heimdal.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)package/heimdal/heimdal.mk +0
-0
package/heimdal/heimdal.mk line 13
Quoted 10 lines
package/heimdal/heimdal.mk +2
-2@@ -6,11 +6,11 @@ HEIMDAL_VERSION = 1.5.3 HEIMDAL_SITE = http://www.h5l.org/dist/src -HEIMDAL_DEPENDENCIES = host-e2fsprogs host-pkgconf +HEIMDAL_DEPENDENCIES = host-e2fsprogs host-pkgconf host-flex HEIMDAL_INSTALL_STAGING = YES # static because of -fPIC issues with e2fsprogs on x86_64 host HOST_HEIMDAL_CONF_OPTS = --with-x=no --disable-shared --enable-static -HOST_HEIMDAL_CONF_ENV = MAKEINFO=true +HOST_HEIMDAL_CONF_ENV = MAKEINFO=true LIBS="-lpthread"
Could you give more details about the situations in which you are seeing problems with host-flex and -lpthread being missing?
I indeed see that flex and bison are being tested at configure time, but failing to detect them does not seem to affect the build (maybe heimdal has a pre-generated versions of the files normally generated by flex/bison?). And I see -lpthread being used properly when linking.
So, please include more details about the issues you're seeing your commit log.
Thanks a lot!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 heimdal: needs host-flex and explicitly set -lpthread
Quoted 31 lines · Thomas Petazzoni
Dear Ryan Coe,
Quoted 10 lines · Ryan Coe
Signed-off-by Ryan Coe <[email protected]>--- package/heimdal/heimdal.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)package/heimdal/heimdal.mk +0
-0package/heimdal/heimdal.mk line 13
Quoted 10 lines
package/heimdal/heimdal.mk +2
-2@@ -6,11 +6,11 @@ HEIMDAL_VERSION = 1.5.3 HEIMDAL_SITE = http://www.h5l.org/dist/src -HEIMDAL_DEPENDENCIES = host-e2fsprogs host-pkgconf +HEIMDAL_DEPENDENCIES = host-e2fsprogs host-pkgconf host-flex HEIMDAL_INSTALL_STAGING = YES # static because of -fPIC issues with e2fsprogs on x86_64 host HOST_HEIMDAL_CONF_OPTS = --with-x=no --disable-shared --enable-static -HOST_HEIMDAL_CONF_ENV = MAKEINFO=true +HOST_HEIMDAL_CONF_ENV = MAKEINFO=true LIBS="-lpthread"Could you give more details about the situations in which you are seeing problems with host-flex and -lpthread being missing?
I indeed see that flex and bison are being tested at configure time, but failing to detect them does not seem to affect the build (maybe heimdal has a pre-generated versions of the files normally generated by flex/bison?). And I see -lpthread being used properly when linking.
Quoted 6 lines
So, please include more details about the issues you're seeing your commit log.
Thanks a lot!
Thomas
Thomas,
I found the addition of host-flex not to be necessary. The -lpthread addition fixes a build error on my machine. I will submit a new version of my patch.
Thanks,
Ryan
PATCH 1/1 heimdal: needs host-flex and explicitly set -lpthread
Dear Ryan Coe,
Quoted 3 lines · Ryan Coe
I found the addition of host-flex not to be necessary. The -lpthread addition fixes a build error on my machine. I will submit a new version of my patch.
Could you give the full build log of host-heimdal on your machine, as well as the contents of config.log, when the build fails due to -lpthread being missing?
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 heimdal: needs host-flex and explicitly set -lpthread
Dear Ryan Coe,
Quoted 25 lines · Ryan Coe
(cd
/home/ryan/devel/buildroot/buildroot-git/output/build/host-heimdal-1.5.3/&&
rm -rf config.cache; PATH="/home/ryan/devel/buildroot/buildroot-git/output/host/bin:/home/ryan/devel/buildroot/buildroot-git/output/host/sbin:/home/ryan/devel/buildroot/buildroot-git/output/host/usr/bin:/home/ryan/devel/buildroot/buildroot-git/output/host/usr/sbin:/home/ryan/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games" AR="/usr/bin/ar" AS="/usr/bin/as" LD="/usr/bin/ld" NM="/usr/bin/nm"
CC="/usr/bin/gcc" GCC="/usr/bin/gcc" CXX="/usr/bin/g++"
CPP="/usr/bin/cpp" OBJCOPY="/usr/bin/objcopy" RANLIB="/usr/bin/ranlib"
CPPFLAGS="-I/home/ryan/devel/buildroot/buildroot-git/output/host/usr/include"
CFLAGS="-O2
-I/home/ryan/devel/buildroot/buildroot-git/output/host/usr/include"
CXXFLAGS="-O2
-I/home/ryan/devel/buildroot/buildroot-git/output/host/usr/include"
LDFLAGS="-L/home/ryan/devel/buildroot/buildroot-git/output/host/lib(quoted diff) +0
-2-L/home/ryan/devel/buildroot/buildroot-git/output/host/usr/lib -Wl,-rpath,/home/ryan/devel/buildroot/buildroot-git/output/host/usr/lib"PKG_CONFIG_ALLOW_SYSTEM_CFLAGS=1 PKG_CONFIG_ALLOW_SYSTEM_LIBS=1 PKG_CONFIG="/home/ryan/devel/buildroot/buildroot-git/output/host/usr/bin/pkg-config"
PKG_CONFIG_SYSROOT_DIR="/" PKG_CONFIG_LIBDIR="/home/ryan/devel/buildroot/buildroot-git/output/host/usr/lib/pkgconfig:/home/ryan/devel/buildroot/buildroot-git/output/host/usr/share/pkgconfig" LD_LIBRARY_PATH="/home/ryan/devel/buildroot/buildroot-git/output/host/usr/lib"
INTLTOOL_PERL=/usr/bin/perl CFLAGS="-O2
-I/home/ryan/devel/buildroot/buildroot-git/output/host/usr/include"
LDFLAGS="-L/home/ryan/devel/buildroot/buildroot-git/output/host/lib(quoted diff) +0
-2-L/home/ryan/devel/buildroot/buildroot-git/output/host/usr/lib -Wl,-rpath,/home/ryan/devel/buildroot/buildroot-git/output/host/usr/lib"
Quoted 8 lines
MAKEINFO=true
CONFIG_SITE=/dev/null./configure --prefix="/home/ryan/devel/buildroot/buildroot-git/output/host/usr" --sysconfdir="/home/ryan/devel/buildroot/buildroot-git/output/host/etc" --localstatedir="/home/ryan/devel/buildroot/buildroot-git/output/host/var" --enable-shared --disable-static --disable-gtk-doc --disable-gtk-doc-html --disable-doc --disable-docs --disable-documentation --disable-debug --with-xmlto=no --with-fop=no --disable-dependency-tracking --with-x=no --disable-shared
You don't have my patch applied here. There's still only --with-x=no, and none of the other --without that my patch is adding.
Please test with the patch applied, thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com