drm/nouveau/platform: checking for IS_ERR() instead of NULL

PATCH In review Dan Carpenter 3 participants 3 messages Apr 21, 2015

Subsystems (4)

DRM drivers DRM misc Kernel janitors nouveau

lore

Share & tools

lore

Dan Carpenter

author

2015-04-21 09:25 UTC #0 lore raw

PATCH 1/1 drm/nouveau/platform: checking for IS_ERR() instead of NULL

iommu_domain_alloc() returns NULL on error, it doesn't return error pointers.

Fixes 58fd9375c2c5 ('drm/nouveau/platform: probe IOMMU if present')

Signed-off-by Dan Carpenter <[email protected]>

drivers/gpu/drm/nouveau/nouveau_platform.c +1 -1

index 775277f..4fbd35d 100644
@@ -102,7 +102,7 @@ static void nouveau_platform_probe_iommu(struct device *dev,
 
 	if (iommu_present(&platform_bus_type)) {
 		gpu->iommu.domain = iommu_domain_alloc(&platform_bus_type);
-		if (IS_ERR(gpu->iommu.domain))
+		if (!gpu->iommu.domain)
 			goto error;
 
 		/*

Thierry Reding

Reviewed-by on v1 1/1

2015-04-21 09:36 UTC #1 lore raw

Quoted 5 lines · Dan Carpenter

iommu_domain_alloc() returns NULL on error, it doesn't return error pointers.
Fixes 58fd9375c2c5 ('drm/nouveau/platform: probe IOMMU if present')
Signed-off-by Dan Carpenter <[email protected]>

Indeed:

Reviewed-by Thierry Reding <[email protected]>

Alexandre Courbot

Reviewed-by on v1 1/1

2015-04-21 09:43 UTC #2 lore raw

In reply to Dan Carpenter

Quoted 2 lines · Dan Carpenter

iommu_domain_alloc() returns NULL on error, it doesn't return error pointers.

Oops, that's right.

Reviewed-by Alexandre Courbot <[email protected]>