Skip to contentSkip to conversation

package/c-ares: add hash

PATCH New Fabio Porcedda 4 participants 10 messages Apr 21, 2015 – Apr 22, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 package/c-ares: add hash

---
 package/c-ares/c-ares.hash | 2 ++
 1 file changed, 2 insertions(+)
 create mode 100644 package/c-ares/c-ares.hash
package/c-ares/c-ares.hash new file +2 -0
new file mode 100644
index 0000000..ce614d8
@@ -0,0 +1,2 @@
+# Locally calculated
+sha256 3d701674615d1158e56a59aaede7891f2dde3da0f46a6d3c684e0ae70f52d3db c-ares-1.10.0.tar.gz
Signature · 1 line
2.3.5
#1 lore raw

PATCH 2/3 package/cache-calibrator: add hash

---
 package/cache-calibrator/cache-calibrator.hash | 2 ++
 1 file changed, 2 insertions(+)
 create mode 100644 package/cache-calibrator/cache-calibrator.hash
package/cache-calibrator/cache-calibrator.hash new file +2 -0
new file mode 100644
index 0000000..df61d17
@@ -0,0 +1,2 @@
+# Locally calculated
+sha256 2018ed8fa733155d44ceb1c0066c5cf8df7771cdf7cfca0a07b8dd9bebd9c221 calibrator.c
Signature · 1 line
2.3.5
#2 lore raw

PATCH 2/3 package/cache-calibrator: add hash

Quoted 14 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabio" == Fabio Porcedda <[email protected]> writes:

---
 package/cache-calibrator/cache-calibrator.hash | 2 ++
 1 file changed, 2 insertions(+)
 create mode 100644 package/cache-calibrator/cache-calibrator.hash
package/cache-calibrator/cache-calibrator.hash new file +0 -0
new file mode 100644
index 0000000..df61d17

package/cache-calibrator/cache-calibrator.hash line 2

Quoted 2 lines
package/cache-calibrator/cache-calibrator.hash new file +2 -0
@@ -0,0 +1,2 @@
+# Locally calculated
+sha256 2018ed8fa733155d44ceb1c0066c5cf8df7771cdf7cfca0a07b8dd9bebd9c221 calibrator.c

This will cause issues when/if that file ever gets updated - But then atleast we know and can update the hash.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH 2/3 package/cache-calibrator: add hash

Peter, All,

On 2015-04-21 09:07 +0200, Peter Korsgaard spake thusly:

Quoted 8 lines
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabio" == Fabio Porcedda <[email protected]> writes:

---
 package/cache-calibrator/cache-calibrator.hash | 2 ++
 1 file changed, 2 insertions(+)
 create mode 100644 package/cache-calibrator/cache-calibrator.hash
Quoted 11 lines

package/cache-calibrator/cache-calibrator.hash line 2

Quoted 8 lines
package/cache-calibrator/cache-calibrator.hash new file +2 -0
new file mode 100644
index 0000000..df61d17
@@ -0,0 +1,2 @@
+# Locally calculated
+sha256 2018ed8fa733155d44ceb1c0066c5cf8df7771cdf7cfca0a07b8dd9bebd9c221 calibrator.c

This will cause issues when/if that file ever gets updated - But then atleast we know and can update the hash.

It also means that Buildroot 2015.05 will stop working at some point when this file is updated. The problem is not much about Buildroot master , which is easily fixable, but about our releases, that get broken as soon as upstream changes that file.

I am not really happy with either solutions: either add a hash and break releases in the future, or not add a hash file, and miss updates, especially in the autobuilders (even though they do remove downloads from time to time.

One case for the adding the hash, too, is that it will tell people that their local copy in their local cache (e.g. my ~/src/ ) is out-of-date.

Still, I'm not convinced we want that hash...

Do we have other such packages (I think I read there was another version-less package for now)?

Regards,
Yann E. MORIN.

Quoted 8 lines

Committed, thanks.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#4 lore raw

PATCH 2/3 package/cache-calibrator: add hash

Dear Yann E. MORIN,

Quoted 2 lines · Yann E. MORIN

Do we have other such packages (I think I read there was another version-less package for now)?

For makedevs, we simply bundle the source code in Buildroot. But it's more a core tool, that we have improved for our own purposes.

calibrator.c is only 38KB, so we could integrate it in package/cache-calibrator/ directly, but it's not very nice either.

Thoas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#5 lore raw

PATCH 2/3 package/cache-calibrator: add hash

In reply to Yann E. MORIN
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Hi,

Quoted 8 lines
Quoted 2 lines

This will cause issues when/if that file ever gets updated - But then atleast we know and can update the hash.

It also means that Buildroot 2015.05 will stop working at some point when this file is updated. The problem is not much about Buildroot master , which is easily fixable, but about our releases, that get broken as soon as upstream changes that file.

Quoted 4 lines

I am not really happy with either solutions: either add a hash and break releases in the future, or not add a hash file, and miss updates, especially in the autobuilders (even though they do remove downloads from time to time.

True - I don't really think there's any good solution to this (besides maybe convincing upstream to version their releases).

Quoted 4 lines

One case for the adding the hash, too, is that it will tell people that their local copy in their local cache (e.g. my ~/src/ ) is out-of-date.

Still, I'm not convinced we want that hash...

Maybe not. Perhaps the breakage from wrong hash is worse than the potential breakage from newer versions. Also notice that the download support falls back to our local copy on sources.buildroot.net if the hash doesn't match.

Quoted 2 lines

Do we have other such packages (I think I read there was another version-less package for now)?

Yes, we do:

git grep 'SOURCE =.*\.c$' package/cache-calibrator/cache-calibrator.mk:CACHE_CALIBRATOR_SOURCE = calibrator.c package/devmem2/devmem2.mk:DEVMEM2_SOURCE = devmem2.c package/whetstone/whetstone.mk:WHETSTONE_SOURCE = whetstone.c

Signature · 2 lines
Venlig hilsen,
Peter Korsgaard 
#6 lore raw

PATCH 2/3 package/cache-calibrator: add hash

Quoted 33 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Hi,

Quoted 8 lines
Quoted 2 lines

This will cause issues when/if that file ever gets updated - But then atleast we know and can update the hash.

It also means that Buildroot 2015.05 will stop working at some point when this file is updated. The problem is not much about Buildroot master , which is easily fixable, but about our releases, that get broken as soon as upstream changes that file.

Quoted 4 lines

I am not really happy with either solutions: either add a hash and break releases in the future, or not add a hash file, and miss updates, especially in the autobuilders (even though they do remove downloads from time to time.

True - I don't really think there's any good solution to this (besides maybe convincing upstream to version their releases).

Quoted 4 lines

One case for the adding the hash, too, is that it will tell people that their local copy in their local cache (e.g. my ~/src/ ) is out-of-date.

Still, I'm not convinced we want that hash...

Maybe not. Perhaps the breakage from wrong hash is worse than the potential breakage from newer versions. Also notice that the download support falls back to our local copy on sources.buildroot.net if the hash doesn't match.

Quoted 2 lines

Do we have other such packages (I think I read there was another version-less package for now)?

Quoted 7 lines

Yes, we do:

git grep 'SOURCE =.*\.c$' package/cache-calibrator/cache-calibrator.mk:CACHE_CALIBRATOR_SOURCE = calibrator.c package/devmem2/devmem2.mk:DEVMEM2_SOURCE = devmem2.c package/whetstone/whetstone.mk:WHETSTONE_SOURCE = whetstone.c

If the upstream is not willing to version those files what about creating a github repositories for them? Also to be able to check the hash on github files we just need to attach the binary for each release.

BR

Signature · 1 line
Fabio Porcedda
#7 lore raw

PATCH 3/3 package/clapack: add hash

In reply to Fabio Porcedda
---
 package/clapack/clapack.hash | 2 ++
 1 file changed, 2 insertions(+)
 create mode 100644 package/clapack/clapack.hash
package/clapack/clapack.hash new file +2 -0
new file mode 100644
index 0000000..08657fc
@@ -0,0 +1,2 @@
+# Locally calculated
+sha256 0b3f782bc24845d85f36bafbff0f2f1384dc72df730fda4e7924ec1a70baca5a clapack-3.2.1-CMAKE.tgz
Signature · 1 line
2.3.5
#9 lore raw

PATCH 1/3 package/c-ares: add hash

In reply to Fabio Porcedda
Quoted 14 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabio" == Fabio Porcedda <[email protected]> writes:

---
 package/c-ares/c-ares.hash | 2 ++
 1 file changed, 2 insertions(+)
 create mode 100644 package/c-ares/c-ares.hash
package/c-ares/c-ares.hash new file +0 -0
new file mode 100644
index 0000000..ce614d8

package/c-ares/c-ares.hash line 2

Quoted 2 lines
package/c-ares/c-ares.hash new file +2 -0
@@ -0,0 +1,2 @@
+# Locally calculated
+sha256 3d701674615d1158e56a59aaede7891f2dde3da0f46a6d3c684e0ae70f52d3db c-ares-1.10.0.tar.gz

Upstream provides a gpg signature, so I've verified against that and updated the comment, thanks.

Signature · 1 line
Bye, Peter Korsgaard