Skip to contentSkip to conversation

revert c72c6160d967ed26a0b136dbab337f821d233509

DISCUSSION Sergey Senozhatsky 1 participant 1 message Apr 22, 2015

lore
Share & tools
lore
#0 lore raw

Hello,

could you please revert c72c6160d967ed26a0b136dbab337f821d233509 ?

Commit c72c6160d967 ("zram: move compact_store() to sysfs functions area") was intended to be a cosmetic change that w/o any functional change and was part of a bigger change:
http://lkml.iu.edu/hypermail/linux/kernel/1503.1/01818.html

(so c72c6160d967 removes compaction support).

my bad, we managed to create a mess of patches for 4.1, so Andrew had to manually pick up and alter some commits. it didn't work well for that one.

so we can either add missing compaction sysfs attr, or revert this change. Minchan Kim and I prefer to revert this commit
http://lkml.iu.edu/hypermail/linux/kernel/1504.2/00623.html

since it doesn't add any value to 4.1 per se.

I will re-submit it for 4.2 (along with the above mentioned bigger change).

	-ss